From: ludo@gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 26420@debbugs.gnu.org
Subject: bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
Date: Mon, 10 Apr 2017 14:43:54 +0200 [thread overview]
Message-ID: <87a87ocu0l.fsf@gnu.org> (raw)
In-Reply-To: <5cb979bd.AEQAJFaVgOkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABY61Dr@mailjet.com> (Arun Isaac's message of "Mon, 10 Apr 2017 15:01:14 +0530")
Arun Isaac <arunisaac@systemreboot.net> skribis:
>>> + (arguments
>>> + `(#:phases
>>> + (modify-phases %standard-phases
>>> + ;; tests fail in this release
>>> + (add-before 'install 'check
>>> + (lambda _
>>> + (zero? (system* "emacs" "--batch" "-L" "."
>>> + "-l" "use-package-tests.el"
>>> + "-f" "ert-run-tests-batch-and-exit"))
>>> + #t)))))
>>
>> Please remove #t as it would hide a failure of the “emacs --batch”
>> command above.
>
> As noted in the comment, the tests fail in this release. I have put the
> #t there to make the package build succeed. In the upstream git
> checkout, tests pass. So, in the next release, tests should pass. When
> updating the package, the #t should be removed. Is this ok? Shall I
> leave the #t there?
Oh sure. Maybe move the comment closer to #t and, if you have the
reference of the upstream fix, you can put it there.
Thanks,
Ludo’.
next prev parent reply other threads:[~2017-04-10 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170409165703.9034-1-arunisaac@systemreboot.net>
2017-04-09 16:57 ` bug#26420: [PATCH 2/2] gnu: Add emacs-use-package Arun Isaac
2017-04-10 9:10 ` Ludovic Courtès
2017-04-10 9:31 ` Arun Isaac
[not found] ` <5cb979bd.AEQAJFaVgOkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABY61Dr@mailjet.com>
2017-04-10 12:43 ` Ludovic Courtès [this message]
2017-04-10 19:41 ` Arun Isaac
2017-04-10 19:43 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a87ocu0l.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26420@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).