From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50563)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxYgs-00062k-PI
	for guix-patches@gnu.org; Mon, 10 Apr 2017 08:45:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxYgo-0007eM-U2
	for guix-patches@gnu.org; Mon, 10 Apr 2017 08:45:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42465)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cxYgo-0007eI-Qs
	for guix-patches@gnu.org; Mon, 10 Apr 2017 08:45:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxYgo-00076D-LS
	for guix-patches@gnu.org; Mon, 10 Apr 2017 08:45:02 -0400
Subject: bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
Resent-Message-ID: <handler.26420.B26420.149182824727194@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170409165703.9034-1-arunisaac@systemreboot.net>
	<8c88a4c1.ADsAAHIoMD8AAAAAAAAAAAOzcd8AAAACwQwAAAAAAAW9WABY6mf5@mailjet.com>
	<878tn8hbl4.fsf@gnu.org>
	<5cb979bd.AEQAJFaVgOkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABY61Dr@mailjet.com>
Date: Mon, 10 Apr 2017 14:43:54 +0200
In-Reply-To: <5cb979bd.AEQAJFaVgOkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABY61Dr@mailjet.com>
	(Arun Isaac's message of "Mon, 10 Apr 2017 15:01:14 +0530")
Message-ID: <87a87ocu0l.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 26420@debbugs.gnu.org

Arun Isaac <arunisaac@systemreboot.net> skribis:

>>> +    (arguments
>>> +     `(#:phases
>>> +       (modify-phases %standard-phases
>>> +         ;; tests fail in this release
>>> +         (add-before 'install 'check
>>> +           (lambda _
>>> +             (zero? (system* "emacs" "--batch" "-L" "."
>>> +                             "-l" "use-package-tests.el"
>>> +                             "-f" "ert-run-tests-batch-and-exit"))
>>> +             #t)))))
>>
>> Please remove #t as it would hide a failure of the =E2=80=9Cemacs --batc=
h=E2=80=9D
>> command above.
>
> As noted in the comment, the tests fail in this release. I have put the
> #t there to make the package build succeed. In the upstream git
> checkout, tests pass. So, in the next release, tests should pass. When
> updating the package, the #t should be removed. Is this ok? Shall I
> leave the #t there?

Oh sure.  Maybe move the comment closer to #t and, if you have the
reference of the upstream fix, you can put it there.

Thanks,
Ludo=E2=80=99.