bug#27331: [PATCH] Handle EIO error in ENOENT-safe as well.

bug#27331: [PATCH] Handle EIO error in ENOENT-safe as well.

[Adam Van Ymeren]

Trying to boot GuixSD when an audio CD is in the drive will die with an
"input/output error" when trying to read the superblock from the cd
drive.

This patch catches and warns in this case rather than dying.
---
 gnu/build/file-systems.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
index 08f7d478e..f9cc4088b 100644
--- a/gnu/build/file-systems.scm
+++ b/gnu/build/file-systems.scm
@@ -419,6 +419,10 @@ warning and #f as the result."
                  #f)
                 ((= ENOMEDIUM errno)              ;for removable media
                  #f)
+                ((= EIO errno)                    ;unreadable hardware like audio CDs
+                 (format (current-error-port)
+                         "warning: failed to read from device '~a'~%" device)
+                 #f)
                 (else
                  (apply throw args))))))))

--
2.13.1

bug#27331: [PATCH] Handle EIO error in ENOENT-safe as well.

[Ludovic Courtès]

Hello,

Adam Van Ymeren <adam@vany.ca> skribis:

> Trying to boot GuixSD when an audio CD is in the drive will die with an
> "input/output error" when trying to read the superblock from the cd
> drive.
>
> This patch catches and warns in this case rather than dying.

Good catch!  I added a commit log following our conventions and
committed.

Thanks,
Ludo’.