From: Roel Janssen <roel@gnu.org>
To: 30379@debbugs.gnu.org
Subject: [bug#30379] [PATCH] gnu: bash: Don't specify default configuration filenames.
Date: Wed, 07 Feb 2018 12:39:09 +0100 [thread overview]
Message-ID: <87a7wlkp3a.fsf@gnu.org> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-bash-Don-t-specify-default-configuration-filenam.patch --]
[-- Type: text/x-patch, Size: 1170 bytes --]
From 6111b46f82a00560fa50f8860a4e9fd6b19fd0f1 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Wed, 7 Feb 2018 12:29:22 +0100
Subject: [PATCH] gnu: bash: Don't specify default configuration filenames.
* gnu/packages/bash.scm (bash): Remove SYS_BASHRC and SYS_BASH_LOGOUT.
---
gnu/packages/bash.scm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
index b8b0ae58f..59c3f6f10 100644
--- a/gnu/packages/bash.scm
+++ b/gnu/packages/bash.scm
@@ -92,9 +92,7 @@ number/base32-hash tuples, directly usable in the 'patch-series' form."
1))
(define-public bash
- (let* ((cppflags (string-join '("-DSYS_BASHRC='\"/etc/bashrc\"'"
- "-DSYS_BASH_LOGOUT='\"/etc/bash_logout\"'"
- "-DDEFAULT_PATH_VALUE='\"/no-such-path\"'"
+ (let* ((cppflags (string-join '("-DDEFAULT_PATH_VALUE='\"/no-such-path\"'"
"-DSTANDARD_UTILS_PATH='\"/no-such-path\"'"
"-DNON_INTERACTIVE_LOGIN_SHELLS"
"-DSSH_SOURCE_BASHRC")
--
2.16.1
[-- Attachment #2: Type: text/plain, Size: 735 bytes --]
Dear guix,
In bug #29337 I reported a “problem” with our Bash package: It reads
/etc/bashrc even when it shouldn't, according to its own documentation.
I also compared the behavior of Bash on CentOS to that of Bash on Guix
with the following test:
> On CentOS 7, the following happens (yes, I added the echo-statement to
> /etc/bashrc on CentOS as well):
> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
> Goodbye, world
>
> On GuixSD:
> $ env - bash --init-file <(echo "echo \"Goodbye, world\"") -i
> Hello, world
> Goodbye, world
I attached the proposed patch (removing -DSYS_BASHRC). May I push this
to core-updates now, or should I wait for the next core-updates cycle?
Thanks!
Kind regards,
Roel Janssen
next reply other threads:[~2018-02-07 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 11:39 Roel Janssen [this message]
2018-02-09 14:06 ` [bug#30379] [PATCH] gnu: bash: Don't specify default configuration filenames Ludovic Courtès
2018-03-03 21:55 ` Ludovic Courtès
2018-03-04 14:22 ` Roel Janssen
2018-06-10 5:01 ` bug#30379: Status: " 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7wlkp3a.fsf@gnu.org \
--to=roel@gnu.org \
--cc=30379@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).