unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: iyzsong@member.fsf.org (宋文武)
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33395-done@debbugs.gnu.org
Subject: bug#33395: [PATCH 1/2] gnu: Add liblcf.
Date: Sun, 09 Dec 2018 09:35:24 +0800	[thread overview]
Message-ID: <87a7lfwkgz.fsf@member.fsf.org> (raw)
In-Reply-To: <874lbo9mgr.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 08 Dec 2018 14:28:36 +0100")

Ludovic Courtès <ludo@gnu.org> writes:

> iyzsong@member.fsf.org (宋文武) skribis:
>
>> ludo@gnu.org (Ludovic Courtès) writes:
>>
>>> Hello 宋文武!
>>>
>>> 宋文武 <iyzsong@member.fsf.org> skribis:
>>>
>>>> * gnu/packages/easyrpg.scm: New file.
>>>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>>>
>>> Should it go to game-development.scm?
>>
>> Not sure, but I'd prefer it go into the same file with 'easyrpg-player',
>> which IMO dosen't belong into 'games.scm'...
>
> OK, sounds good.
>
>>>
>>>> +    (synopsis "Library to handle RPG Maker 2000 and 2003 game data")
>>>> +    (description
>>>> +     "@code{liblcf} is a library to handle RPG Maker 2000 and 2003 game data.
>>>> +It can read and write LCF and XML files.")
>>>> +    ;; It bundles Boost Preprocessor Cat and Stringize (boost-1.0) and a copy
>>>> +    ;; of inih (bsd-3).
>>>> +    (license license:expat)))
>>>
>>> Could these things be unbundled?  If not, could you leave a comment
>>> possibly with a TODO?
>>
>> Ok, how about:
>>
>>     ;; It includes a copy of Boost Preprocessor Cat and Stringize (boost-1.0):
>>     ;;   src/boost/preprocessor/config.hpp
>>     ;;   src/boost/preprocessor/cat.hpp
>>     ;;   src/boost/preprocessor/stringize.hpp
>>     ;; and a copy of inih (bsd-3):
>>     ;;   src/ini.h
>>     ;;   src/ini.cpp
>>     ;;   src/initreader.cpp
>>     ;; TODO: Unbundle them.
>
> LGTM!

Done, thanks!

      reply	other threads:[~2018-12-09  1:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 11:12 [bug#33395] [PATCH 1/2] gnu: Add liblcf 宋文武
2018-11-15 11:12 ` [bug#33396] [PATCH 2/2] gnu: Add easyrpg-player 宋文武
2018-12-09  1:35   ` bug#33396: " 宋文武
2018-11-27 11:00 ` [bug#33395] [PATCH 1/2] gnu: Add liblcf Ludovic Courtès
2018-12-08  3:30   ` 宋文武
2018-12-08 13:28     ` Ludovic Courtès
2018-12-09  1:35       ` 宋文武 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7lfwkgz.fsf@member.fsf.org \
    --to=iyzsong@member.fsf.org \
    --cc=33395-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).