From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38762)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVo1X-0007hE-Pa
	for guix-patches@gnu.org; Sat, 08 Dec 2018 20:37:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVo0o-0001Jl-M6
	for guix-patches@gnu.org; Sat, 08 Dec 2018 20:36:47 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:34815)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gVo0o-0001Ig-DI
	for guix-patches@gnu.org; Sat, 08 Dec 2018 20:36:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gVo0o-0003JW-7w
	for guix-patches@gnu.org; Sat, 08 Dec 2018 20:36:02 -0500
Subject: bug#33395: [PATCH 1/2] gnu: Add liblcf.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.33395.D33395.154431933712685.done@debbugs.gnu.org>
From: iyzsong@member.fsf.org (=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?=)
References: <20181115111223.1982-1-iyzsong@member.fsf.org>
	<871s76bxa4.fsf@gnu.org> <87zhtgelv9.fsf@member.fsf.org>
	<874lbo9mgr.fsf@gnu.org>
Date: Sun, 09 Dec 2018 09:35:24 +0800
In-Reply-To: <874lbo9mgr.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Sat, 08 Dec 2018 14:28:36 +0100")
Message-ID: <87a7lfwkgz.fsf@member.fsf.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 33395-done@debbugs.gnu.org

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis:
>
>> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>>
>>> Hello =E5=AE=8B=E6=96=87=E6=AD=A6!
>>>
>>> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@member.fsf.org> skribis:
>>>
>>>> * gnu/packages/easyrpg.scm: New file.
>>>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>>>
>>> Should it go to game-development.scm?
>>
>> Not sure, but I'd prefer it go into the same file with 'easyrpg-player',
>> which IMO dosen't belong into 'games.scm'...
>
> OK, sounds good.
>
>>>
>>>> +    (synopsis "Library to handle RPG Maker 2000 and 2003 game data")
>>>> +    (description
>>>> +     "@code{liblcf} is a library to handle RPG Maker 2000 and 2003 ga=
me data.
>>>> +It can read and write LCF and XML files.")
>>>> +    ;; It bundles Boost Preprocessor Cat and Stringize (boost-1.0) an=
d a copy
>>>> +    ;; of inih (bsd-3).
>>>> +    (license license:expat)))
>>>
>>> Could these things be unbundled?  If not, could you leave a comment
>>> possibly with a TODO?
>>
>> Ok, how about:
>>
>>     ;; It includes a copy of Boost Preprocessor Cat and Stringize (boost=
-1.0):
>>     ;;   src/boost/preprocessor/config.hpp
>>     ;;   src/boost/preprocessor/cat.hpp
>>     ;;   src/boost/preprocessor/stringize.hpp
>>     ;; and a copy of inih (bsd-3):
>>     ;;   src/ini.h
>>     ;;   src/ini.cpp
>>     ;;   src/initreader.cpp
>>     ;; TODO: Unbundle them.
>
> LGTM!

Done, thanks!