[bug#34931] [PATCH 0/5] Add gPodder.

[bug#34931] [PATCH 0/5] Add gPodder.

[Pierre Langlois]

Hello Guix!

Here is a patch series to add gPodder [0] and its dependencies. Since
we have a few packages from the same project I thought we'd add a new
gpodder.scm file for them.

What do you think?

Thanks!
Pierre

[0]: https://gpodder.github.io

Pierre Langlois (5):
  gnu: libmygpo-qt: Move to new 'gpodder.scm' file.
  gnu: Add python-podcastparser.
  gnu: Add python-minimock.
  gnu: Add python-mygpoclient.
  gnu: Add gPodder.

 gnu/local.mk             |   1 +
 gnu/packages/check.scm   |  22 +++++
 gnu/packages/gpodder.scm | 170 +++++++++++++++++++++++++++++++++++++++
 gnu/packages/music.scm   |  31 +------
 4 files changed, 194 insertions(+), 30 deletions(-)
 create mode 100644 gnu/packages/gpodder.scm

--
2.21.0

[bug#34931] [PATCH 1/5] gnu: libmygpo-qt: Move to new 'gpodder.scm' file.

[Pierre Langlois]

* gnu/packages/music.scm (libmygpo-qt): Move to 'gpodder.scm'.
* gnu/packages/gpodder.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk             |  1 +
 gnu/packages/gpodder.scm | 56 ++++++++++++++++++++++++++++++++++++++++
 gnu/packages/music.scm   | 31 +---------------------
 3 files changed, 58 insertions(+), 30 deletions(-)
 create mode 100644 gnu/packages/gpodder.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index a5a2f11538..f8a1fe17af 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -212,6 +212,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/gobby.scm			\
   %D%/packages/golang.scm			\
   %D%/packages/gperf.scm			\
+  %D%/packages/gpodder.scm			\
   %D%/packages/gprolog.scm			\
   %D%/packages/gps.scm				\
   %D%/packages/graph.scm			\
diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
new file mode 100644
index 0000000000..c0150402c4
--- /dev/null
+++ b/gnu/packages/gpodder.scm
@@ -0,0 +1,56 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages gpodder)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system cmake)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages qt))
+
+(define-public libmygpo-qt
+  (package
+    (name "libmygpo-qt")
+    (version "1.1.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://stefan.derkits.at/files/"
+                                  "libmygpo-qt/libmygpo-qt." version ".tar.gz"))
+              (sha256
+               (base32
+                "1kg18qrq2rsswgzhl65r3mlyx7kpqg4wwnbp4yiv6svvmadmlxl2"))
+              (patches (search-patches "libmygpo-qt-fix-qt-5.11.patch"
+                                       "libmygpo-qt-missing-qt5-modules.patch"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qt" ,qtbase)))
+    (arguments
+     `(#:configure-flags '("-DMYGPO_BUILD_TESTS=ON")
+       ;; TODO: Enable tests when https://github.com/gpodder/gpodder/issues/446
+       ;; is fixed.
+       #:tests? #f))
+    (home-page "http://wiki.gpodder.org/wiki/Libmygpo-qt")
+    (synopsis "Qt/C++ library wrapping the gpodder web service")
+    (description "@code{libmygpo-qt} is a Qt/C++ library wrapping the
+@url{https://gpodder.net} APIs.  It allows applications to discover, manage
+and track podcasts.")
+    (license license:lgpl2.1+)))
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2b533e6d26..d541f51ab9 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -88,6 +88,7 @@
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gpodder)
   #:use-module (gnu packages graphics)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages gtk)
@@ -4009,36 +4010,6 @@ OSC connections.")
 the electronic or dubstep genre.")
     (license license:gpl3+)))

-(define-public libmygpo-qt
-  (package
-    (name "libmygpo-qt")
-    (version "1.1.0")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "http://stefan.derkits.at/files/"
-                                  "libmygpo-qt/libmygpo-qt." version ".tar.gz"))
-              (sha256
-               (base32
-                "1kg18qrq2rsswgzhl65r3mlyx7kpqg4wwnbp4yiv6svvmadmlxl2"))
-              (patches (search-patches "libmygpo-qt-fix-qt-5.11.patch"
-                                       "libmygpo-qt-missing-qt5-modules.patch"))))
-    (build-system cmake-build-system)
-    (native-inputs
-     `(("pkg-config" ,pkg-config)))
-    (inputs
-     `(("qt" ,qtbase)))
-    (arguments
-     `(#:configure-flags '("-DMYGPO_BUILD_TESTS=ON")
-       ;; TODO: Enable tests when https://github.com/gpodder/gpodder/issues/446
-       ;; is fixed.
-       #:tests? #f))
-    (home-page "http://wiki.gpodder.org/wiki/Libmygpo-qt")
-    (synopsis "Qt/C++ library wrapping the gpodder web service")
-    (description "@code{libmygpo-qt} is a Qt/C++ library wrapping the
-@url{https://gpodder.net} APIs.  It allows applications to discover, manage
-and track podcasts.")
-    (license license:lgpl2.1+)))
-
 (define-public sonivox-eas
   (package
     (name "sonivox-eas")
--
2.21.0

[bug#34931] [PATCH 2/5] gnu: Add python-podcastparser.

[Pierre Langlois]

* gnu/packages/podcast.scm (python-podcastparser): New variable.
---
 gnu/packages/gpodder.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
index c0150402c4..5b872908a5 100644
--- a/gnu/packages/gpodder.scm
+++ b/gnu/packages/gpodder.scm
@@ -21,7 +21,9 @@
   #:use-module (guix packages)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system python)
   #:use-module (gnu packages)
+  #:use-module (gnu packages check)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages qt))

@@ -54,3 +56,24 @@
 @url{https://gpodder.net} APIs.  It allows applications to discover, manage
 and track podcasts.")
     (license license:lgpl2.1+)))
+
+(define-public python-podcastparser
+  (package
+    (name "python-podcastparser")
+    (version "0.6.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "podcastparser" version))
+       (sha256
+        (base32
+         "1ksj1gcmbnm5i43xhpqxbs2mqi6xzawwwkwbh9h6lwa1wxxvv247"))))
+    (native-inputs
+     `(("python-nose" ,python-nose)))
+    (build-system python-build-system)
+    (home-page "http://gpodder.org/podcastparser")
+    (synopsis "Simplified and fast RSS parser Python library")
+    (description "@code{podcastparser} is a library for the gPodder project to
+provide an easy and reliable way of parsing RSS and Atom-based podcast feeds
+in Python.")
+    (license license:isc)))
--
2.21.0

[bug#34931] [PATCH 3/5] gnu: Add python-minimock.

[Pierre Langlois]

* gnu/packages/check.scm (python-minimock, python2-minimock): New
variables.
---
 gnu/packages/check.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 4229578f86..9a88a8d873 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -28,6 +28,7 @@
 ;;; Copyright © 2016, 2017, 2018 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2017, 2018 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2018 Fis Trivial <ybbs.daans@hotmail.com>
+;;; Copyright © 2019 Pierre Langlois <pierre.langlois@gmx.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -549,6 +550,27 @@ for every Python test framework.  It supports nose, py.test, and unittest.")
 (define-public python2-parameterized
   (package-with-python2 python-parameterized))

+(define-public python-minimock
+  (package
+    (name "python-minimock")
+    (version "1.2.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "MiniMock" version))
+       (sha256
+        (base32
+         "0k2sxb1ibnyg05iblz7zhbv825f1zk9906rab7883iqgvzmdzpsz"))))
+    (build-system python-build-system)
+    (home-page "https://pypi.org/project/MiniMock")
+    (synopsis "Simple Python library for using mock objects")
+    (description "MiniMock is a simple library for building mock objects with
+doctest.")
+    (license license:expat)))
+
+(define-public python2-minimock
+  (package-with-python2 python-minimock))
+
 (define-public python-mock
   (package
     (name "python-mock")
--
2.21.0

[bug#34931] [PATCH 4/5] gnu: Add python-mygpoclient.

[Pierre Langlois]

* gnu/packages/podcast.scm (python-mygpoclient, python2-mygpoclient): New
variables.
---
 gnu/packages/gpodder.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
index 5b872908a5..654d6b2f96 100644
--- a/gnu/packages/gpodder.scm
+++ b/gnu/packages/gpodder.scm
@@ -57,6 +57,28 @@
 and track podcasts.")
     (license license:lgpl2.1+)))

+(define-public python-mygpoclient
+  (package
+    (name "python-mygpoclient")
+    (version "1.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "mygpoclient" version))
+       (sha256
+        (base32
+         "1fi5x6k1mngr0iviw2s4n1f3y2x7pwqy5ivkcrjdprzvwr37f0mh"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-minimock" ,python-minimock)))
+    (home-page "https://mygpoclient.readthedocs.io")
+    (synopsis "Python library for the gPodder web service")
+    (description "@code{mygpoclient} provides an easy and structured way to
+access the @url{https://gpodder.net} web services.  In addition to
+subscription list synchronization and storage, the API supports uploading and
+downloading episode status changes.")
+    (license license:gpl3)))
+
 (define-public python-podcastparser
   (package
     (name "python-podcastparser")
--
2.21.0

[bug#34931] [PATCH 4/5] gnu: Add python-mygpoclient.

[swedebugia]

On 2019-03-21 01:22, Pierre Langlois wrote:
> * gnu/packages/podcast.scm (python-mygpoclient, python2-mygpoclient): New
> variables.
> ---
>   gnu/packages/gpodder.scm | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
> index 5b872908a5..654d6b2f96 100644
> --- a/gnu/packages/gpodder.scm
> +++ b/gnu/packages/gpodder.scm
> @@ -57,6 +57,28 @@
>   and track podcasts.")
>       (license license:lgpl2.1+)))
> 
> +(define-public python-mygpoclient
> +  (package
> +    (name "python-mygpoclient")
> +    (version "1.8")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "mygpoclient" version))
> +       (sha256
> +        (base32
> +         "1fi5x6k1mngr0iviw2s4n1f3y2x7pwqy5ivkcrjdprzvwr37f0mh"))))
> +    (build-system python-build-system)
> +    (native-inputs
> +     `(("python-minimock" ,python-minimock)))
> +    (home-page "https://mygpoclient.readthedocs.io")
> +    (synopsis "Python library for the gPodder web service")
> +    (description "@code{mygpoclient} provides an easy and structured way to
> +access the @url{https://gpodder.net} web services.  In addition to
> +subscription list synchronization and storage, the API supports uploading and
> +downloading episode status changes.")
> +    (license license:gpl3)))

According to the files it is gpl3+

Apart from that LGTM.

Thanks!

-- 
Cheers Swedebugia

[bug#34931] [PATCH 4/5] gnu: Add python-mygpoclient.

[Pierre Langlois]

Hello!

swedebugia writes:

> On 2019-03-21 01:22, Pierre Langlois wrote:
>> * gnu/packages/podcast.scm (python-mygpoclient, python2-mygpoclient): New
>> variables.
>> ---
>>   gnu/packages/gpodder.scm | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>
>> diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
>> index 5b872908a5..654d6b2f96 100644
>> --- a/gnu/packages/gpodder.scm
>> +++ b/gnu/packages/gpodder.scm
>> @@ -57,6 +57,28 @@
>>   and track podcasts.")
>>       (license license:lgpl2.1+)))
>>
>> +(define-public python-mygpoclient
>> +  (package
>> +    (name "python-mygpoclient")
>> +    (version "1.8")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "mygpoclient" version))
>> +       (sha256
>> +        (base32
>> +         "1fi5x6k1mngr0iviw2s4n1f3y2x7pwqy5ivkcrjdprzvwr37f0mh"))))
>> +    (build-system python-build-system)
>> +    (native-inputs
>> +     `(("python-minimock" ,python-minimock)))
>> +    (home-page "https://mygpoclient.readthedocs.io")
>> +    (synopsis "Python library for the gPodder web service")
>> +    (description "@code{mygpoclient} provides an easy and structured way to
>> +access the @url{https://gpodder.net} web services.  In addition to
>> +subscription list synchronization and storage, the API supports uploading and
>> +downloading episode status changes.")
>> +    (license license:gpl3)))
>
> According to the files it is gpl3+

Oh, whoops I missed that! I'll submit an update by the end of the week!

Thanks!

[bug#34931] [PATCH 4/5] gnu: Add python-mygpoclient.

[Pierre Langlois]

Pierre Langlois writes:

> Hello!
>
> swedebugia writes:
>
>> On 2019-03-21 01:22, Pierre Langlois wrote:
>>> * gnu/packages/podcast.scm (python-mygpoclient, python2-mygpoclient): New
>>> variables.
>>> ---
>>>   gnu/packages/gpodder.scm | 22 ++++++++++++++++++++++
>>>   1 file changed, 22 insertions(+)
>>>
>>> diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
>>> index 5b872908a5..654d6b2f96 100644
>>> --- a/gnu/packages/gpodder.scm
>>> +++ b/gnu/packages/gpodder.scm
>>> @@ -57,6 +57,28 @@
>>>   and track podcasts.")
>>>       (license license:lgpl2.1+)))
>>>
>>> +(define-public python-mygpoclient
>>> +  (package
>>> +    (name "python-mygpoclient")
>>> +    (version "1.8")
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (pypi-uri "mygpoclient" version))
>>> +       (sha256
>>> +        (base32
>>> +         "1fi5x6k1mngr0iviw2s4n1f3y2x7pwqy5ivkcrjdprzvwr37f0mh"))))
>>> +    (build-system python-build-system)
>>> +    (native-inputs
>>> +     `(("python-minimock" ,python-minimock)))
>>> +    (home-page "https://mygpoclient.readthedocs.io")
>>> +    (synopsis "Python library for the gPodder web service")
>>> +    (description "@code{mygpoclient} provides an easy and structured way to
>>> +access the @url{https://gpodder.net} web services.  In addition to
>>> +subscription list synchronization and storage, the API supports uploading and
>>> +downloading episode status changes.")
>>> +    (license license:gpl3)))
>>
>> According to the files it is gpl3+
>
> Oh, whoops I missed that! I'll submit an update by the end of the week!

It looks like this was fixed before committing (see b58ab1598fc615f3f11ad7b439e61e0616117e2c).

Ludo must have either pointed it out or fixed it for me, I don't
remember :-).

Thanks,
Pierre

[bug#34931] [PATCH 5/5] gnu: Add gPodder.

[Pierre Langlois]

* gnu/packages/podcast.scm (gpodder): New variable.
---
 gnu/packages/gpodder.scm | 68 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)

diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
index 654d6b2f96..daf4b6b3b8 100644
--- a/gnu/packages/gpodder.scm
+++ b/gnu/packages/gpodder.scm
@@ -18,15 +18,83 @@

 (define-module (gnu packages gpodder)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix packages)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages freedesktop)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gtk)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages python-web)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages qt))

+(define-public gpodder
+  (package
+    (name "gpodder")
+    (version "3.10.7")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/gpodder/gpodder.git")
+             (commit version)))
+       (sha256
+        (base32
+         "0sx9rj6dpvd2xz7lak2yi0zlgr3lp2ng1fw23s39la9ly4g1835j"))
+       (file-name (git-file-name name version))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("intltool" ,intltool)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("python-pygobject" ,python-pygobject)
+       ("python-pycairo" ,python-pycairo)
+       ("python-dbus" ,python-dbus)
+       ("python-html5lib" ,python-html5lib)
+       ("python-mygpoclient" ,python-mygpoclient)
+       ("python-podcastparser" ,python-podcastparser)
+       ("xdg-utils" ,xdg-utils)))
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         ;; Avoid needing xdg-utils as a propagated input.
+         (add-after 'unpack 'patch-xdg-open
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((xdg-utils (assoc-ref inputs "xdg-utils")))
+               (substitute* "src/gpodder/util.py"
+                 (("xdg-open") (string-append xdg-utils "/bin/xdg-open")))
+               #t)))
+         (add-before 'install 'make-po-files-writable
+           (lambda _
+             (for-each
+               (lambda (f)
+                 (chmod f #o664))
+               (find-files "po"))))
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (setenv "PREFIX" (assoc-ref outputs "out"))
+             (invoke "make" "install")
+             #t))
+         (add-after 'install 'wrap-gpodder
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out"))
+                   (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
+               (wrap-program (string-append out "/bin/gpodder")
+                 `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))
+               #t))))))
+    (home-page "https://gpodder.github.io")
+    (synopsis "Simple podcast client")
+    (description "gPodder is a podcatcher, i.e. an application that allows
+podcast feeds (RSS, Atom, Youtube, Soundcloud, Vimeo and XSPF) to be
+subscribed to, checks for new episodes and allows the podcast to be saved
+locally for later listening.")
+    (license license:gpl3)))
+
 (define-public libmygpo-qt
   (package
     (name "libmygpo-qt")
--
2.21.0

bug#34931: [PATCH 5/5] gnu: Add gPodder.

[Ludovic Courtès]

Pierre Langlois <pierre.langlois@gmx.com> skribis:

> * gnu/packages/podcast.scm (gpodder): New variable.

I also changed the license to ‘gpl3+’ and committed.

Thank you!

Ludo’.

[bug#34931] [PATCH 0/5] Add gPodder.

[Ludovic Courtès]

Hello Pierre!

Pierre Langlois <pierre.langlois@gmx.com> skribis:

> Here is a patch series to add gPodder [0] and its dependencies. Since
> we have a few packages from the same project I thought we'd add a new
> gpodder.scm file for them.
>
> What do you think?

I think it’s a good idea.  All 5 patches LGTM.

Unfortunately, python-mygpoclient fails its tests for me:

--8<---------------cut here---------------start------------->8---
======================================================================
FAIL: test_BadRequest (mygpoclient.http_test.Test_HttpClient)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 158, in test_BadRequest
    self.assertRaises(BadRequest, client.GET, path)
AssertionError: BadRequest not raised by GET

======================================================================
FAIL: test_GET (mygpoclient.http_test.Test_HttpClient)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 163, in test_GET
    self.assertEquals(client.GET(path), self.RESPONSE)
AssertionError: b'' != b'Test_GET-HTTP-Response-Content'

======================================================================
FAIL: test_GET_after_PUT (mygpoclient.http_test.Test_HttpClient)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 200, in test_GET_after_PUT
    self.assertEquals(client.GET(path), self.RESPONSE + str(i).encode('utf-8'))
AssertionError: b'' != b'Test_GET-HTTP-Response-Content0'

======================================================================
FAIL: test_NotFound (mygpoclient.http_test.Test_HttpClient)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 148, in test_NotFound
    self.assertRaises(NotFound, client.GET, path)
AssertionError: NotFound not raised by GET

[…]
--8<---------------cut here---------------end--------------->8---

Could you take a look?

I’ve pushed the first three patches in the meantime.

Thanks,
Ludo’.

[bug#34931] [PATCH 0/5] Add gPodder.

[Pierre Langlois]

[-- Attachment #1: Type: text/plain, Size: 3242 bytes --]

Hi Ludo!

Thanks for taking a look!

Ludovic Courtès writes:

> Hello Pierre!
>
> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>
>> Here is a patch series to add gPodder [0] and its dependencies. Since
>> we have a few packages from the same project I thought we'd add a new
>> gpodder.scm file for them.
>>
>> What do you think?
>
> I think it’s a good idea.  All 5 patches LGTM.
>
> Unfortunately, python-mygpoclient fails its tests for me:
>
> --8<---------------cut here---------------start------------->8---
> ======================================================================
> FAIL: test_BadRequest (mygpoclient.http_test.Test_HttpClient)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 158, in test_BadRequest
>     self.assertRaises(BadRequest, client.GET, path)
> AssertionError: BadRequest not raised by GET
>
> ======================================================================
> FAIL: test_GET (mygpoclient.http_test.Test_HttpClient)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 163, in test_GET
>     self.assertEquals(client.GET(path), self.RESPONSE)
> AssertionError: b'' != b'Test_GET-HTTP-Response-Content'
>
> ======================================================================
> FAIL: test_GET_after_PUT (mygpoclient.http_test.Test_HttpClient)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 200, in test_GET_after_PUT
>     self.assertEquals(client.GET(path), self.RESPONSE + str(i).encode('utf-8'))
> AssertionError: b'' != b'Test_GET-HTTP-Response-Content0'
>
> ======================================================================
> FAIL: test_NotFound (mygpoclient.http_test.Test_HttpClient)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/guix-build-python-mygpoclient-1.8.drv-0/mygpoclient-1.8/mygpoclient/http_test.py", line 148, in test_NotFound
>     self.assertRaises(NotFound, client.GET, path)
> AssertionError: NotFound not raised by GET
>
> […]
> --8<---------------cut here---------------end--------------->8---
>
> Could you take a look?

mmmm that's strange, I can't reproduce those failures, was it on master?

In the meantime, I noticed there was a makefile with a `test` target
which uses the `python-nose` and `python-coverage` packages to run the
tests instead. We can try this, I'm not sure I understand how the python
build system discovered the tests before.

Does the attached patch fix the problem for you? It's a bit of a shot in
the dark.

Also, I fixed the ChangeLog entry, the patch doesn't include a python2
version of the package since I don't expect packages other than gPodder
to depend on this.

Thanks,
Pierre


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-mygpoclient.patch --]
[-- Type: text/x-patch, Size: 1823 bytes --]

From 25a1f5a1543274988983cec8bb7e5b9363f382ef Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Wed, 20 Mar 2019 23:55:31 +0000
Subject: [PATCH] gnu: Add python-mygpoclient.

* gnu/packages/podcast.scm (python-mygpoclient): New variable.
---
 gnu/packages/gpodder.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
index 5b872908a5..4eda95e626 100644
--- a/gnu/packages/gpodder.scm
+++ b/gnu/packages/gpodder.scm
@@ -57,6 +57,36 @@
 and track podcasts.")
     (license license:lgpl2.1+)))

+(define-public python-mygpoclient
+  (package
+    (name "python-mygpoclient")
+    (version "1.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "mygpoclient" version))
+       (sha256
+        (base32
+         "1fi5x6k1mngr0iviw2s4n1f3y2x7pwqy5ivkcrjdprzvwr37f0mh"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ("python-minimock" ,python-minimock)
+       ("python-nose" ,python-nose)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "make" "test"))))))
+    (home-page "https://mygpoclient.readthedocs.io")
+    (synopsis "Python library for the gPodder web service")
+    (description "@code{mygpoclient} provides an easy and structured way to
+access the @url{https://gpodder.net} web services.  In addition to
+subscription list synchronization and storage, the API supports uploading and
+downloading episode status changes.")
+    (license license:gpl3)))
+
 (define-public python-podcastparser
   (package
     (name "python-podcastparser")
--
2.21.0

[bug#34931] [PATCH 0/5] Add gPodder.

[Pierre Langlois]

Pierre Langlois writes:

(snip)

>
> * gnu/packages/podcast.scm (python-mygpoclient): New variable.

Whoops, that's 'gpodder.scm' and not 'podcast.scm' too.

[bug#34931] [PATCH 0/5] Add gPodder.

[Pierre Langlois]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]


Pierre Langlois writes:

> Pierre Langlois writes:
>
> (snip)
>
>>
>> * gnu/packages/podcast.scm (python-mygpoclient): New variable.
>
> Whoops, that's 'gpodder.scm' and not 'podcast.scm' too.

Attached with ChangeLog fixed.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-mygpoclient.patch --]
[-- Type: text/x-patch, Size: 1823 bytes --]

From c91de4895afd53e40081501cd2db32bb47a5b92a Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Wed, 20 Mar 2019 23:55:31 +0000
Subject: [PATCH] gnu: Add python-mygpoclient.

* gnu/packages/gpodder.scm (python-mygpoclient): New variable.
---
 gnu/packages/gpodder.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/gpodder.scm b/gnu/packages/gpodder.scm
index 5b872908a5..4eda95e626 100644
--- a/gnu/packages/gpodder.scm
+++ b/gnu/packages/gpodder.scm
@@ -57,6 +57,36 @@
 and track podcasts.")
     (license license:lgpl2.1+)))

+(define-public python-mygpoclient
+  (package
+    (name "python-mygpoclient")
+    (version "1.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "mygpoclient" version))
+       (sha256
+        (base32
+         "1fi5x6k1mngr0iviw2s4n1f3y2x7pwqy5ivkcrjdprzvwr37f0mh"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ("python-minimock" ,python-minimock)
+       ("python-nose" ,python-nose)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "make" "test"))))))
+    (home-page "https://mygpoclient.readthedocs.io")
+    (synopsis "Python library for the gPodder web service")
+    (description "@code{mygpoclient} provides an easy and structured way to
+access the @url{https://gpodder.net} web services.  In addition to
+subscription list synchronization and storage, the API supports uploading and
+downloading episode status changes.")
+    (license license:gpl3)))
+
 (define-public python-podcastparser
   (package
     (name "python-podcastparser")
--
2.21.0

[bug#34931] [PATCH 0/5] Add gPodder.

[Ludovic Courtès]

Hi Pierre,

Pierre Langlois <pierre.langlois@gmx.com> skribis:

> From c91de4895afd53e40081501cd2db32bb47a5b92a Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois@gmx.com>
> Date: Wed, 20 Mar 2019 23:55:31 +0000
> Subject: [PATCH] gnu: Add python-mygpoclient.
>
> * gnu/packages/gpodder.scm (python-mygpoclient): New variable.

This one works for me.  I changed the license to ‘gpl3+’ because source
file headers carry the “or any later version” wording, and committed.

Thanks for investigating!

Ludo’.