From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Vinicius Monego <monego@posteo.net>
Cc: 41995@debbugs.gnu.org
Subject: [bug#41995] [PATCH 1/2] gnu: Add symengine.
Date: Wed, 24 Jun 2020 08:57:44 +0200 [thread overview]
Message-ID: <87a70tvtlj.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20200622010155.17641-1-monego@posteo.net> (Vinicius Monego's message of "Sun, 21 Jun 2020 22:01:54 -0300")
Hello,
Vinicius Monego <monego@posteo.net> writes:
> * gnu/packages/algebra.scm (symengine): New variable.
Thank you.
I couldn't build it because gperftools currently has a failing test.
> + '(#:configure-flags
> + '("-DCMAKE_BUILD_TYPE=Release"
> + "-DWITH_GMP=on"
> + "-DWITH_MPFR=on"
> + "-DWITH_MPC=on"
> + "-DINTEGER_CLASS=flint"
> + "-DWITH_LLVM=on"
> + "-DWITH_SYMENGINE_THREAD_SAFE=on"
IIUC correctly, these are the suggested build options in the README. It
may be worth adding a comment about it since this looks a bit
opinionated.
> + "-DWITH_TCMALLOC=on")))
This does not belong to the set of suggested build options. Is there
a particular reason to activate it? If so, would it make sense to add
a comment about it?
I also see there is a "BUILD_SHARED_LIBS" flag, off by default. Would it
make sense to activate it?
> + (license (list license:expat ;; SymEngine.
> + license:bsd-3)))) ;; Third party code.
In both comments, there should be a single semicolon and no full stop.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-06-24 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 1:01 [bug#41995] [PATCH 1/2] gnu: Add symengine Vinicius Monego
2020-06-22 1:01 ` [bug#41996] [PATCH 2/2] gnu: Add python-symengine Vinicius Monego
2020-06-24 6:58 ` Nicolas Goaziou
2020-06-24 6:57 ` Nicolas Goaziou [this message]
2020-06-24 13:39 ` [bug#41995] [PATCH 1/2] gnu: Add symengine Vinicius Monego
2020-06-24 17:49 ` bug#41995: " Nicolas Goaziou
2020-06-24 13:16 ` [bug#41995] " Vinicius Monego
2020-06-24 13:16 ` [bug#41995] [PATCH 2/2] gnu: Add python-symengine Vinicius Monego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a70tvtlj.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=41995@debbugs.gnu.org \
--cc=monego@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).