From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OBqJKYP58l7vKwAA0tVLHw (envelope-from ) for ; Wed, 24 Jun 2020 06:58:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aIZkJYP58l4KWQAA1q6Kng (envelope-from ) for ; Wed, 24 Jun 2020 06:58:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 143299404D4 for ; Wed, 24 Jun 2020 06:58:10 +0000 (UTC) Received: from localhost ([::1]:36898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnzMG-0008UY-2y for larch@yhetil.org; Wed, 24 Jun 2020 02:58:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnzMA-0008Qu-0n for guix-patches@gnu.org; Wed, 24 Jun 2020 02:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnzM9-0002TD-NG for guix-patches@gnu.org; Wed, 24 Jun 2020 02:58:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnzM9-00061e-Lt for guix-patches@gnu.org; Wed, 24 Jun 2020 02:58:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41995] [PATCH 1/2] gnu: Add symengine. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Jun 2020 06:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41995 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 41995@debbugs.gnu.org Received: via spool by 41995-submit@debbugs.gnu.org id=B41995.159298186823143 (code B ref 41995); Wed, 24 Jun 2020 06:58:01 +0000 Received: (at 41995) by debbugs.gnu.org; 24 Jun 2020 06:57:48 +0000 Received: from localhost ([127.0.0.1]:37637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnzLw-00061D-Da for submit@debbugs.gnu.org; Wed, 24 Jun 2020 02:57:48 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:37199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnzLu-00060z-Bh for 41995@debbugs.gnu.org; Wed, 24 Jun 2020 02:57:47 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 5FCA1E0006; Wed, 24 Jun 2020 06:57:39 +0000 (UTC) From: Nicolas Goaziou References: <20200622010155.17641-1-monego@posteo.net> Date: Wed, 24 Jun 2020 08:57:44 +0200 In-Reply-To: <20200622010155.17641-1-monego@posteo.net> (Vinicius Monego's message of "Sun, 21 Jun 2020 22:01:54 -0300") Message-ID: <87a70tvtlj.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: O5DHVETbl+Fo Hello, Vinicius Monego writes: > * gnu/packages/algebra.scm (symengine): New variable. Thank you. I couldn't build it because gperftools currently has a failing test. > + '(#:configure-flags > + '("-DCMAKE_BUILD_TYPE=Release" > + "-DWITH_GMP=on" > + "-DWITH_MPFR=on" > + "-DWITH_MPC=on" > + "-DINTEGER_CLASS=flint" > + "-DWITH_LLVM=on" > + "-DWITH_SYMENGINE_THREAD_SAFE=on" IIUC correctly, these are the suggested build options in the README. It may be worth adding a comment about it since this looks a bit opinionated. > + "-DWITH_TCMALLOC=on"))) This does not belong to the set of suggested build options. Is there a particular reason to activate it? If so, would it make sense to add a comment about it? I also see there is a "BUILD_SHARED_LIBS" flag, off by default. Would it make sense to activate it? > + (license (list license:expat ;; SymEngine. > + license:bsd-3)))) ;; Third party code. In both comments, there should be a single semicolon and no full stop. Could you send an updated patch? Regards, -- Nicolas Goaziou