From: "Ludovic Courtès" <ludo@gnu.org>
To: Prafulla Giri <pratheblackdiamond@gmail.com>
Cc: 43198@debbugs.gnu.org
Subject: [bug#43198] Add breeze icon assets
Date: Mon, 07 Sep 2020 10:06:57 +0200 [thread overview]
Message-ID: <87a6y2rowu.fsf@gnu.org> (raw)
In-Reply-To: <CAFw+=j2GyvfVWw-qsR1ju4+CEVAzhfP7p6hociAfF1YcBDOuSg@mail.gmail.com> (Prafulla Giri's message of "Fri, 4 Sep 2020 16:43:33 +0545")
Hi,
Prafulla Giri <pratheblackdiamond@gmail.com> skribis:
> Yes, sir. It seems that breeze-assets is licensed under GPL2 only (I
> couldn't find "or any later version" in their license file:
> https://github.com/KDE/breeze/blob/master/COPYING
Section 9, reads:
If the Program does not specify a version number of this License, you
may choose any version ever published by the Free Software Foundation.
In this case, we use ‘gpl2+’ as the license.
> I am also concerned regarding the naming of the `breeze` package. I wonder
> if that is a good name. But I can't quite think of any other name.
> `kde-breeze`? `breeze-style`? I don't know... I worry that this name (if it
> is not the most convenient) might get stuck once it is merged and other
> packages start to build on top of it. I don't know.
The general convention is to stick to the upstream name:
https://guix.gnu.org/manual/en/html_node/Package-Naming.html
Regarding the union package, perhaps we can actually leave it up to
users to install both breeze-assets and breeze-icons if they want?
After all, since these are separate packages upstream, we don’t have to
provide a union of both. WDYT?
> From 464358cc945eeb4ffcb46b3ddfc36ee8894e9378 Mon Sep 17 00:00:00 2001
> From: Prafulla Giri <pratheblackdiamond@gmail.com>
> Date: Fri, 4 Sep 2020 12:56:26 +0545
> Subject: [PATCH 1/2] gnu: kde-frameworks: Add breeze-assets
>
> * gnu/packages/kde-frameworks.scm (breeze-assets): New variable.
[...]
> +(define-public breeze-assets
> + (package
> + (inherit breeze-icons)
> + (name "breeze-assets")
> + (version "5.19.5")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://codeload.github.com/KDE/breeze/tar.gz/v"
> + version))
> + (sha256
> + (base32
> + "12ffrm0nrhi2avq2z7jx3pdp0zgsxsary7gpfp60vvxs1jrvnk1b"))))
Could you change the URL to a mirror://kde URL?
<https://github.com/archlinux/svntogit-packages/blob/packages/breeze/trunk/PKGBUILD>
shows that the official tarballs can be obtained from kde.org.
With these last changes, we should be all set!
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-09-07 8:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 8:22 [bug#43198] Add breeze icon assets Prafulla Giri
2020-09-04 9:29 ` Ludovic Courtès
[not found] ` <CAFw+=j2GyvfVWw-qsR1ju4+CEVAzhfP7p6hociAfF1YcBDOuSg@mail.gmail.com>
2020-09-04 11:00 ` [bug#43198] Fwd: " Prafulla Giri
2020-09-07 8:06 ` Ludovic Courtès [this message]
2020-09-08 11:11 ` Prafulla Giri
2020-09-08 11:25 ` [bug#43198] Fwd: " Prafulla Giri
2020-09-09 7:26 ` bug#43198: " Ludovic Courtès
2020-09-09 8:27 ` [bug#43198] " Prafulla Giri
2020-10-26 19:07 ` [bug#43198] Questions about "Add breeze icon assets" Hartmut Goebel
2020-10-27 4:35 ` Prafulla Giri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6y2rowu.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43198@debbugs.gnu.org \
--cc=pratheblackdiamond@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).