From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OLUsDmnqVV9/NgAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 08:08:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iJMCCmnqVV9MSgAA1q6Kng (envelope-from ) for ; Mon, 07 Sep 2020 08:08:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D8B89401AE for ; Mon, 7 Sep 2020 08:08:08 +0000 (UTC) Received: from localhost ([::1]:55394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFCC6-000288-Bn for larch@yhetil.org; Mon, 07 Sep 2020 04:08:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFCC2-00027z-Ts for guix-patches@gnu.org; Mon, 07 Sep 2020 04:08:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36291) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFCC2-00005I-K4 for guix-patches@gnu.org; Mon, 07 Sep 2020 04:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFCC2-0004KO-Dg for guix-patches@gnu.org; Mon, 07 Sep 2020 04:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43198] Add breeze icon assets Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 08:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43198 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Prafulla Giri Cc: 43198@debbugs.gnu.org Received: via spool by 43198-submit@debbugs.gnu.org id=B43198.159946603116571 (code B ref 43198); Mon, 07 Sep 2020 08:08:02 +0000 Received: (at 43198) by debbugs.gnu.org; 7 Sep 2020 08:07:11 +0000 Received: from localhost ([127.0.0.1]:47837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFCBC-0004JC-P7 for submit@debbugs.gnu.org; Mon, 07 Sep 2020 04:07:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFCBA-0004Iz-F9 for 43198@debbugs.gnu.org; Mon, 07 Sep 2020 04:07:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37398) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFCB5-0008SZ-7t; Mon, 07 Sep 2020 04:07:03 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=54578 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kFCB4-0001Yq-OT; Mon, 07 Sep 2020 04:07:03 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Prafulla Giri's message of "Fri, 4 Sep 2020 16:43:33 +0545") References: <878sdpvqj6.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Fructidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 07 Sep 2020 10:06:57 +0200 Message-ID: <87a6y2rowu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Q61lvbCF/INS Hi, Prafulla Giri skribis: > Yes, sir. It seems that breeze-assets is licensed under GPL2 only (I > couldn't find "or any later version" in their license file: > https://github.com/KDE/breeze/blob/master/COPYING Section 9, reads: If the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation. In this case, we use =E2=80=98gpl2+=E2=80=99 as the license. > I am also concerned regarding the naming of the `breeze` package. I wonder > if that is a good name. But I can't quite think of any other name. > `kde-breeze`? `breeze-style`? I don't know... I worry that this name (if = it > is not the most convenient) might get stuck once it is merged and other > packages start to build on top of it. I don't know. The general convention is to stick to the upstream name: https://guix.gnu.org/manual/en/html_node/Package-Naming.html Regarding the union package, perhaps we can actually leave it up to users to install both breeze-assets and breeze-icons if they want? After all, since these are separate packages upstream, we don=E2=80=99t hav= e to provide a union of both. WDYT? > From 464358cc945eeb4ffcb46b3ddfc36ee8894e9378 Mon Sep 17 00:00:00 2001 > From: Prafulla Giri > Date: Fri, 4 Sep 2020 12:56:26 +0545 > Subject: [PATCH 1/2] gnu: kde-frameworks: Add breeze-assets > > * gnu/packages/kde-frameworks.scm (breeze-assets): New variable. [...] > +(define-public breeze-assets > + (package > + (inherit breeze-icons) > + (name "breeze-assets") > + (version "5.19.5") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://codeload.github.com/KDE/breeze/tar.gz/v" > + version)) > + (sha256 > + (base32 > + "12ffrm0nrhi2avq2z7jx3pdp0zgsxsary7gpfp60vvxs1jrvnk1b"))= )) Could you change the URL to a mirror://kde URL? shows that the official tarballs can be obtained from kde.org. With these last changes, we should be all set! Thanks, Ludo=E2=80=99.