unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Jesse Gibbons <jgibbons2357@gmail.com>
Cc: 43194@debbugs.gnu.org
Subject: [bug#43194] [PATCH] gnu: publicly define freedink-engine and freedink-data
Date: Mon, 07 Sep 2020 15:46:41 +0200	[thread overview]
Message-ID: <87a6y1itry.fsf@gnu.org> (raw)
In-Reply-To: <69eb1bb4-ff32-9267-84cf-0c36d52e32c1@gmail.com> (Jesse Gibbons's message of "Thu, 3 Sep 2020 22:33:31 -0600")

Hi,

Jesse Gibbons <jgibbons2357@gmail.com> skribis:

> The attached patch publicly defines freedink-engine and
> freedink-data. This resolves many of the issues described in
> #43061. This patch, combined with patch #43193(sent earlier today),
> can close #43061.

Now I’m confused: how does it help to make freedink-{engine,data}
public?

>>From 583215aced9b557d6f4e54b290e788d33880c03c Mon Sep 17 00:00:00 2001
> From: Jesse Gibbons <jgibbons2357+guix@gmail.com>
> Date: Wed, 26 Aug 2020 21:38:24 -0600
> Subject: [PATCH v1 1/1] gnu: publicly define freedink-engine and freedink-data
>
> * gnu/packages/games.scm: (freedink-engine): make public
> (freedink-data): make public

[...]

>  (define-public freedink
>    ;; This is a wrapper that tells the engine where to find the data.
> -  (package (inherit freedink-engine)
> +  (package ;(inherit freedink-engine)

Is it intended?  Looks like inheriting avoids duplicating fields, no?

Thanks,
Ludo’.




  reply	other threads:[~2020-09-07 13:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04  4:33 [bug#43194] [PATCH] gnu: publicly define freedink-engine and freedink-data Jesse Gibbons
2020-09-07 13:46 ` Ludovic Courtès [this message]
2020-09-07 17:13   ` Jesse Gibbons
2020-09-07 17:26     ` Ludovic Courtès
2020-09-24 15:18       ` Ludovic Courtès
2020-09-25  3:55         ` Jesse Gibbons
2020-09-25 16:29           ` bug#43194: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6y1itry.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43194@debbugs.gnu.org \
    --cc=jgibbons2357@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).