unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jesse Gibbons <jgibbons2357@gmail.com>
To: 43194@debbugs.gnu.org
Subject: [bug#43194] [PATCH] gnu: publicly define freedink-engine and freedink-data
Date: Thu, 3 Sep 2020 22:33:31 -0600	[thread overview]
Message-ID: <69eb1bb4-ff32-9267-84cf-0c36d52e32c1@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

The attached patch publicly defines freedink-engine and freedink-data. 
This resolves many of the issues described in #43061. This patch, 
combined with patch #43193(sent earlier today), can close #43061.

-Jesse


[-- Attachment #2: v1-0001-gnu-publicly-define-freedink-engine-and-freedink-.patch --]
[-- Type: text/x-patch, Size: 2194 bytes --]

From 583215aced9b557d6f4e54b290e788d33880c03c Mon Sep 17 00:00:00 2001
From: Jesse Gibbons <jgibbons2357+guix@gmail.com>
Date: Wed, 26 Aug 2020 21:38:24 -0600
Subject: [PATCH v1 1/1] gnu: publicly define freedink-engine and freedink-data

* gnu/packages/games.scm: (freedink-engine): make public
(freedink-data): make public
---
 gnu/packages/games.scm | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index ccdc47d5c7..7540cf4603 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2859,7 +2859,7 @@ interface or via an external visual interface such as GNU XBoard.")
                   (ftp-directory . "/chess")))
     (license license:gpl3+)))
 
-(define freedink-engine
+(define-public freedink-engine
   (package
     (name "freedink-engine")
     (version "109.6")
@@ -2911,7 +2911,7 @@ game data files but it also supports user-produced game mods or \"D-Mods\".
 To that extent, it also includes a front-end for managing all of your D-Mods.")
     (license license:gpl3+)))
 
-(define freedink-data
+(define-public freedink-data
   (package
     (name "freedink-data")
     (version "1.08.20190120")
@@ -2963,8 +2963,10 @@ and its numerous D-Mods.")
 
 (define-public freedink
   ;; This is a wrapper that tells the engine where to find the data.
-  (package (inherit freedink-engine)
+  (package ;(inherit freedink-engine)
     (name "freedink")
+    (version (package-version freedink-engine))
+    (source #f)
     (build-system trivial-build-system)
     (arguments
      '(#:builder (begin
@@ -2987,7 +2989,13 @@ exec ~a/bin/freedink -refdir ~a/share/dink\n"
     (inputs `(("engine" ,freedink-engine)
               ("data" ,freedink-data)
               ("bash" ,bash)))
-    (native-inputs '())))
+    (native-inputs '())
+    (home-page (package-home-page freedink-engine))
+    (synopsis (package-synopsis freedink-engine))
+    (description (string-append (package-description freedink-engine)
+"\n\nThis package provides a wrapper that points the engine to
+the upstream \"vanilla\" data."))
+    (license license:gpl3+)))
 
 (define-public xboard
   (package
-- 
2.28.0


             reply	other threads:[~2020-09-04  4:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04  4:33 Jesse Gibbons [this message]
2020-09-07 13:46 ` [bug#43194] [PATCH] gnu: publicly define freedink-engine and freedink-data Ludovic Courtès
2020-09-07 17:13   ` Jesse Gibbons
2020-09-07 17:26     ` Ludovic Courtès
2020-09-24 15:18       ` Ludovic Courtès
2020-09-25  3:55         ` Jesse Gibbons
2020-09-25 16:29           ` bug#43194: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69eb1bb4-ff32-9267-84cf-0c36d52e32c1@gmail.com \
    --to=jgibbons2357@gmail.com \
    --cc=43194@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).