From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 43771@debbugs.gnu.org
Subject: [bug#43771] [PATCH 3/5] Remove the postgresql-service procedure
Date: Mon, 19 Oct 2020 20:01:12 +0100 [thread overview]
Message-ID: <87a6wihwg7.fsf@cbaines.net> (raw)
In-Reply-To: <87pn5x3wd0.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> It's unnecessary, using the service type directly is a better approach. While
>> this is unfortunately a breaking change, I'm also looking at making breaking
>> changes to the service type configuration, so I don't think this can be
>> avoided.
>
> [...]
>
>> -(define* (postgresql-service #:key (postgresql postgresql)
>> - (port 5432)
>> - (locale "en_US.utf8")
>
> Here I’d suggest to keep it as ‘define-deprecated’, like we did for
> other such procedures.
Ah, yeah, I discounted that initially, as I didn't see a way to adapt it
to the new behaviour, but the deprecated procedure can just have the old
behaviour.
I'll send some updated patches with it deprecated.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2020-10-19 19:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 18:36 [bug#43771] [PATCH 0/5] PostgreSQL service improvements Christopher Baines
2020-10-02 18:40 ` [bug#43771] [PATCH 1/5] Replace (postgresql-service) with (service postgresql-service-type) Christopher Baines
2020-10-02 18:40 ` [bug#43771] [PATCH 2/5] Add some subheadings in to the Databases section of the docs Christopher Baines
2020-10-02 18:40 ` [bug#43771] [PATCH 3/5] Remove the postgresql-service procedure Christopher Baines
2020-10-05 8:33 ` Ludovic Courtès
2020-10-19 19:01 ` Christopher Baines [this message]
2020-10-02 18:40 ` [bug#43771] [PATCH 4/5] Define postgresql-10 Christopher Baines
2020-10-02 18:40 ` [bug#43771] [PATCH 5/5] Don't specify a default postgresql version to use for the service Christopher Baines
2020-10-05 8:34 ` [bug#43771] [PATCH 0/5] PostgreSQL service improvements Ludovic Courtès
2020-10-19 19:02 ` [bug#43771] [PATCH v2 1/5] tests: monitoring: Use (service postgresql-service-type) Christopher Baines
2020-10-19 19:02 ` [bug#43771] [PATCH v2 2/5] doc: Add subheadings in to the Databases section Christopher Baines
2020-10-19 19:02 ` [bug#43771] [PATCH v2 3/5] services: databases: Deprecate the postgresql-service procedure Christopher Baines
2020-10-19 19:02 ` [bug#43771] [PATCH v2 4/5] gnu: databases: Define postgresql-10 Christopher Baines
2020-10-19 19:02 ` [bug#43771] [PATCH v2 5/5] services: databases: Don't specify a default postgresql version Christopher Baines
2020-10-19 21:02 ` [bug#43771] [PATCH 0/5] PostgreSQL service improvements Christopher Baines
2020-10-20 21:32 ` Ludovic Courtès
2020-10-20 22:41 ` bug#43771: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6wihwg7.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=43771@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).