From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CFEZKcXijV/xeQAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 19:02:29 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yNitJMXijV/sCQAAbx9fmQ (envelope-from ) for ; Mon, 19 Oct 2020 19:02:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E169E94023B for ; Mon, 19 Oct 2020 19:02:28 +0000 (UTC) Received: from localhost ([::1]:55464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUaQN-0007Ut-8e for larch@yhetil.org; Mon, 19 Oct 2020 15:02:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUaPy-0007TP-T0 for guix-patches@gnu.org; Mon, 19 Oct 2020 15:02:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUaPy-0000o5-JU for guix-patches@gnu.org; Mon, 19 Oct 2020 15:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUaPy-0008BL-HS for guix-patches@gnu.org; Mon, 19 Oct 2020 15:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43771] [PATCH 3/5] Remove the postgresql-service procedure Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Oct 2020 19:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43771 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43771@debbugs.gnu.org Received: via spool by 43771-submit@debbugs.gnu.org id=B43771.160313407831391 (code B ref 43771); Mon, 19 Oct 2020 19:02:02 +0000 Received: (at 43771) by debbugs.gnu.org; 19 Oct 2020 19:01:18 +0000 Received: from localhost ([127.0.0.1]:42417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaPF-0008AF-R2 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 15:01:18 -0400 Received: from mira.cbaines.net ([212.71.252.8]:34586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaPD-0008A7-Mc for 43771@debbugs.gnu.org; Mon, 19 Oct 2020 15:01:16 -0400 Received: from localhost (188.28.126.178.threembb.co.uk [188.28.126.178]) by mira.cbaines.net (Postfix) with ESMTPSA id AB50E27BBED; Mon, 19 Oct 2020 20:01:14 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id cb320287; Mon, 19 Oct 2020 19:01:12 +0000 (UTC) References: <20201002184059.29033-1-mail@cbaines.net> <20201002184059.29033-3-mail@cbaines.net> <87pn5x3wd0.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <87pn5x3wd0.fsf@gnu.org> Date: Mon, 19 Oct 2020 20:01:12 +0100 Message-ID: <87a6wihwg7.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.11 X-TUID: UoWF1+S/84Af --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Christopher Baines skribis: > >> It's unnecessary, using the service type directly is a better approach. = While >> this is unfortunately a breaking change, I'm also looking at making brea= king >> changes to the service type configuration, so I don't think this can be >> avoided. > > [...] > >> -(define* (postgresql-service #:key (postgresql postgresql) >> - (port 5432) >> - (locale "en_US.utf8") > > Here I=E2=80=99d suggest to keep it as =E2=80=98define-deprecated=E2=80= =99, like we did for > other such procedures. Ah, yeah, I discounted that initially, as I didn't see a way to adapt it to the new behaviour, but the deprecated procedure can just have the old behaviour. I'll send some updated patches with it deprecated. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+N4nhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xd5iRAAqQcGqQQ10D0puIDptLEe6YDC13p+lSLh i/TniWEDyxqrQWik49nYyPubvqjG2mLmy/QAmn4kMghkmufzPIF+QNYzbSi3t13J y8jVFszDOd/d4roe4Ox0sP8epqsofIVDfZVQrQee/2gQNIko/RLehc9r/BgB6bxe nw21O03UNqkkgjZYxu8R8L7nYoo3Sntr/WDwd8BOiTm+NjSEZ/8OWIJz34Qpe53T QV346n78RH9Nzi7NVgImqX0uSxx6Xp1m3nQLWWsHtpQUmU6p/T7FMDTfOgAteJoG svn9oUXNtHM9tlWu6G8FbRkfRA3vNjKEpAu6w9dC1NpUpFawRq+WOnQZaKr6bMj0 v/NddxelIZIsrKXlTgCgIOBZ4adTDLMq9f0nuzExWi6IWdlvKL8ekQHCQeTK/ycY MuBwwimB61Q5w2cLeUuJ4W2bC7ezPDvZo0W7cftEw1MHIRHFwTrp8jFVGlJDSp72 3Obht/dcEcVgpupSzqHute1y4wmyP59B3DHbqjktfFqlI+fYOGVMDJvoGwlVIXgM WuEecpLU4mV0vlk5TcjFJJEOzEMK08LuvAXGMJYCUwgX6bKFQ7H4UpdY8ZMGp+U/ QLKGi9LycDjk7L31Cbz6Cisv6frPvqex2Hk+BZluBk9lKUKiL+81JedgHEZNcgVS fYdan5PPbfo= =sZ19 -----END PGP SIGNATURE----- --=-=-=--