unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#44127] [PATCH] Bombadillo build fix
@ 2020-10-21 21:29 raingloom
  2020-10-23 16:27 ` bug#44127: " Christopher Baines
  0 siblings, 1 reply; 2+ messages in thread
From: raingloom @ 2020-10-21 21:29 UTC (permalink / raw)
  To: 44127

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

Just a quick fix. install-licenses was trying to overwrite a file
installed by a previous (custom) phase, but copy-file failed with a
permission error.

[-- Attachment #2: 0001-gnu-Don-t-try-to-copy-LICENSE-twice-in-Bombadillo.patch --]
[-- Type: text/x-patch, Size: 1110 bytes --]

From 8260d3981f83b1446465ede31c8230d149422f6c Mon Sep 17 00:00:00 2001
From: raingloom <raingloom@riseup.net>
Date: Wed, 21 Oct 2020 23:22:26 +0200
Subject: [PATCH] gnu: Don't try to copy LICENSE twice in Bombadillo.

* gnu/packages/web-browsers.scm (bombadillo)[arguments]:
  Removed copy-file call for LICENSE.
---
 gnu/packages/web-browsers.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 862927242e..2220737daa 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -622,7 +622,6 @@ key-bindings and is fully configurable and extensible in Common Lisp.")
                              (pixdir (string-append sharedir "/pixmaps")))
                         (with-directory-excursion builddir
                           (install-file "bombadillo.desktop" appdir)
-                          (install-file "LICENSE" docdir)
                           (install-file "bombadillo.1" mandir)
                           (install-file "bombadillo-icon.png" pixdir)
                           #t)))))))
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#44127: [PATCH] Bombadillo build fix
  2020-10-21 21:29 [bug#44127] [PATCH] Bombadillo build fix raingloom
@ 2020-10-23 16:27 ` Christopher Baines
  0 siblings, 0 replies; 2+ messages in thread
From: Christopher Baines @ 2020-10-23 16:27 UTC (permalink / raw)
  To: raingloom; +Cc: 44127-done

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]


raingloom <raingloom@riseup.net> writes:

> Just a quick fix. install-licenses was trying to overwrite a file
> installed by a previous (custom) phase, but copy-file failed with a
> permission error.

I tweaked the commit message a bit, but I've pushed this now as
2371abcd0ece81d6b7ca3d03aff17c81bf8a5d85. Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-23 16:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-21 21:29 [bug#44127] [PATCH] Bombadillo build fix raingloom
2020-10-23 16:27 ` bug#44127: " Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).