unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 44922-done@debbugs.gnu.org
Subject: bug#44922: [PATCH 0/6] Prometheus node exporter service enhancements
Date: Mon, 07 Dec 2020 09:22:08 +0000	[thread overview]
Message-ID: <87a6uqq8cf.fsf@cbaines.net> (raw)
In-Reply-To: <87mtyq370h.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>>   services: monitoring: Neaten up the Prometheus node exporter.
>>   monitoring: Add user and group for the Prometheus node exporter.
>>   services: monitoring: Use a log file for Prometheus node exporter.
>>   doc: Remove redundant node exporter configuration from the example.
>>   monitoring: Enable the Prometheus node exporter textfile collector.
>>   monitoring: Support extra options for the Prometheus node exporter.
>     ^
> Should be “services: prometheus-node-exporter: …”.
>
> Apart from that, on a quick look it LGTM.  Go for it!

Great, I've pushed as 92f7c11af26580a7e6543efa94531652f187923a.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2020-12-07  9:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-28 12:04 [bug#44922] [PATCH 0/6] Prometheus node exporter service enhancements Christopher Baines
2020-11-28 12:11 ` [bug#44922] [PATCH 1/6] services: monitoring: Neaten up the Prometheus node exporter Christopher Baines
2020-11-28 12:11   ` [bug#44922] [PATCH 2/6] monitoring: Add user and group for " Christopher Baines
2020-11-28 12:11   ` [bug#44922] [PATCH 3/6] services: monitoring: Use a log file for " Christopher Baines
2020-11-28 12:11   ` [bug#44922] [PATCH 4/6] doc: Remove redundant node exporter configuration from the example Christopher Baines
2020-11-28 12:11   ` [bug#44922] [PATCH 5/6] monitoring: Enable the Prometheus node exporter textfile collector Christopher Baines
2020-11-28 12:11   ` [bug#44922] [PATCH 6/6] monitoring: Support extra options for the Prometheus node exporter Christopher Baines
2020-12-06 22:27 ` [bug#44922] [PATCH 0/6] Prometheus node exporter service enhancements Ludovic Courtès
2020-12-07  9:22   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6uqq8cf.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=44922-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).