From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EEF2OH70zV+CLwAA0tVLHw (envelope-from ) for ; Mon, 07 Dec 2020 09:23:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OHJiNH70zV9wKQAA1q6Kng (envelope-from ) for ; Mon, 07 Dec 2020 09:23:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE95B940111 for ; Mon, 7 Dec 2020 09:23:10 +0000 (UTC) Received: from localhost ([::1]:34508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmCjd-0000Pc-MK for larch@yhetil.org; Mon, 07 Dec 2020 04:23:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmCjW-0000OQ-Q8 for guix-patches@gnu.org; Mon, 07 Dec 2020 04:23:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmCjW-0007ae-J3 for guix-patches@gnu.org; Mon, 07 Dec 2020 04:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmCjW-0004a7-F9 for guix-patches@gnu.org; Mon, 07 Dec 2020 04:23:02 -0500 Subject: bug#44922: [PATCH 0/6] Prometheus node exporter service enhancements Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 07 Dec 2020 09:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 44922 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 44922-done@debbugs.gnu.org Mail-Followup-To: 44922@debbugs.gnu.org, mail@cbaines.net, mail@cbaines.net Received: via spool by 44922-done@debbugs.gnu.org id=D44922.160733293517532 (code D ref 44922); Mon, 07 Dec 2020 09:23:02 +0000 Received: (at 44922-done) by debbugs.gnu.org; 7 Dec 2020 09:22:15 +0000 Received: from localhost ([127.0.0.1]:52394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmCil-0004Yh-CW for submit@debbugs.gnu.org; Mon, 07 Dec 2020 04:22:15 -0500 Received: from mira.cbaines.net ([212.71.252.8]:51830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmCik-0004Ya-Gh for 44922-done@debbugs.gnu.org; Mon, 07 Dec 2020 04:22:15 -0500 Received: from localhost (188.28.112.220.threembb.co.uk [188.28.112.220]) by mira.cbaines.net (Postfix) with ESMTPSA id CD4BA27BC00; Mon, 7 Dec 2020 09:22:13 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 4ef36497; Mon, 7 Dec 2020 09:22:11 +0000 (UTC) References: <87zh31u1q0.fsf@cbaines.net> <87mtyq370h.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <87mtyq370h.fsf@gnu.org> Date: Mon, 07 Dec 2020 09:22:08 +0000 Message-ID: <87a6uqq8cf.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.40 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: AE95B940111 X-Spam-Score: -4.40 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: dnVdZuB2sbdK --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi, > > Christopher Baines skribis: > >> services: monitoring: Neaten up the Prometheus node exporter. >> monitoring: Add user and group for the Prometheus node exporter. >> services: monitoring: Use a log file for Prometheus node exporter. >> doc: Remove redundant node exporter configuration from the example. >> monitoring: Enable the Prometheus node exporter textfile collector. >> monitoring: Support extra options for the Prometheus node exporter. > ^ > Should be =E2=80=9Cservices: prometheus-node-exporter: =E2=80=A6=E2=80=9D. > > Apart from that, on a quick look it LGTM. Go for it! Great, I've pushed as 92f7c11af26580a7e6543efa94531652f187923a. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/N9EBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdqGg/+I1wWWIcPeQHIqbRyn5CiPwsi3RME5YEf 6UTgi7yjiKp1cWYjevwh2LYuwo65Qp31CMcrG8yXosGpaMfrvivCM7YXBDgXX6J0 r+T8FpqMWUhXhRTcfyn3dcgQWkdj6hX9Kh7Dc33/DcNdVfX2JSMGdedT+2nvRbqw LsHIKwdz7DqgdWKnILDvqVG/EgqOkQE6P4Xe6nF/n7hSuN9UO4onHLB+Nf/vy9kq K7tBfjdmsKsQ2EzBc3JDw4q5I3d95CuPDIiqqBYrHYoKqD+XZDAI42qJ4dj9bBAq kcaoXS6b+ScxlMVRiVnMqzQuQZ/I1h8eTGPWTJYRsN41+SKhVNIzvbgiVxStsXTE sVsiWiVdvp4C3CD8WflyGCiuorLmpgf0KD6lUVg00bp/TrCZlO/E3N7maXkYLH3O zuypRTujjxYSYi19b0igFRuEpn2VZxmT6ovmHf0URvKZrN4bAurwpzpYQLNOoNm2 2cqauI+c2+5mxvD/NAM+qGpwnxGCOlaHiV4yHvbJmXWStmAAGBMnFcg7grGljL4Q hOtrdhWeq+KlhJAOHPy0aCLK8PZD2WjZg3Y4+Rm2i1x7e5I9Peh2wbzSLUSg9/1Q Oot0bJL0PNxnXs5KKOAObHW6HE8UUi2obFawQ62GxkEI1BthKsHqgcaLNbOp2+2J wkFsahNkhQQ= =Gn5L -----END PGP SIGNATURE----- --=-=-=--