From: Mathieu Othacehe <othacehe@gnu.org>
To: Formbi <formbi@protonmail.com>
Cc: 57218@debbugs.gnu.org
Subject: [bug#57218] [PATCH] gnu: Add pipewire.scm and easyeffects
Date: Wed, 17 Aug 2022 14:48:15 +0200 [thread overview]
Message-ID: <87a683vxww.fsf_-_@gnu.org> (raw)
In-Reply-To: <ZndYIWY0x1qLz7Qd0aTrTQtrhSESE5fY5Wsyz-IsJ7h9yyI1Z9u7FCNkTHmMpW_OOoGZFXOJA3go21UlvRfHxO2VXYECZER_hdfcPXRxxLo=@protonmail.com> (formbi@protonmail.com's message of "Mon, 15 Aug 2022 11:25:38 +0000")
Hello,
Thanks for the v2, a few more remarks below.
> + (let ((toolchain (specification->package "gcc-toolchain@11")))
> + ;; for std::source_location
> + (package-with-c-toolchain
Is it normal that "guix build easyeffects" doesn't seem to locate the
package? A consequence of package-with-c-toolchain?
> + #:phases #~(modify-phases %standard-phases
> + (add-after 'unpack 'skip-gtk-update-icon-cache
> + (lambda _
> + (substitute* "meson_post_install.py"
> + (("gtk4-update-icon-cache")
> + (which "true"))))))))
You need to wrap it to stay under the 78 columns limit.
> + xiph-rnnoise
This variable is undefined.
The indentation also seem off:
--8<---------------cut here---------------start------------->8---
/home/mathieu/guix/gnu/packages/pipewire.scm:55:0: easyeffects@6.2.8: tabulation on line 55, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:56:0: easyeffects@6.2.8: tabulation on line 56, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:57:0: easyeffects@6.2.8: tabulation on line 57, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:58:0: easyeffects@6.2.8: tabulation on line 58, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:66:0: easyeffects@6.2.8: tabulation on line 66, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:67:0: easyeffects@6.2.8: tabulation on line 67, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:68:0: easyeffects@6.2.8: tabulation on line 68, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:69:0: easyeffects@6.2.8: tabulation on line 69, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:70:0: easyeffects@6.2.8: tabulation on line 70, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:93:0: easyeffects@6.2.8: tabulation on line 93, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:94:0: easyeffects@6.2.8: tabulation on line 94, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:95:0: easyeffects@6.2.8: tabulation on line 95, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:96:0: easyeffects@6.2.8: tabulation on line 96, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:97:0: easyeffects@6.2.8: tabulation on line 97, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:98:0: easyeffects@6.2.8: tabulation on line 98, column 0
/home/mathieu/guix/gnu/packages/pipewire.scm:99:0: easyeffects@6.2.8: tabulation on line 99, column 0
--8<---------------cut here---------------end--------------->8---
Mathieu
next prev parent reply other threads:[~2022-08-17 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-14 23:55 [bug#57218] [PATCH] gnu: Add pipewire.scm and easyeffects Formbi via Guix-patches via
2022-08-15 8:37 ` Mathieu Othacehe
2022-08-15 11:25 ` Formbi via Guix-patches via
2022-08-17 12:48 ` Mathieu Othacehe [this message]
2022-08-18 1:38 ` Tobias Geerinckx-Rice via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a683vxww.fsf_-_@gnu.org \
--to=othacehe@gnu.org \
--cc=57218@debbugs.gnu.org \
--cc=formbi@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).