From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IM7SEejj/GI0VgEAbAwnHQ (envelope-from ) for ; Wed, 17 Aug 2022 14:49:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aFbkEejj/GJpngAA9RJhRA (envelope-from ) for ; Wed, 17 Aug 2022 14:49:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E594A2353A for ; Wed, 17 Aug 2022 14:49:43 +0200 (CEST) Received: from localhost ([::1]:33734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOIUQ-00008M-T0 for larch@yhetil.org; Wed, 17 Aug 2022 08:49:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOITm-00007Q-TE for guix-patches@gnu.org; Wed, 17 Aug 2022 08:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOITm-0000JZ-J8 for guix-patches@gnu.org; Wed, 17 Aug 2022 08:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOITm-0000mu-FX for guix-patches@gnu.org; Wed, 17 Aug 2022 08:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57218] [PATCH] gnu: Add pipewire.scm and easyeffects Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Aug 2022 12:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57218 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Formbi Cc: 57218@debbugs.gnu.org Received: via spool by 57218-submit@debbugs.gnu.org id=B57218.16607405062986 (code B ref 57218); Wed, 17 Aug 2022 12:49:02 +0000 Received: (at 57218) by debbugs.gnu.org; 17 Aug 2022 12:48:26 +0000 Received: from localhost ([127.0.0.1]:49753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOITB-0000m4-K3 for submit@debbugs.gnu.org; Wed, 17 Aug 2022 08:48:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOIT9-0000lp-RH for 57218@debbugs.gnu.org; Wed, 17 Aug 2022 08:48:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47086) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOIT4-0000FW-Jt; Wed, 17 Aug 2022 08:48:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=pIvoLUNvCaF0Bh1tV81w8jbuCpbrBSRp2fUWV1enQCc=; b=ICKkcI5eVFk6j4/h1PmA kPsnJMmyJxWjsL8TiNbA9GNd8CNu5eyy8L7pzS5ZD/za60RD7QnOslHVUxLB53+R6360cpWyY0ffG JIjvCR7OjJDE1YHK7pXdEVy4/bTyg6fAUs8Azd1t5M1bbmxzeukurAJKPPeRIZTrS6xIpTNfj+UhE 2ZSDRF4JyXmDw/6XxjLgTw1XP/5x5AVLqkimi0aPouz6xE1F8JAXk3BnBAZjAZyHk5OGkH1kmMWIj GQRdqvulW4uVbwPsy/xtoOghfuBDdP7ubwUJ7OHqFDWeJ34jl6iVcMEkvxgkbaeNoBZUpGf+KnZjJ Sf1+pLgWzyxZKQ==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:56972 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOIT4-0002Ce-5K; Wed, 17 Aug 2022 08:48:18 -0400 From: Mathieu Othacehe References: <87pmh1gawh.fsf@gnu.org> Date: Wed, 17 Aug 2022 14:48:15 +0200 In-Reply-To: (formbi@protonmail.com's message of "Mon, 15 Aug 2022 11:25:38 +0000") Message-ID: <87a683vxww.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660740584; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pIvoLUNvCaF0Bh1tV81w8jbuCpbrBSRp2fUWV1enQCc=; b=heADq6orZRS7X8frZw2sR9TDDrOrbFA5ULDV5vg4yPAjDUIw7Q3g/cvjauGyGFJr8MyS2h KDeYmFQcLOWZbpb5MJdX6L/ASAit81/BnPpC2SsNDM1v+SLMfIGyjLaeLwPluOHoU5/jWS cx98fNFcnHKjhS7PBO4UKszZOEcceqAaqge44p0cl5/C0bPBFXi8xA1TJajh1JR1mu6EE1 RYuzZbkizRNtytZ1Khx7Fj8k6tGrz090QsOR2MMFeYLrDKgTEZhlSK+KRDfVYHjB2lc0mM QGJeJK4bAlTHoZKOyn/VtcrX6LtYxK8eYU9dbkEuiAyTistX6pBbKxfff9bVLA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660740584; a=rsa-sha256; cv=none; b=NzQLAxwM/wx0DEn6h584IPvftKjAhuaRUQ6VzS2QapCcwTOfKcCXM56N2hlc9mWTgkCP/D qwNglLsrGkdqMRLP+wr3JwbFaq6MJQIabtEWfxfHmDer02iVH8jXCh3EysOrFBBwqxlH+0 erSsiiiutYhMx1ID2OVbCKVZpCAQU7DSaDN2YvhLooIz7xiZAD4Zj9ESe8rSk7lhWPhCUq KSSKswEDHc+wQrTWwOX5tI7Rv1WqpllSkucKC3OaDs08hoQRClaLYRs/38n9uWu9EbxUJw crXq1tPwGvF76xJYyqWeKTHDVZoKr6ALhVM/37XJb9a7bZSMrPKtMkb9i/ypoQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ICKkcI5e; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ICKkcI5e; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E594A2353A X-Spam-Score: -2.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: GTPsbS04kqL0 Hello, Thanks for the v2, a few more remarks below. > + (let ((toolchain (specification->package "gcc-toolchain@11"))) > + ;; for std::source_location > + (package-with-c-toolchain Is it normal that "guix build easyeffects" doesn't seem to locate the package? A consequence of package-with-c-toolchain? > + #:phases #~(modify-phases %standard-phases > + (add-after 'unpack 'skip-gtk-update-icon-cache > + (lambda _ > + (substitute* "meson_post_install.py" > + (("gtk4-update-icon-cache") > + (which "true")))))))) You need to wrap it to stay under the 78 columns limit. > + xiph-rnnoise This variable is undefined. The indentation also seem off: --8<---------------cut here---------------start------------->8--- /home/mathieu/guix/gnu/packages/pipewire.scm:55:0: easyeffects@6.2.8: tabulation on line 55, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:56:0: easyeffects@6.2.8: tabulation on line 56, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:57:0: easyeffects@6.2.8: tabulation on line 57, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:58:0: easyeffects@6.2.8: tabulation on line 58, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:66:0: easyeffects@6.2.8: tabulation on line 66, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:67:0: easyeffects@6.2.8: tabulation on line 67, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:68:0: easyeffects@6.2.8: tabulation on line 68, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:69:0: easyeffects@6.2.8: tabulation on line 69, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:70:0: easyeffects@6.2.8: tabulation on line 70, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:93:0: easyeffects@6.2.8: tabulation on line 93, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:94:0: easyeffects@6.2.8: tabulation on line 94, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:95:0: easyeffects@6.2.8: tabulation on line 95, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:96:0: easyeffects@6.2.8: tabulation on line 96, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:97:0: easyeffects@6.2.8: tabulation on line 97, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:98:0: easyeffects@6.2.8: tabulation on line 98, column 0 /home/mathieu/guix/gnu/packages/pipewire.scm:99:0: easyeffects@6.2.8: tabulation on line 99, column 0 --8<---------------cut here---------------end--------------->8--- Mathieu