unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Sergey Trofimov <sarg@sarg.org.ru>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 62223@debbugs.gnu.org
Subject: [bug#62223] [PATCH] image: Prefer gpt partition table for efi disk images
Date: Wed, 22 Mar 2023 13:48:47 +0100	[thread overview]
Message-ID: <87a605c5lj.fsf@sarg.org.ru> (raw)
In-Reply-To: <87mt45rdcy.fsf@jpoiret.xyz>


Josselin Poiret <dev@jpoiret.xyz> writes:

> [[PGP Signed Part:Undecided]]
> Hi Sergey,
>
> Thanks for the patch!  First off, if you want to add a comment 
> to your
> mail but not to the commit message, you should add it below the 
> first --
> (under the commit message), before the diff, that way it doesn't 
> end up
> in the commit message.
>

Thanks, noted.

>
> With this applied, I cannot build an example qcow2 image using 
> `guix
> system image -t qcow2 gnu/system/examples/bare-bones.tmpl`.  It 
> fails
> when installing GRUB onto the image.  Sure enough, the
> install-grub-disk-image procedure seems to only support MBR. 
> Could you
> also have a look at this?

Yeah, I'm glad you've caught that. qcow2 should be mbr style by 
default. I'll send a v2 for that.




  reply	other threads:[~2023-03-22 12:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 17:31 [bug#62223] [PATCH] image: Prefer gpt partition table for efi disk images Sergey Trofimov
2023-03-21 21:41 ` Josselin Poiret via Guix-patches via
2023-03-22 12:48   ` Sergey Trofimov [this message]
2023-03-22  8:14 ` [bug#62223] Tested locally Sergey Trofimov
2023-03-22 12:53 ` [bug#62223] [PATCH v2] image: Prefer gpt partition table for efi images Sergey Trofimov
2023-07-07 19:50   ` bug#62223: " Josselin Poiret via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a605c5lj.fsf@sarg.org.ru \
    --to=sarg@sarg.org.ru \
    --cc=62223@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).