From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OAzHJsv5GmQXTQAASxT56A (envelope-from ) for ; Wed, 22 Mar 2023 13:51:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id EPavJsv5GmSyXQEAauVa8A (envelope-from ) for ; Wed, 22 Mar 2023 13:51:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 64E9B174EE for ; Wed, 22 Mar 2023 13:51:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pexvk-0005AC-Md; Wed, 22 Mar 2023 08:51:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pexvi-00059a-Bu for guix-patches@gnu.org; Wed, 22 Mar 2023 08:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pexvi-0004L3-3Q for guix-patches@gnu.org; Wed, 22 Mar 2023 08:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pexvh-0002tY-SQ for guix-patches@gnu.org; Wed, 22 Mar 2023 08:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62223] [PATCH] image: Prefer gpt partition table for efi disk images Resent-From: Sergey Trofimov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Mar 2023 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62223 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 62223@debbugs.gnu.org Received: via spool by 62223-submit@debbugs.gnu.org id=B62223.167948943511095 (code B ref 62223); Wed, 22 Mar 2023 12:51:01 +0000 Received: (at 62223) by debbugs.gnu.org; 22 Mar 2023 12:50:35 +0000 Received: from localhost ([127.0.0.1]:33785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pexvG-0002st-W5 for submit@debbugs.gnu.org; Wed, 22 Mar 2023 08:50:35 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:35530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pexvE-0002sd-76 for 62223@debbugs.gnu.org; Wed, 22 Mar 2023 08:50:34 -0400 Received: by mail-ed1-f41.google.com with SMTP id y4so72548301edo.2 for <62223@debbugs.gnu.org>; Wed, 22 Mar 2023 05:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sarg.org.ru; s=google; t=1679489426; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=hhfIagDIu/xq+i5BSznteeXTywGyBs8qrvaDcBjRfzo=; b=h4tk8gbNRMFNNZAN1MMPZtDwoMwrLwKJwbZEQjq4eOoR+bOxFQzCmIOUSewImD3BP0 xz/OtI33b4BqIaiECNSOteiSNXSIiUa2UTfxJhZ4P/6kgGodEabnEO8A8UrIn+BKMl8O 66esRJsae0AIWdFRkTs0lgJt4SBhj4pTE5nMg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679489426; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hhfIagDIu/xq+i5BSznteeXTywGyBs8qrvaDcBjRfzo=; b=QVGGK+UB21ta/saNxkJfbh8siXQD4uVRquINOfBQzoaeHe9KwGV/JbxWYyCFZl53sq ogwPF7pXVZ4EEYQbJXUUZhCMLfOAZcegNVKzgc5oThEnyQ7Ymj9ixoqscgouHD2bQ5WD dqiR7c8Jyf9l93sfM0u4+j7O8npI+5psT4RHh7WpuiY/V3b3XcerDmwViJ/iG5YowjSK uFVIW6XHeeweqJFug1kRgKF23ezyv2B0naUIRZkgT8S5mydfSqBEs8KVYZ62q7O31LYL DqrM/3p74sraazOX6NzJewXILNvZrfzNoIBuES6JPeBGexFfVriYqWhfZUEDKellgC7z SYsw== X-Gm-Message-State: AO0yUKV9u7Wpr6QnT3utEJmMLb/yq+X3L91xH3mqSwb9mfZMDIDFr41o Os6jJXuFlqLAyaVgH5vJ5L4EcA== X-Google-Smtp-Source: AK7set/H+bGeTxyMfRQtcruvRArIBitnfXqY4czlvhO9jcxDYCiG6VpJKLbbljVyYxBbh7IS3Re71g== X-Received: by 2002:a05:6402:8d9:b0:4f9:deb4:b986 with SMTP id d25-20020a05640208d900b004f9deb4b986mr6060759edz.7.1679489426131; Wed, 22 Mar 2023 05:50:26 -0700 (PDT) Received: from localhost ([95.168.147.255]) by smtp.gmail.com with ESMTPSA id s29-20020a50d49d000000b004fc2a75c6b3sm7638712edi.23.2023.03.22.05.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 05:50:25 -0700 (PDT) References: <20230316173137.25074-1-sarg@sarg.org.ru> <87mt45rdcy.fsf@jpoiret.xyz> User-agent: mu4e 1.8.13; emacs 29.0.60 From: Sergey Trofimov Date: Wed, 22 Mar 2023 13:48:47 +0100 In-reply-to: <87mt45rdcy.fsf@jpoiret.xyz> Message-ID: <87a605c5lj.fsf@sarg.org.ru> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679489483; a=rsa-sha256; cv=none; b=QvhHd5UUpEyE4eYgVzsIl2hfpLhj/ULqB1nx+jaqwe3EkZtfAsFiilPB7RFtddRH7l5sPP BzayGc81BwWNhxKVkdpEjN+CYyYiY1Sca/IwkZXhN/dnsMPnec9SI2USyl0uFOST8B9baS QWrLRgvnz2GzZilcg+xoL2k9ZJoEqIU2fW75Nxx0lWSeJnstg1KQibgRgRBPO2akEsGqQ+ z409j3peQpUMlk1H1fbP6S998+wTjG+pjm0j1olPBoDfpaf0QAtioM0InegyZe8sHN8mT9 wmokl8W1zhbZhcMfpaVhm4x4ETNF8keAn5TRlZRPRuZsqzwNNEDjluz3dKZA9w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=sarg.org.ru header.s=google header.b=h4tk8gbN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679489483; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=hhfIagDIu/xq+i5BSznteeXTywGyBs8qrvaDcBjRfzo=; b=IEZRFTTXBjMFho+0xyhKhthBlfYQYg0MaplQb9i5PrDQngv9c1Uy/6DyX7brmXxWq+EDTy FDgJve6JV1g22vbeHyGelxYMZ4pWY6QifHX+ynbGKR0EDH1UxVi+KG2hqJ5zoIv4PkShT/ ZAe73nPFhcJhPF5Ubn5E0mWpzzxTK9Z4/+YhaIJebrFnykdowzdGTcD866RS3pWDYoxJ6m DHpAzqa/Q8N73RkETrNztea7s83cw6KYZNlD4UT65P25xbNDD/cLMuyr3wU4/Khf9ofz9P BLrXQ5mI3ACJmQOgXxclVRVhCKux9ajhsnon7ouDis1KcWFfYqPgM3z28JeLlQ== X-Migadu-Spam-Score: -0.75 X-Spam-Score: -0.75 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=sarg.org.ru header.s=google header.b=h4tk8gbN; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Queue-Id: 64E9B174EE X-Migadu-Scanner: scn1.migadu.com X-TUID: NuQ97tVpg/zO Josselin Poiret writes: > [[PGP Signed Part:Undecided]] > Hi Sergey, > > Thanks for the patch! First off, if you want to add a comment > to your > mail but not to the commit message, you should add it below the > first -- > (under the commit message), before the diff, that way it doesn't > end up > in the commit message. > Thanks, noted. > > With this applied, I cannot build an example qcow2 image using > `guix > system image -t qcow2 gnu/system/examples/bare-bones.tmpl`. It > fails > when installing GRUB onto the image. Sure enough, the > install-grub-disk-image procedure seems to only support MBR. > Could you > also have a look at this? Yeah, I'm glad you've caught that. qcow2 should be mbr style by default. I'll send a v2 for that.