From: ludo@gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien@lepiller.eu>
Cc: 26487@debbugs.gnu.org
Subject: bug#26487: Add antlr3
Date: Mon, 08 May 2017 22:16:58 +0200 [thread overview]
Message-ID: <878tm7je85.fsf@gnu.org> (raw)
In-Reply-To: <20170417150349.7040ec6c@lepiller.eu> (Julien Lepiller's message of "Mon, 17 Apr 2017 15:03:53 +0200")
Hello!
Julien Lepiller <julien@lepiller.eu> skribis:
> Hi, I fixed the reproducibility issue by copying part of the
> ant-build-system in antlr2's recipe.
>
> From bc2eaf6e11cea60169f16c35ca052a67f83990af Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Thu, 13 Apr 2017 20:18:15 +0200
> Subject: [PATCH 1/4] guix: ant-build-system: Add src-dir parameter.
>
> * guix/build-system/ant.scm (ant-build): Add src-dir parameter.
> * guix/build/ant-build-system.scm (configure): Add src-dir parameter.
> (default-build.xml): Use it.
> * doc/guix.texi: Document it.
[...]
> --- a/guix/build-system/ant.scm
> +++ b/guix/build-system/ant.scm
> @@ -98,6 +98,7 @@
> (make-flags ''())
> (build-target "jar")
> (jar-name #f)
> + (src-dir "src")
The general guideline (info "(guix) Formatting Code") is to use full
words as identifiers. Could you change ‘src-dir’ to ‘source-directory’?
(In the code and .texi.)
Kei already OKayed the remaining patches and they look good to me too.
Thanks!
Ludo’.
next prev parent reply other threads:[~2017-05-08 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 20:46 bug#26487: Add antlr3 Julien Lepiller
2017-04-15 19:59 ` Kei Kebreau
2017-04-17 13:03 ` Julien Lepiller
2017-05-08 20:16 ` Ludovic Courtès [this message]
2017-05-15 21:21 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tm7je85.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26487@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).