From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38157)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7p6c-0000jo-Bt
	for guix-patches@gnu.org; Mon, 08 May 2017 16:18:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7p6Z-0003cu-7T
	for guix-patches@gnu.org; Mon, 08 May 2017 16:18:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:57591)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d7p6Z-0003cq-4L
	for guix-patches@gnu.org; Mon, 08 May 2017 16:18:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7p6Y-0005qw-W4
	for guix-patches@gnu.org; Mon, 08 May 2017 16:18:03 -0400
Subject: bug#26487: Add antlr3
Resent-Message-ID: <handler.26487.B26487.149427463222397@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170413224513.342184b2@lepiller.eu>
	<87h91pmoh6.fsf@openmailbox.org> <20170417150349.7040ec6c@lepiller.eu>
Date: Mon, 08 May 2017 22:16:58 +0200
In-Reply-To: <20170417150349.7040ec6c@lepiller.eu> (Julien Lepiller's message
	of "Mon, 17 Apr 2017 15:03:53 +0200")
Message-ID: <878tm7je85.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 26487@debbugs.gnu.org

Hello!

Julien Lepiller <julien@lepiller.eu> skribis:

> Hi, I fixed the reproducibility issue by copying part of the
> ant-build-system in antlr2's recipe.
>
> From bc2eaf6e11cea60169f16c35ca052a67f83990af Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Thu, 13 Apr 2017 20:18:15 +0200
> Subject: [PATCH 1/4] guix: ant-build-system: Add src-dir parameter.
>
> * guix/build-system/ant.scm (ant-build): Add src-dir parameter.
> * guix/build/ant-build-system.scm (configure): Add src-dir parameter.
> (default-build.xml): Use it.
> * doc/guix.texi: Document it.

[...]

> --- a/guix/build-system/ant.scm
> +++ b/guix/build-system/ant.scm
> @@ -98,6 +98,7 @@
>                      (make-flags ''())
>                      (build-target "jar")
>                      (jar-name #f)
> +                    (src-dir "src")

The general guideline (info "(guix) Formatting Code") is to use full
words as identifiers.  Could you change =E2=80=98src-dir=E2=80=99 to =E2=80=
=98source-directory=E2=80=99?
(In the code and .texi.)

Kei already OKayed the remaining patches and they look good to me too.

Thanks!

Ludo=E2=80=99.