From: Ricardo Wurmus <rekado@elephly.net>
To: pkill9@runbox.com
Cc: 34572@debbugs.gnu.org
Subject: [bug#34572] Add Drawpile
Date: Wed, 20 Feb 2019 22:01:30 +0100 [thread overview]
Message-ID: <878sya5g45.fsf@elephly.net> (raw)
In-Reply-To: <E1gw43s-0007Fe-8u@rmmprod05.runbox>
Hi pkill9,
> * gnu/packages/graphics.scm (drawpile): New variable.
Thank you for your patch.
[…]
> +(define-public drawpile
> + (package
> + (name "drawpile")
> + (version "2.0.11")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://drawpile.net/files/src/drawpile-" version ".tar.gz"))
Please break this line.
> + (sha256
> + (base32
> + "0h018rxhc0lwpqwmlihalz634nd0xaafk4p2b782djjd87irnjpk"))))
> + (build-system cmake-build-system)
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("qttools" ,qttools)))
> + (inputs
> + `(("qtbase" ,qtbase)
> + ("qtsvg" ,qtsvg)
> + ("qtmultimedia" ,qtmultimedia)
> + ("qtcolorwidgets" ,qtcolorwidgets)
> + ("karchive" ,karchive)
> + ("giflib" ,giflib) ; optional
> + ("kdnssd" ,kdnssd) ; optional
> + ("miniupnpc" ,(@ (gnu packages upnp) miniupnpc)) ; optional
> + ("libmicrohttpd" ,(@ (gnu packages gnunet) libmicrohttpd)) ; optional
> + ("libsodium" ,(@ (gnu packages crypto) libsodium)))) ; optional
Please don’t use these inline module references.
> + (arguments
> + `(#:configure-flags (list "-DTESTS=on" "-DCMAKE_BUILD_TYPE=Release" "-DTOOLS=on"
> + (string-append "-DLIBQTCOLORWIDGETS_LIBRARY="
> + (assoc-ref %build-inputs "qtcolorwidgets")
> + "/lib/libQtColorWidgets-Qt52.so"))))
Please put “(list” on a new line and then break after every item, so
that you can add comments as to why these flags are required.
I don’t think you need "-DCMAKE_BUILD_TYPE=Release" as we’re building
with “RelWithDebInfo” by default.
> + (home-page "https://drawpile.net")
> + (synopsis "Collaborative drawing")
“Collaborative drawing program” would be better.
> + (license license:gpl3)))
This looks like gpl3+. See for example:
https://github.com/drawpile/Drawpile/blob/master/src/server/initsys_systemd.cpp#L9
Please check the licenses more carefully.
Could you please send an updated patch?
--
Ricardo
next prev parent reply other threads:[~2019-02-20 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 11:59 [bug#34572] Add Drawpile pkill9
2019-02-20 21:01 ` Ricardo Wurmus [this message]
2019-02-21 12:51 ` pkill9
2019-02-21 13:58 ` Tobias Geerinckx-Rice
2019-02-22 7:28 ` pkill9
2021-08-06 4:20 ` bug#34572: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sya5g45.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=34572@debbugs.gnu.org \
--cc=pkill9@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).