From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:53543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwZiv-0006C1-3Z
	for guix-patches@gnu.org; Wed, 20 Feb 2019 16:48:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwZim-0007bl-SI
	for guix-patches@gnu.org; Wed, 20 Feb 2019 16:48:07 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57928)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gwZij-0007XO-V6
	for guix-patches@gnu.org; Wed, 20 Feb 2019 16:48:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwZij-0007jE-PF
	for guix-patches@gnu.org; Wed, 20 Feb 2019 16:48:01 -0500
Subject: [bug#34572] Add Drawpile
Resent-Message-ID: <handler.34572.B34572.155069926429682@debbugs.gnu.org>
References: <E1gw43s-0007Fe-8u@rmmprod05.runbox>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <E1gw43s-0007Fe-8u@rmmprod05.runbox>
Date: Wed, 20 Feb 2019 22:01:30 +0100
Message-ID: <878sya5g45.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: pkill9@runbox.com
Cc: 34572@debbugs.gnu.org


Hi pkill9,

> * gnu/packages/graphics.scm (drawpile): New variable.

Thank you for your patch.

[=E2=80=A6]
> +(define-public drawpile
> +  (package
> +    (name "drawpile")
> +    (version "2.0.11")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://drawpile.net/files/src/drawpile-" ve=
rsion ".tar.gz"))

Please break this line.

> +       (sha256
> +        (base32
> +         "0h018rxhc0lwpqwmlihalz634nd0xaafk4p2b782djjd87irnjpk"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("qttools" ,qttools)))
> +    (inputs
> +     `(("qtbase" ,qtbase)
> +       ("qtsvg" ,qtsvg)
> +       ("qtmultimedia" ,qtmultimedia)
> +       ("qtcolorwidgets" ,qtcolorwidgets)
> +       ("karchive" ,karchive)
> +       ("giflib" ,giflib) ; optional
> +       ("kdnssd" ,kdnssd) ; optional
> +       ("miniupnpc" ,(@ (gnu packages upnp) miniupnpc)) ; optional
> +       ("libmicrohttpd" ,(@ (gnu packages gnunet) libmicrohttpd)) ; opti=
onal
> +       ("libsodium" ,(@ (gnu packages crypto) libsodium)))) ; optional

Please don=E2=80=99t use these inline module references.

> +    (arguments
> +     `(#:configure-flags (list "-DTESTS=3Don" "-DCMAKE_BUILD_TYPE=3DRele=
ase" "-DTOOLS=3Don"
> +                               (string-append "-DLIBQTCOLORWIDGETS_LIBRA=
RY=3D"
> +                                              (assoc-ref %build-inputs "=
qtcolorwidgets")
> +                                              "/lib/libQtColorWidgets-Qt=
52.so"))))

Please put =E2=80=9C(list=E2=80=9D on a new line and then break after every=
 item, so
that you can add comments as to why these flags are required.

I don=E2=80=99t think you need "-DCMAKE_BUILD_TYPE=3DRelease" as we=E2=80=
=99re building
with =E2=80=9CRelWithDebInfo=E2=80=9D by default.

> +    (home-page "https://drawpile.net")
> +    (synopsis "Collaborative drawing")

=E2=80=9CCollaborative drawing program=E2=80=9D would be better.

> +    (license license:gpl3)))

This looks like gpl3+.  See for example:

    https://github.com/drawpile/Drawpile/blob/master/src/server/initsys_sys=
temd.cpp#L9

Please check the licenses more carefully.

Could you please send an updated patch?

--=20
Ricardo