From: "Ludovic Courtès" <ludo@gnu.org>
To: Carl Dong <contact@carldong.me>
Cc: 48850@debbugs.gnu.org
Subject: [bug#48850] [PATCH] gnu: coreutils: Disable inotify-dir-recreate test
Date: Sat, 05 Jun 2021 22:18:22 +0200 [thread overview]
Message-ID: <878s3onjzl.fsf@gnu.org> (raw)
In-Reply-To: <20210605152645.2562795-1-contact@carldong.me> (Carl Dong's message of "Sat, 5 Jun 2021 11:26:45 -0400")
Hi,
Carl Dong <contact@carldong.me> skribis:
> This test fails on filesystems where tail detects that it cannot use
> inotify safely. See #47935 for more details.
>
> * gnu/packages/base.scm (coreutils)[phases]: Disable
> inotify-dir-recreate tests.
Please write the full bug URL in the commit log and comment; it’s less
ambiguous, more future-proof, and more convenient.
> - ,@(if (hurd-target?)
> - `((add-after 'unpack 'remove-tests
> - (lambda _
> - (substitute* "Makefile.in"
> - ;; this test hangs
> - (("^ *tests/misc/timeout-group.sh.*") "")))))
> - '()))))
> + (add-after 'unpack 'remove-tests
> + (lambda _
> + (if ,(hurd-target?)
> + (substitute* "Makefile.in"
> + ;; this test hangs
> + (("^ *tests/misc/timeout-group.sh.*") "")))
I’d write it like this:
(lambda _
,@(if (hurd-target?)
'((substitute* …))
'())
…)
That way, the Hurd bit is only expanded when targeting the Hurd, and we
can also adjust it without causing rebuilds on GNU/Linux.
As far as I’m concerned, it’s OK for ‘core-updates’ with these changes!
Thanks,
Ludo’.
next prev parent reply other threads:[~2021-06-05 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 15:26 [bug#48850] [PATCH] gnu: coreutils: Disable inotify-dir-recreate test Carl Dong
2021-06-05 20:18 ` Ludovic Courtès [this message]
2021-06-07 21:50 ` [bug#48850] [PATCH v2] " Carl Dong
2021-06-08 18:38 ` [bug#48850] [PATCH v3] " Carl Dong
2021-06-11 13:56 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s3onjzl.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=48850@debbugs.gnu.org \
--cc=contact@carldong.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).