From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 5D2XID7cu2DHSgAAgWs5BA (envelope-from ) for ; Sat, 05 Jun 2021 22:19:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OP1PGz7cu2AmOQAAB5/wlQ (envelope-from ) for ; Sat, 05 Jun 2021 20:19:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F3BD930E55 for ; Sat, 5 Jun 2021 22:19:09 +0200 (CEST) Received: from localhost ([::1]:37660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpclA-0004XU-Ln for larch@yhetil.org; Sat, 05 Jun 2021 16:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpcl4-0004X8-Hm for guix-patches@gnu.org; Sat, 05 Jun 2021 16:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38551) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpcl4-0006N8-Ax for guix-patches@gnu.org; Sat, 05 Jun 2021 16:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpcl4-0007VI-45 for guix-patches@gnu.org; Sat, 05 Jun 2021 16:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48850] [PATCH] gnu: coreutils: Disable inotify-dir-recreate test Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Jun 2021 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48850 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Carl Dong Cc: 48850@debbugs.gnu.org Received: via spool by 48850-submit@debbugs.gnu.org id=B48850.162292431428806 (code B ref 48850); Sat, 05 Jun 2021 20:19:02 +0000 Received: (at 48850) by debbugs.gnu.org; 5 Jun 2021 20:18:34 +0000 Received: from localhost ([127.0.0.1]:50097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpckc-0007UY-47 for submit@debbugs.gnu.org; Sat, 05 Jun 2021 16:18:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpckY-0007UF-3b for 48850@debbugs.gnu.org; Sat, 05 Jun 2021 16:18:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57620) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpckS-0005yw-Lo; Sat, 05 Jun 2021 16:18:24 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36316 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpckS-0001tB-Cv; Sat, 05 Jun 2021 16:18:24 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210605152645.2562795-1-contact@carldong.me> Date: Sat, 05 Jun 2021 22:18:22 +0200 In-Reply-To: <20210605152645.2562795-1-contact@carldong.me> (Carl Dong's message of "Sat, 5 Jun 2021 11:26:45 -0400") Message-ID: <878s3onjzl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622924350; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=xUNj6iSziQM+RCbOCq+8X5vcsf5UFabndhqxV2nl4xY=; b=Ov7X2BzTP+xYOBQ0tUKUGdolkneX36JEqBT7HmwvWTKhJwOEeuziww/G2Jbrfl8sKHvlqI d2ef2UIp5WfXuygfsDJq8nrsqoZg1cJMNhyVFp2aPaauwS/T900lUPrOhIPpMo1Zh0O3UD LMEwOAuVHiQnPVJqPRZVBTdevj3p1yobkDYUVg0WrK8R/exAUZULXb6adS5Iq+o2g5M7xc Ro+DJYmMo7k4HFWZt0vYVp76EQBUHIfY2amHRQ9auHGnB6szZ9AlLWwBl447p8UnaYno4/ zuHyjsUvT8J+hGER5SVA/gfkBRl4ytLJD7ZWbSJkYsMRRLgObMuAu39tteV9eg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622924350; a=rsa-sha256; cv=none; b=sFwHcmkhqDOSnRyUEVqpXR5a5MzZvnH0yT10nO4DFHVP42KW4pPAPLWM3BAyh4xCcZfVt5 WMLF8jeTGNRWwuGHh/tVVamPhyPxMQDMJAa0PYNBlSXwA655/vxfh6py0PYPtEM9qW8NF0 QyYVM7PBvQCqJLfj+HGitd0mEIl/7Qp0436d9tvdYmggi/gnfhoiwMJjCu/WsyIdCMiNQ9 G2IKh4SuwVxa7YTfZrlG9/EWd9dK8PI1gKqM3z1eKm0SGuQ202odnGQeDs3Gp3vw5C8sIM bK5Rxe2Gf4cIeUQUXx6f8EUoaocm+QnXOV+DvYkxanPzXTpack6uMg62YbxTig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F3BD930E55 X-Spam-Score: -1.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: eAiBTB/HxD0Q Hi, Carl Dong skribis: > This test fails on filesystems where tail detects that it cannot use > inotify safely. See #47935 for more details. > > * gnu/packages/base.scm (coreutils)[phases]: Disable > inotify-dir-recreate tests. Please write the full bug URL in the commit log and comment; it=E2=80=99s l= ess ambiguous, more future-proof, and more convenient. > - ,@(if (hurd-target?) > - `((add-after 'unpack 'remove-tests > - (lambda _ > - (substitute* "Makefile.in" > - ;; this test hangs > - (("^ *tests/misc/timeout-group.sh.*") "")= )))) > - '())))) > + (add-after 'unpack 'remove-tests > + (lambda _ > + (if ,(hurd-target?) > + (substitute* "Makefile.in" > + ;; this test hangs > + (("^ *tests/misc/timeout-group.sh.*") ""))) I=E2=80=99d write it like this: (lambda _ ,@(if (hurd-target?) '((substitute* =E2=80=A6)) '()) =E2=80=A6) That way, the Hurd bit is only expanded when targeting the Hurd, and we can also adjust it without causing rebuilds on GNU/Linux. As far as I=E2=80=99m concerned, it=E2=80=99s OK for =E2=80=98core-updates= =E2=80=99 with these changes! Thanks, Ludo=E2=80=99.