From: "宋文武 via Guix-patches via" <guix-patches@gnu.org>
To: Z572 <873216071@qq.com>
Cc: 62432@debbugs.gnu.org
Subject: [bug#62432] [PATCH] gnu: libicns: fix riscv64 cross-build.
Date: Mon, 03 Apr 2023 19:04:18 +0800 [thread overview]
Message-ID: <878rf9b51p.fsf@envs.net> (raw)
In-Reply-To: <tencent_9E72DB12A95A97CD8254E9ACB2BF641D9907@qq.com> (873216071@qq.com's message of "Sat, 25 Mar 2023 12:50:59 +0800")
Z572 <873216071@qq.com> writes:
> * gnu/packages/image.scm (libicns): fix riscv64 cross-build.
Hello, this message is already in the commit message title, So I think
there is no need to repeat it here. Also look in the guix commit log,
I think it should be 'gnu: libicns: Fix cross-compilation for riscv64'.
> + (arguments (if (target-riscv64?)
> + (list #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'update-config-scripts
> + (lambda* (#:key native-inputs inputs #:allow-other-keys)
> + (for-each (lambda (file)
> + (install-file
> + (search-input-file
> + (or native-inputs inputs)
> + (string-append "/bin/" file)) "."))
> + '("config.guess" "config.sub"))))) )
> + '()))
> + (native-inputs
> + (if (target-riscv64?)
> + (list config)
> + '()))
This updates 'config.guess' and 'config.sub' in a package to fix
cross-compilation for riscv64 seems like a common practice (eg: also in
your patches #62433, #62544). How about make a procedure for it to
save some typing? It could be:
```
(define (autotools-config-updated-package p)
"Return package P with @command{config.guess} and
@command{config.sub} updated by the @code{config} package"
(package (inherit p)
...))
```
Which could go into (guix transformations).
next prev parent reply other threads:[~2023-04-03 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 4:50 [bug#62432] [PATCH] gnu: libicns: fix riscv64 cross-build Z572 via Guix-patches via
2023-04-03 11:04 ` 宋文武 via Guix-patches via [this message]
2023-06-04 12:29 ` bug#62432: " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rf9b51p.fsf@envs.net \
--to=guix-patches@gnu.org \
--cc=62432@debbugs.gnu.org \
--cc=873216071@qq.com \
--cc=iyzsong@envs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).