From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id ePxDEMCyKmTEcAEASxT56A (envelope-from ) for ; Mon, 03 Apr 2023 13:04:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aFB0D8CyKmQyJQAAG6o9tA (envelope-from ) for ; Mon, 03 Apr 2023 13:04:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F149036F4 for ; Mon, 3 Apr 2023 13:04:31 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjHz7-0002yU-JI; Mon, 03 Apr 2023 07:04:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjHyl-0002vM-7K for guix-patches@gnu.org; Mon, 03 Apr 2023 07:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjHyk-0003Ff-JM for guix-patches@gnu.org; Mon, 03 Apr 2023 07:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pjHyk-0002NW-0b for guix-patches@gnu.org; Mon, 03 Apr 2023 07:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62432] [PATCH] gnu: libicns: fix riscv64 cross-build. Resent-From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 03 Apr 2023 11:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62432 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Z572 <873216071@qq.com> Cc: 62432@debbugs.gnu.org Received: via spool by 62432-submit@debbugs.gnu.org id=B62432.16805198199103 (code B ref 62432); Mon, 03 Apr 2023 11:04:01 +0000 Received: (at 62432) by debbugs.gnu.org; 3 Apr 2023 11:03:39 +0000 Received: from localhost ([127.0.0.1]:43424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjHyN-0002Ml-9M for submit@debbugs.gnu.org; Mon, 03 Apr 2023 07:03:39 -0400 Received: from mail.envs.net ([5.199.136.28]:56032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjHyJ-0002MW-7v for 62432@debbugs.gnu.org; Mon, 03 Apr 2023 07:03:37 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id A47C938A008E; Mon, 3 Apr 2023 11:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1680519811; bh=0dmh28aXjfJth9MUkM4FdF1WFiOgcf3seNMxIA3YD8A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SNQ4TFLbUK3QwynpHgZE6seeoNkRvZuhKACmvSPCziYxO5YEiX+iWJ2MfnYHNnqbQ J/DA3eCvMdW7VnXr7VUGHztp/2tcnD8XC9UjZ64FeuUeBlJctxFwXp3n7FX30Pu66J 8s2fKjY7jj/PPjudg1n5d+bQTqF4/bHYooiNKubshsD24sG4EFmKS7dnDaSMQcntB1 EqrCmOiErccYHDS3VNM6cWHL5MH5prYgCk4GSgu/Q+omQ3WPqng/fqcwtOX+/uxQIN QGUL3WApLgUyrHbbK+xge9uEBLZow/8QRTEPERwgVXCczok4ifeg+rX081SqmAO+UG bo404QPHQzIddl4tHiqbG9pGmGtmETePsk8eTjwD/mFMWz4mtTdW99mMFndd/45Ghs D2bJ4kCOQucmPjuENg0hhhyA8byAG/AuUTyMY8LIUxkRjwqhDO926C3NUaivKls0Sb Wa+iaBoYAR0qbWDG2ptIw3zGJRMeVpHy2UqWrMEyHGFziSs/QUQWDEiM0wtdEkFS1N +HauQ94WFyTvac4beVJnjeOHq5ansTciMm2caOgG7Ax4F7BEcEMUxmqAWHJ7Fs2CX5 JoKyd1HeJIVYDBRBaAESp3O/XvlmsIP3TQHBJOYjyeLr9IYR6EofHVZqjmrOlCgWWF nCRTsvJxkiYbfjdmnpIo0JIU= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0q2w4tIXgI3x; Mon, 3 Apr 2023 11:03:28 +0000 (UTC) Received: from localhost (unknown [36.170.59.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Mon, 3 Apr 2023 11:03:28 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id e119a3c8; Mon, 3 Apr 2023 11:04:18 +0000 (UTC) References: Date: Mon, 03 Apr 2023 19:04:18 +0800 In-Reply-To: (873216071@qq.com's message of "Sat, 25 Mar 2023 12:50:59 +0800") Message-ID: <878rf9b51p.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-ACL-Warn: , =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= From: =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680519872; a=rsa-sha256; cv=none; b=iDPJPh2uo9YGcUR8bXyNwsBRcGVcsfKZwaugdO3mXoIiobCtCJ66PqhXZxaluFSC7kmaD1 6sF00mjdVYAEP4qbIkMTWTQBVJ2E11SEpq0on436USa8vEt1mIKwH8FOPGHrlflgLpOAEM aD+t5H+41kD0dYNJzEI0CdQ8qqiA9aJYkh0a1UuT7CH9v8aNc8QmXsoUgOTtWDVbzW6Bv3 Zdj32t2EiBVeerECCMqtvwe9OXr6j1zhA18JLAcfXdNugKsQ0IbYNZQrx4+YC5SughDAxb J9OXVynl61INGjkR3W9BwJPPe2/8WfBFCDuTjNd55lKd4JWcUfzL8ITxqXPjfg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b=SNQ4TFLb; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680519872; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=0dmh28aXjfJth9MUkM4FdF1WFiOgcf3seNMxIA3YD8A=; b=iDD4cRHLt7OsnJoPyTcuw+npyKPob02M3Q883Irss6dCqgo5P4rClhuar4C0zmums8Z15J 2y6/gGGw8ghs68NCkLarXHZv+QHClK61vk2koxLu2n0Ejh5cKVjNgf2bqX/IgI5SFps3Ba 51IfBE6y6lkJxiZCP5ET/tKABwz1yxRJV0GK39oeQ5RaMbLD4woLbTcKDPc2FWRmhThMoX QJ2JQSV/DB956FU+xU3xT4OVNFbF8F1ztgCCdKCzjKqJONgEJZ7AFTA54RAFC6uWnK2qNx 6g60syjaLTsMVaUIoKdFSvBuJgZAyEaJ2guAxfee4D/qf6/G9KJbvZPrmIZSqg== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b=SNQ4TFLb; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -4.82 X-Spam-Score: -4.82 X-Migadu-Queue-Id: F149036F4 X-TUID: LhK44Q64ehXn Z572 <873216071@qq.com> writes: > * gnu/packages/image.scm (libicns): fix riscv64 cross-build. Hello, this message is already in the commit message title, So I think there is no need to repeat it here. Also look in the guix commit log, I think it should be 'gnu: libicns: Fix cross-compilation for riscv64'. > + (arguments (if (target-riscv64?) > + (list #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'update-config-scripts > + (lambda* (#:key native-inputs inputs #:allow-other-keys) > + (for-each (lambda (file) > + (install-file > + (search-input-file > + (or native-inputs inputs) > + (string-append "/bin/" file)) ".")) > + '("config.guess" "config.sub"))))) ) > + '())) > + (native-inputs > + (if (target-riscv64?) > + (list config) > + '())) This updates 'config.guess' and 'config.sub' in a package to fix cross-compilation for riscv64 seems like a common practice (eg: also in your patches #62433, #62544). How about make a procedure for it to save some typing? It could be: ``` (define (autotools-config-updated-package p) "Return package P with @command{config.guess} and @command{config.sub} updated by the @code{config} package" (package (inherit p) ...)) ``` Which could go into (guix transformations).