unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#66038] [PATCH] gnu: muchsync: Update to 7.
       [not found] <0b38d5ae8f6461cf5c95c9965bfc3970d043e598.1694900842.git.hendursaga.ref@aol.com>
@ 2023-09-16 21:48 ` Hendursaga via Guix-patches via
  2023-09-25 10:56   ` bug#66038: " Christopher Baines
  0 siblings, 1 reply; 4+ messages in thread
From: Hendursaga via Guix-patches via @ 2023-09-16 21:48 UTC (permalink / raw)
  To: 66038

* gnu/packages/mail.scm (muchsync): Update to 7.
---
 gnu/packages/mail.scm | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index ecaab1c7cd..d070cf9518 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1621,19 +1621,17 @@ (define-public bower
 (define-public muchsync
   (package
     (name "muchsync")
-    (version "6")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "http://www.muchsync.org/src/"
-                           "muchsync-" version ".tar.gz"))
-       (sha256
-        (base32 "1s799kx16nm5ry1fcqcc0grgxrwnnp4cnzd0hzwbkvc5v2sf6g8b"))))
+    (version "7")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://www.muchsync.org/src/" "muchsync-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1b5ylf0xgb59x6hna5gllm6nb1jn50wqvp7xfls83x0frmpjygpq"))))
     (build-system gnu-build-system)
-    (native-inputs
-     (list pandoc pkg-config))
-    (inputs
-     (list openssl notmuch sqlite xapian))
+    (native-inputs (list pandoc pkg-config))
+    (inputs (list openssl notmuch sqlite xapian))
     (home-page "https://www.muchsync.org/")
     (synopsis "Synchronize notmuch mail across machines")
     (description

base-commit: 952a0ce2800e4fe9165184151412858ed8d34760
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#66038: [PATCH] gnu: muchsync: Update to 7.
  2023-09-16 21:48 ` [bug#66038] [PATCH] gnu: muchsync: Update to 7 Hendursaga via Guix-patches via
@ 2023-09-25 10:56   ` Christopher Baines
  2023-09-25 17:21     ` [bug#66038] " Hendursaga via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Christopher Baines @ 2023-09-25 10:56 UTC (permalink / raw)
  To: Hendursaga; +Cc: 66038-done, guix-patches

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]


Hendursaga via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/mail.scm (muchsync): Update to 7.
> ---
>  gnu/packages/mail.scm | 22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)

Thanks for the patch. I've tweaked the patch to remove the indentation
changes, as I wasn't sure those were intentional, and I've added a bit
to the commit message about the change to https, as that seems sensible.

Pushed to master as 7a563a4fafba05db0f423d9c4a7badc8f394182f.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#66038] [PATCH] gnu: muchsync: Update to 7.
  2023-09-25 10:56   ` bug#66038: " Christopher Baines
@ 2023-09-25 17:21     ` Hendursaga via Guix-patches via
  2023-09-25 17:54       ` Christopher Baines
  0 siblings, 1 reply; 4+ messages in thread
From: Hendursaga via Guix-patches via @ 2023-09-25 17:21 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 66038-done, 66038

Christopher Baines <mail@cbaines.net> writes:

> Thanks for the patch. I've tweaked the patch to remove the indentation
> changes, as I wasn't sure those were intentional[...]

I ran it through `guix style` as I thought one was supposed to do.
Should I have added something to the ChangeLog message to make that more
clear, perhaps?

I don't think I've replied to a "done" issue before, so I hope my
automagically generated Cc's are appropriate!

~ Hendursaga




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#66038] [PATCH] gnu: muchsync: Update to 7.
  2023-09-25 17:21     ` [bug#66038] " Hendursaga via Guix-patches via
@ 2023-09-25 17:54       ` Christopher Baines
  0 siblings, 0 replies; 4+ messages in thread
From: Christopher Baines @ 2023-09-25 17:54 UTC (permalink / raw)
  To: Hendursaga; +Cc: 66038-done, 66038

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]


Hendursaga <hendursaga@aol.com> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> Thanks for the patch. I've tweaked the patch to remove the indentation
>> changes, as I wasn't sure those were intentional[...]
>
> I ran it through `guix style` as I thought one was supposed to do.
> Should I have added something to the ChangeLog message to make that more
> clear, perhaps?

Something to the commit message maybe, and it can also be useful to keep
stylistic changes and functional changes in separate commits. So you
would have a "apply guix style" commit and a "update to X" commit.

> I don't think I've replied to a "done" issue before, so I hope my
> automagically generated Cc's are appropriate!

Yep, I think it's fine.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-25 18:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <0b38d5ae8f6461cf5c95c9965bfc3970d043e598.1694900842.git.hendursaga.ref@aol.com>
2023-09-16 21:48 ` [bug#66038] [PATCH] gnu: muchsync: Update to 7 Hendursaga via Guix-patches via
2023-09-25 10:56   ` bug#66038: " Christopher Baines
2023-09-25 17:21     ` [bug#66038] " Hendursaga via Guix-patches via
2023-09-25 17:54       ` Christopher Baines

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).