unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#67601] [PATCH gnome-team] gnu: Add xdg-desktop-portal-gnome.
@ 2023-12-03 13:51 Vivien Kraus via Guix-patches via
  2023-12-03 13:51 ` [bug#67601] [PATCH gnome-team v2 1/2] " Vivien Kraus via Guix-patches via
  2023-12-04  0:30 ` [bug#67601] [PATCH gnome-team] " Maxim Cournoyer
  0 siblings, 2 replies; 7+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-12-03 13:51 UTC (permalink / raw)
  To: 67601; +Cc: rg, liliana.prikler, maxim.cournoyer

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2513 bytes --]

* gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.
(gnome) [propagated-inputs]: Add xdg-desktop-portal-gnome.

Change-Id: I2925cf950b731c71e4ad4a01f28bce22c0cb54fb
---
Dear Guix,

I’m not sure what I’m doing here. xdg-desktop-portal-gnome is a core app, so I
guess I should add it to the gnome propagated inputs?

Best regards,

Vivien

 gnu/packages/gnome.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d354327497..3a69aca3ba 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -10114,6 +10114,7 @@ (define-public gnome
           simple-scan
           totem
           tracker-miners
+          xdg-desktop-portal-gnome
           yelp
           ;; Others.
           gnome-online-accounts
@@ -12841,6 +12842,44 @@ (define-public piper
   (simple-service 'ratbagd dbus-root-service-type (list libratbag))")
     (license license:gpl2)))
 
+(define-public xdg-desktop-portal-gnome
+  (package
+    (name "xdg-desktop-portal-gnome")
+    (version "44.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/" name "/"
+                                  (version-major version) "/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "08gznmr718na5p2j8fm7nim5862r2v0sjh68ql5yl0q356n1mvah"))
+              (snippet
+               #~(begin
+                   (use-modules (guix build utils))
+                   (delete-file-recursively "subprojects")))))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:glib-or-gtk? #t
+      #:configure-flags #~'("-Dsystemduserunitdir=no")))
+    (inputs
+     (list gnome-desktop
+           gsettings-desktop-schemas
+           libadwaita
+           libxml2
+           xdg-desktop-portal
+           xdg-desktop-portal-gtk))
+    (native-inputs
+     (list gettext-minimal
+           `(,glib "bin")
+           pkg-config))
+    (home-page "https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome")
+    (synopsis "GNOME backend for xdg-desktop-portal")
+    (description "xdg-desktop-portal-gnome implements a back-end for
+@command{xdg-desktop-portal} that uses gtk and some more GNOME APIs.")
+    (license license:lgpl2.1+)))
+
 (define-public parlatype
   (package
     (name "parlatype")

base-commit: e21f0cb7b7a87992004193cd56638ad961fe5928
-- 
2.41.0




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#67601] [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome.
  2023-12-03 13:51 [bug#67601] [PATCH gnome-team] gnu: Add xdg-desktop-portal-gnome Vivien Kraus via Guix-patches via
@ 2023-12-03 13:51 ` Vivien Kraus via Guix-patches via
  2023-12-04 18:16   ` [bug#67601] [PATCH gnome-team v2 2/2] gnu: gnome: Propagate xdg-desktop-portal-gnome Vivien Kraus via Guix-patches via
  2023-12-05  0:30   ` [bug#67601] [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome Maxim Cournoyer
  2023-12-04  0:30 ` [bug#67601] [PATCH gnome-team] " Maxim Cournoyer
  1 sibling, 2 replies; 7+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-12-03 13:51 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: rg, liliana.prikler, 67601

* gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.

Change-Id: I2925cf950b731c71e4ad4a01f28bce22c0cb54fb
---
 gnu/packages/gnome.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c6437ce450..1a515af4e7 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -12866,6 +12866,44 @@ (define-public piper
   (simple-service 'ratbagd dbus-root-service-type (list libratbag))")
     (license license:gpl2)))
 
+(define-public xdg-desktop-portal-gnome
+  (package
+    (name "xdg-desktop-portal-gnome")
+    (version "44.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnome/sources/" name "/"
+                                  (version-major version) "/"
+                                  name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "08gznmr718na5p2j8fm7nim5862r2v0sjh68ql5yl0q356n1mvah"))
+              (snippet
+               #~(begin
+                   (use-modules (guix build utils))
+                   (delete-file-recursively "subprojects")))))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:glib-or-gtk? #t
+      #:configure-flags #~'("-Dsystemduserunitdir=no")))
+    (inputs
+     (list gnome-desktop
+           gsettings-desktop-schemas
+           libadwaita
+           libxml2
+           xdg-desktop-portal
+           xdg-desktop-portal-gtk))
+    (native-inputs
+     (list gettext-minimal
+           `(,glib "bin")
+           pkg-config))
+    (home-page "https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome")
+    (synopsis "GNOME backend for xdg-desktop-portal")
+    (description "xdg-desktop-portal-gnome implements a back-end for
+@command{xdg-desktop-portal} that uses gtk and some more GNOME APIs.")
+    (license license:lgpl2.1+)))
+
 (define-public parlatype
   (package
     (name "parlatype")

base-commit: 4c323c2f8308bba0e3295f3109d159c7b8f72838
-- 
2.41.0




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#67601] [PATCH gnome-team] gnu: Add xdg-desktop-portal-gnome.
  2023-12-03 13:51 [bug#67601] [PATCH gnome-team] gnu: Add xdg-desktop-portal-gnome Vivien Kraus via Guix-patches via
  2023-12-03 13:51 ` [bug#67601] [PATCH gnome-team v2 1/2] " Vivien Kraus via Guix-patches via
@ 2023-12-04  0:30 ` Maxim Cournoyer
  1 sibling, 0 replies; 7+ messages in thread
From: Maxim Cournoyer @ 2023-12-04  0:30 UTC (permalink / raw)
  To: Vivien Kraus, 67601; +Cc: rg, liliana.prikler

Hi Vivien,

Vivien Kraus <vivien@planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.
> (gnome) [propagated-inputs]: Add xdg-desktop-portal-gnome.

These should be in two seperate commits (1. adding the new package and
2. adding it as an propagated-input to the gnome package)

> Dear Guix,
>
> I’m not sure what I’m doing here. xdg-desktop-portal-gnome is a core app, so I
> guess I should add it to the gnome propagated inputs?

https://ftp2.nluug.nl/windowing/gnome/teams/releng/45.0/versions indeed
suggests it is a core application, so adding it to 'gnome' sounds
reasonable to me.

If you split the commits, LGTM.

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#67601] [PATCH gnome-team v2 2/2] gnu: gnome: Propagate xdg-desktop-portal-gnome.
  2023-12-03 13:51 ` [bug#67601] [PATCH gnome-team v2 1/2] " Vivien Kraus via Guix-patches via
@ 2023-12-04 18:16   ` Vivien Kraus via Guix-patches via
  2023-12-05  0:30     ` Maxim Cournoyer
  2023-12-05  0:30   ` [bug#67601] [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome Maxim Cournoyer
  1 sibling, 1 reply; 7+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2023-12-04 18:16 UTC (permalink / raw)
  To: Maxim Cournoyer; +Cc: rg, liliana.prikler, 67601

* gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add
xdg-desktop-portal-gnome.

Change-Id: I2a911ec58a1c9992213e60d92a3dd955dd1a545e
---
 gnu/packages/gnome.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 1a515af4e7..71a8a4b7ec 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -10137,6 +10137,7 @@ (define-public gnome
           simple-scan
           totem
           tracker-miners
+          xdg-desktop-portal-gnome
           yelp
           ;; Others.
           gnome-online-accounts
-- 
2.41.0




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#67601] [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome.
  2023-12-03 13:51 ` [bug#67601] [PATCH gnome-team v2 1/2] " Vivien Kraus via Guix-patches via
  2023-12-04 18:16   ` [bug#67601] [PATCH gnome-team v2 2/2] gnu: gnome: Propagate xdg-desktop-portal-gnome Vivien Kraus via Guix-patches via
@ 2023-12-05  0:30   ` Maxim Cournoyer
  2023-12-19 23:02     ` bug#67601: " Liliana Marie Prikler
  1 sibling, 1 reply; 7+ messages in thread
From: Maxim Cournoyer @ 2023-12-05  0:30 UTC (permalink / raw)
  To: Vivien Kraus; +Cc: rg, liliana.prikler, 67601

Vivien Kraus <vivien@planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.
>
> Change-Id: I2925cf950b731c71e4ad4a01f28bce22c0cb54fb

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#67601] [PATCH gnome-team v2 2/2] gnu: gnome: Propagate xdg-desktop-portal-gnome.
  2023-12-04 18:16   ` [bug#67601] [PATCH gnome-team v2 2/2] gnu: gnome: Propagate xdg-desktop-portal-gnome Vivien Kraus via Guix-patches via
@ 2023-12-05  0:30     ` Maxim Cournoyer
  0 siblings, 0 replies; 7+ messages in thread
From: Maxim Cournoyer @ 2023-12-05  0:30 UTC (permalink / raw)
  To: Vivien Kraus; +Cc: rg, liliana.prikler, 67601

Vivien Kraus <vivien@planete-kraus.eu> writes:

> * gnu/packages/gnome.scm (gnome) [propagated-inputs]: Add
> xdg-desktop-portal-gnome.
>
> Change-Id: I2a911ec58a1c9992213e60d92a3dd955dd1a545e

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#67601: [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome.
  2023-12-05  0:30   ` [bug#67601] [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome Maxim Cournoyer
@ 2023-12-19 23:02     ` Liliana Marie Prikler
  0 siblings, 0 replies; 7+ messages in thread
From: Liliana Marie Prikler @ 2023-12-19 23:02 UTC (permalink / raw)
  To: Maxim Cournoyer, Vivien Kraus; +Cc: rg, 67601-done

Am Montag, dem 04.12.2023 um 19:30 -0500 schrieb Maxim Cournoyer:
> Vivien Kraus <vivien@planete-kraus.eu> writes:
> 
> > * gnu/packages/gnome.scm (xdg-desktop-portal-gnome): New variable.
> > 
> > Change-Id: I2925cf950b731c71e4ad4a01f28bce22c0cb54fb
> 
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Pushed at last.




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-12-19 23:03 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-03 13:51 [bug#67601] [PATCH gnome-team] gnu: Add xdg-desktop-portal-gnome Vivien Kraus via Guix-patches via
2023-12-03 13:51 ` [bug#67601] [PATCH gnome-team v2 1/2] " Vivien Kraus via Guix-patches via
2023-12-04 18:16   ` [bug#67601] [PATCH gnome-team v2 2/2] gnu: gnome: Propagate xdg-desktop-portal-gnome Vivien Kraus via Guix-patches via
2023-12-05  0:30     ` Maxim Cournoyer
2023-12-05  0:30   ` [bug#67601] [PATCH gnome-team v2 1/2] gnu: Add xdg-desktop-portal-gnome Maxim Cournoyer
2023-12-19 23:02     ` bug#67601: " Liliana Marie Prikler
2023-12-04  0:30 ` [bug#67601] [PATCH gnome-team] " Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).