unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brett Gilio <brettg@posteo.net>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 38463@debbugs.gnu.org
Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists.
Date: Thu, 05 Dec 2019 12:46:55 -0600	[thread overview]
Message-ID: <877e3ad2zk.fsf@posteo.net> (raw)
In-Reply-To: <3a8ad02f296ee82a82149e949ba7d5c367950df8.camel@student.tugraz.at> (Leo Prikler's message of "Thu, 05 Dec 2019 19:18:27 +0100")

Leo Prikler <leo.prikler@student.tugraz.at> writes:

>
> Hi Brett,
>
> That's my bad, I haven't looked at the structure of share/emacs/site-
> lisp since the last change has been made.  I expected, that packages
> still had their own folders, just with guix.d in the middle being
> removed, but just now found out that everything is at top-level.

I know how you feel. The recent changes has thrown me into a whirlpool
of confusion. That is why I made the note about eventually replacing the
installation of that directory to use the system usually used by
`emacs-build-system` because I figure this would cause less issues in
the future if for some reason the emacs site-lisp directory structure
were to change again.

--8<---------------cut here---------------start------------->8---
;; TODO: Replace with `#:include' method used by
;; emacs-build-system.
--8<---------------cut here---------------end--------------->8---

But I don't think it is a pressing issue to do it so cleanly.
Or maybe it is. Idk.


> I still don't feel comfortable with data being at the top of site-lisp, 
> though.  Perhaps something similar to emacs-yasnippet-snippets, where
> you store the data in share/emacs/telega-data would be more
> appropriate.

I was ACTUALLY going to do it this way originally, but I was really
uncertain of it so I just sent the patch as is. I like the idea more, so
I am going to revise the patch. Otherwise, once I get this revision in
everything should be good to go. I'll also substitute the functions to
reflect that changed path.

While I am at it, I want to do a shameless plug for Evgeny Zajcev who
has been supportive of me making additions to his repository to include
instructions on installing `telega` from Guix, including a local-build
`guix.scm`, adding a tag for Guix on the repo description, and adding an
issue label for Guix as well. If any of you are reading this and use
Telegram as a messaging client, join https://t.me/emacs_telega and give
him (@zevlg) and I (@brettmg) a hello. The work he has been doing has
been great, even though the build recipe for it for Guix is well over
100 LoC now. Ha.

Alright, carry on! Patch will be available soon.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

  reply	other threads:[~2019-12-05 18:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 21:33 [bug#38463] [PATCH] Telega test suite and change in revision Brett Gilio
2019-12-02 21:34 ` [bug#38463] [PATCH 1/2] gnu: emacs-telega: Use test suites Brett Gilio
2019-12-02 21:35 ` [bug#38463] [PATCH 2/2] gnu: emacs-telega: Update to 0.4.4-2 Brett Gilio
2019-12-05  0:36 ` [bug#38463] [PATCH] Telega test suite and change in revision Brett Gilio
2019-12-05 13:50 ` [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists Brett Gilio
2019-12-05 17:31 ` Leo Prikler
2019-12-05 18:00   ` Brett Gilio
2019-12-05 18:18     ` Leo Prikler
2019-12-05 18:46       ` Brett Gilio [this message]
2019-12-05 22:55         ` Leo Prikler
2019-12-05 20:01 ` [bug#38463] [PATCH 3/3] gnu: emacs-telega: Install telega-data to site-lisp Brett Gilio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e3ad2zk.fsf@posteo.net \
    --to=brettg@posteo.net \
    --cc=38463@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).