From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:48182) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icwAW-0007lC-W6 for guix-patches@gnu.org; Thu, 05 Dec 2019 13:48:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icwAV-0006jn-FU for guix-patches@gnu.org; Thu, 05 Dec 2019 13:48:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icwAU-0006gP-Ru for guix-patches@gnu.org; Thu, 05 Dec 2019 13:48:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1icwAU-0000Ir-Pf for guix-patches@gnu.org; Thu, 05 Dec 2019 13:48:02 -0500 Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists. Resent-Message-ID: From: Brett Gilio References: <3566e38523f0ff4badf50ade8c1498006f1cb872.camel@student.tugraz.at> <87fthyd54z.fsf@posteo.net> <3a8ad02f296ee82a82149e949ba7d5c367950df8.camel@student.tugraz.at> Date: Thu, 05 Dec 2019 12:46:55 -0600 In-Reply-To: <3a8ad02f296ee82a82149e949ba7d5c367950df8.camel@student.tugraz.at> (Leo Prikler's message of "Thu, 05 Dec 2019 19:18:27 +0100") Message-ID: <877e3ad2zk.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Prikler Cc: 38463@debbugs.gnu.org Leo Prikler writes: > > Hi Brett, > > That's my bad, I haven't looked at the structure of share/emacs/site- > lisp since the last change has been made. I expected, that packages > still had their own folders, just with guix.d in the middle being > removed, but just now found out that everything is at top-level. I know how you feel. The recent changes has thrown me into a whirlpool of confusion. That is why I made the note about eventually replacing the installation of that directory to use the system usually used by `emacs-build-system` because I figure this would cause less issues in the future if for some reason the emacs site-lisp directory structure were to change again. --8<---------------cut here---------------start------------->8--- ;; TODO: Replace with `#:include' method used by ;; emacs-build-system. --8<---------------cut here---------------end--------------->8--- But I don't think it is a pressing issue to do it so cleanly. Or maybe it is. Idk. > I still don't feel comfortable with data being at the top of site-lisp, > though. Perhaps something similar to emacs-yasnippet-snippets, where > you store the data in share/emacs/telega-data would be more > appropriate. I was ACTUALLY going to do it this way originally, but I was really uncertain of it so I just sent the patch as is. I like the idea more, so I am going to revise the patch. Otherwise, once I get this revision in everything should be good to go. I'll also substitute the functions to reflect that changed path. While I am at it, I want to do a shameless plug for Evgeny Zajcev who has been supportive of me making additions to his repository to include instructions on installing `telega` from Guix, including a local-build `guix.scm`, adding a tag for Guix on the repo description, and adding an issue label for Guix as well. If any of you are reading this and use Telegram as a messaging client, join https://t.me/emacs_telega and give him (@zevlg) and I (@brettmg) a hello. The work he has been doing has been great, even though the build recipe for it for Guix is well over 100 LoC now. Ha. Alright, carry on! Patch will be available soon. -- Brett M. Gilio https://git.sr.ht/~brettgilio/