From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 34638@debbugs.gnu.org
Subject: [bug#34638] [PATCH v2 4/4] inferior: Add 'open-inferior/container'.
Date: Thu, 26 Mar 2020 10:32:27 +0100 [thread overview]
Message-ID: <877dz7ea1g.fsf@gnu.org> (raw)
In-Reply-To: <20190419140427.15183-4-mail@cbaines.net> (Christopher Baines's message of "Fri, 19 Apr 2019 15:04:27 +0100")
Christopher Baines <mail@cbaines.net> skribis:
> ---
> guix/inferior.scm | 76 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 76 insertions(+)
[...]
> +(define* (open-inferior/container store guix-store-item
> + #:key
> + (command "bin/guix")
> + (share-host-network? #f)
> + (extra-shared-directories '())
> + (extra-environment-variables '()))
Please add a docstring. Same comment as before regarding “extras”. :-)
> + (start-child-in-container
> + (list (string-append guix-store-item "/bin/guix")
> + ;; TODO I'm not sure why "repl" is duplicated in the following
> + ;; command
> + "repl" "repl" "-t" "machine")
This is the argv[0] issue mentioned earlier.
I think it’s not really feasible to write a test for this one, or at
least I don’t see how.
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2020-03-26 9:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 16:12 [bug#34638] [PATCH 0/4] Isolated inferiors Christopher Baines
2019-02-24 16:18 ` [bug#34638] [PATCH 1/4] utils: Add #:base-directory to call-with-temporary-directory Christopher Baines
2019-02-24 16:18 ` [bug#34638] [PATCH 2/4] linux-container: Add 'start-child-in-container' Christopher Baines
2019-03-14 18:17 ` Ludovic Courtès
2019-04-19 14:16 ` Christopher Baines
2019-02-24 16:18 ` [bug#34638] [PATCH 3/4] inferior: Add a shared-directory field to <inferior> Christopher Baines
2019-02-24 16:18 ` [bug#34638] [PATCH 4/4] inferior: Add 'open-inferior/container' Christopher Baines
2019-03-14 19:35 ` [bug#34638] [PATCH 0/4] Isolated inferiors Ludovic Courtès
2019-04-19 14:04 ` [bug#34638] [PATCH v2 1/4] utils: Add #:base-directory to call-with-temporary-directory Christopher Baines
2019-04-19 14:04 ` [bug#34638] [PATCH v2 2/4] linux-container: Add 'start-child-in-container' Christopher Baines
2020-03-26 9:28 ` Ludovic Courtès
2020-03-28 11:26 ` Christopher Baines
2020-03-28 12:20 ` Ludovic Courtès
2019-04-19 14:04 ` [bug#34638] [PATCH v2 3/4] inferior: Add a shared-directory field to <inferior> Christopher Baines
2020-03-26 9:30 ` Ludovic Courtès
2019-04-19 14:04 ` [bug#34638] [PATCH v2 4/4] inferior: Add 'open-inferior/container' Christopher Baines
2020-03-26 9:32 ` Ludovic Courtès [this message]
2020-03-26 9:22 ` [bug#34638] [PATCH v2 1/4] utils: Add #:base-directory to call-with-temporary-directory Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dz7ea1g.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=34638@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).