From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:46398)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jHOso-0002HB-Og
 for guix-patches@gnu.org; Thu, 26 Mar 2020 05:33:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jHOsn-0005GQ-SO
 for guix-patches@gnu.org; Thu, 26 Mar 2020 05:33:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:52148)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jHOsn-0005GL-PC
 for guix-patches@gnu.org; Thu, 26 Mar 2020 05:33:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jHOsn-0003TK-Mm
 for guix-patches@gnu.org; Thu, 26 Mar 2020 05:33:01 -0400
Subject: [bug#34638] [PATCH v2 4/4] inferior: Add 'open-inferior/container'.
Resent-Message-ID: <handler.34638.B34638.158521515513307@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190419140427.15183-1-mail@cbaines.net>
 <20190419140427.15183-4-mail@cbaines.net>
Date: Thu, 26 Mar 2020 10:32:27 +0100
In-Reply-To: <20190419140427.15183-4-mail@cbaines.net> (Christopher Baines's
 message of "Fri, 19 Apr 2019 15:04:27 +0100")
Message-ID: <877dz7ea1g.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 34638@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> skribis:

> ---
>  guix/inferior.scm | 76 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 76 insertions(+)

[...]

> +(define* (open-inferior/container store guix-store-item
> +                                  #:key
> +                                  (command "bin/guix")
> +                                  (share-host-network? #f)
> +                                  (extra-shared-directories '())
> +                                  (extra-environment-variables '()))

Please add a docstring.  Same comment as before regarding =E2=80=9Cextras=
=E2=80=9D.  :-)

> +    (start-child-in-container
> +     (list (string-append guix-store-item "/bin/guix")
> +           ;; TODO I'm not sure why "repl" is duplicated in the following
> +           ;; command
> +           "repl" "repl" "-t" "machine")

This is the argv[0] issue mentioned earlier.

I think it=E2=80=99s not really feasible to write a test for this one, or at
least I don=E2=80=99t see how.

Otherwise LGTM, thanks!

Ludo=E2=80=99.