unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Niklas Eklund <niklas.eklund@posteo.net>
Cc: 45105@debbugs.gnu.org
Subject: [bug#45105] [PATCH] gnu: Add mbpfan service
Date: Wed, 06 Jan 2021 11:11:08 +0100	[thread overview]
Message-ID: <877doqpe83.fsf@gnu.org> (raw)
In-Reply-To: <87a6ups6pd.fsf@posteo.net> (Niklas Eklund's message of "Mon, 07 Dec 2020 21:26:54 +0100")


Hello Niklas,

> * gnu/services/mbpfan.scm (mbpfan service): New variable.

Thanks for your contribution and sorry for the late review.

> +                       #$@(if verbose?
> +                            '("-v") ; verbose logging
> +                            '()))
> +                 #:log-file #$log-file))

The indentation is off here.

> +    (list (service-extension shepherd-root-service-type mbpfan-shepherd-service)))

You should wrap this line to stay under the 78 cols limit.

You also need to add this file to 'gnu/local.mk'. It would also be nice
to write some documentation, probably under "Power management services".

Could you please send an updated patch?

Thanks,

Mathieu




  reply	other threads:[~2021-01-06 10:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 20:26 [bug#45105] [PATCH] gnu: Add mbpfan service Niklas Eklund
2021-01-06 10:11 ` Mathieu Othacehe [this message]
2021-11-03 12:34 ` [bug#45105] [PATCH v2] " phodina via Guix-patches via
2022-01-02 18:03 ` [bug#45105] [PATCH v3] " Jorge Acereda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877doqpe83.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=45105@debbugs.gnu.org \
    --cc=niklas.eklund@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).