From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SPp1AfmM9V8LUQAA0tVLHw (envelope-from ) for ; Wed, 06 Jan 2021 10:12:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2APcOPiM9V9xOQAAB5/wlQ (envelope-from ) for ; Wed, 06 Jan 2021 10:12:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C1B1A940414 for ; Wed, 6 Jan 2021 10:12:08 +0000 (UTC) Received: from localhost ([::1]:48660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kx5nT-0000aZ-JC for larch@yhetil.org; Wed, 06 Jan 2021 05:12:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kx5nO-0000aS-3x for guix-patches@gnu.org; Wed, 06 Jan 2021 05:12:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60191) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kx5nN-0007fL-TC for guix-patches@gnu.org; Wed, 06 Jan 2021 05:12:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kx5nN-0004VV-Mg for guix-patches@gnu.org; Wed, 06 Jan 2021 05:12:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45105] [PATCH] gnu: Add mbpfan service Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 06 Jan 2021 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45105 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Niklas Eklund Received: via spool by 45105-submit@debbugs.gnu.org id=B45105.160992787617268 (code B ref 45105); Wed, 06 Jan 2021 10:12:01 +0000 Received: (at 45105) by debbugs.gnu.org; 6 Jan 2021 10:11:16 +0000 Received: from localhost ([127.0.0.1]:43503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kx5me-0004US-J9 for submit@debbugs.gnu.org; Wed, 06 Jan 2021 05:11:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kx5md-0004UG-CX for 45105@debbugs.gnu.org; Wed, 06 Jan 2021 05:11:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57540) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kx5mY-0007HP-8V; Wed, 06 Jan 2021 05:11:10 -0500 Received: from [2a01:e0a:19b:d9a0:d54b:f4e5:4687:8012] (port=42986 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kx5mX-0008OB-OS; Wed, 06 Jan 2021 05:11:10 -0500 From: Mathieu Othacehe References: <87a6ups6pd.fsf@posteo.net> Date: Wed, 06 Jan 2021 11:11:08 +0100 In-Reply-To: <87a6ups6pd.fsf@posteo.net> (Niklas Eklund's message of "Mon, 07 Dec 2020 21:26:54 +0100") Message-ID: <877doqpe83.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45105@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.84 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C1B1A940414 X-Spam-Score: -2.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: cRYhrGzSMpVs Hello Niklas, > * gnu/services/mbpfan.scm (mbpfan service): New variable. Thanks for your contribution and sorry for the late review. > + #$@(if verbose? > + '("-v") ; verbose logging > + '())) > + #:log-file #$log-file)) The indentation is off here. > + (list (service-extension shepherd-root-service-type mbpfan-shepherd-service))) You should wrap this line to stay under the 78 cols limit. You also need to add this file to 'gnu/local.mk'. It would also be nice to write some documentation, probably under "Power management services". Could you please send an updated patch? Thanks, Mathieu