From: Ricardo Wurmus <rekado@elephly.net>
To: hli@mdc-berlin.de
Cc: 47314-done@debbugs.gnu.org
Subject: bug#47314: [Patch] two r packages (chromstardata and signac)
Date: Mon, 22 Mar 2021 14:39:09 +0100 [thread overview]
Message-ID: <877dlzwbnm.fsf@elephly.net> (raw)
In-Reply-To: <CACnRHThdKzAjgbhse3nZTOXM6Mn4LuSYSTVoLe-Bio_GqsV=ww@mail.gmail.com>
Hi,
thank you taking the time to submit your first patch!
I pushed the changes to the “master” branch with these commits:
ee4fc3b662 * gnu: Add r-signac.
dd4670d40d * gnu: Add r-lsa.
0ff888108a * gnu: Add r-chromstar.
1f958631ef * gnu: Add r-chromstardata.
Some of the changes I performed:
- As you can see I split up the patch into one commit per affected
package.
- I added r-lsa, which r-signac references.
- I changed all license values to use a “license:” prefix. The importer
does not do this.
- I placed r-signac in (gnu packages bioinformatics), r-lsa in (gnu
packages cran), r-chromstar in (gnu package bioconductor), and
r-chromstardata in the same module but in the section for experiment
data.
- I modified the descriptions and synopses to remove the R-typical use
of title case, and to use full sentences.
- r-chromstar was built from git in a version more recent than the
version corresponding to the current Bioconductor release, so I used
the published release instead.
- I reindented the code. Note that etc/indent-code.el can do this for
you.
The contribution process we follow and recommend is outlined in the
manual section “16.6 Submitting Patches”, which contains a few hints
that will make future contributions a little smoother :)
Also, feel free to Cc me for future submissions, so that I can apply
them more quickly.
Thanks again!
--
Ricardo
prev parent reply other threads:[~2021-03-22 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 10:12 [bug#47314] [Patch] two r packages (chromstardata and signac) hong li
2021-03-22 13:39 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dlzwbnm.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=47314-done@debbugs.gnu.org \
--cc=hli@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).