From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id wLN5IWWhWGAcWwAA0tVLHw (envelope-from ) for ; Mon, 22 Mar 2021 13:53:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6G86HWWhWGCiNAAAbx9fmQ (envelope-from ) for ; Mon, 22 Mar 2021 13:53:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB900DA43 for ; Mon, 22 Mar 2021 14:53:40 +0100 (CET) Received: from localhost ([::1]:36194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOKzz-0003i2-Jg for larch@yhetil.org; Mon, 22 Mar 2021 09:53:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOKmp-0006fj-Cs for guix-patches@gnu.org; Mon, 22 Mar 2021 09:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOKmp-0000Px-0M for guix-patches@gnu.org; Mon, 22 Mar 2021 09:40:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lOKmo-0006UU-T7 for guix-patches@gnu.org; Mon, 22 Mar 2021 09:40:02 -0400 Subject: bug#47314: [Patch] two r packages (chromstardata and signac) References: In-Reply-To: Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 22 Mar 2021 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 47314 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: hli@mdc-berlin.de Cc: 47314-done@debbugs.gnu.org Mail-Followup-To: 47314@debbugs.gnu.org, rekado@elephly.net, hongli520@gmail.com Received: via spool by 47314-done@debbugs.gnu.org id=D47314.161642036224874 (code D ref 47314); Mon, 22 Mar 2021 13:40:02 +0000 Received: (at 47314-done) by debbugs.gnu.org; 22 Mar 2021 13:39:22 +0000 Received: from localhost ([127.0.0.1]:56486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOKmA-0006T8-DS for submit@debbugs.gnu.org; Mon, 22 Mar 2021 09:39:22 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOKm9-0006T0-3s for 47314-done@debbugs.gnu.org; Mon, 22 Mar 2021 09:39:21 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1616420357; cv=none; d=zohomail.com; s=zohoarc; b=cu2rVdK5wneo5Znoq3W7kV974hC2b/fsOmpSqgjOxU5ottcXu2waf3nL5SeTkINkkazF8hawJ+mvJWhGwb7SE6QrwXHukNqsfRs19+UcrzUmg9yJcZBE9LHDXiBuMWP8wbo58kG0JOynqvy9Z/XwKJbEdDNQkvUHP7Gn9xpY8Oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1616420357; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=pmjcH6OHQu4QN+DIOuv1Z/c6bxsBYANTHeRlXZWYcFg=; b=TfeCZIsk4MJRIqUOXM7wwq1wNtxnaXF5G4mieFUJpCrh+t9aeAaD3rmMPOeVcV73Y1HLsWbKDfa0YioqFa9CuYF5scHAktZi62PhreOxSqAh5VHwXreQ5zuyGCpU/rb/o6gdET3H9sHiEmWukGcy+TrLOHfcM2aFjtsmbOjNEKg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1616420357; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=pmjcH6OHQu4QN+DIOuv1Z/c6bxsBYANTHeRlXZWYcFg=; b=TY0ZvvUK6LG0pPZwuPupwj+wu3+V3btHRZHzjtOjajyqe+owUaTVqd1wU42VdWGb o4iGqy8F/AHguCkmLxS1QdKlXrJvsab+rc13o1Et9AmyLJfcIC08q/A0hpPyaZJh43h 101JaP4MXTm/1+Dozl9k4/yCbno1fivZXTCzaZM4= Received: from localhost (p54ad4f52.dip0.t-ipconnect.de [84.173.79.82]) by mx.zohomail.com with SMTPS id 1616420352958625.4386533154911; Mon, 22 Mar 2021 06:39:12 -0700 (PDT) User-agent: mu4e 1.4.14; emacs 27.1 From: Ricardo Wurmus X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Mon, 22 Mar 2021 14:39:09 +0100 Message-ID: <877dlzwbnm.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616421221; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pmjcH6OHQu4QN+DIOuv1Z/c6bxsBYANTHeRlXZWYcFg=; b=Sb+ViJWyNmWoYweL/nXSKhiR4dgvHWWvSM+uzyldZNzd8myqGNnk8Q280ObuaSuoCkJJ9y ZRgbWvEyIPM7Zex1T+MeSNNZ+FwBk6xoJJdkW0IF/oCyJhtzfbzBuGQlnzjsfcJECF6Kz9 v+zLmsgaW2jnZP/uo1EXS6/5HPu18PAcaSN5QHtuwxbY68dGlq4C1zzoW1xeMG8hedW7vz 0huDmxCQBT19q9DLUjv6V62+jH/D5pmaLszlnNV8/BNnMaVPW+71QIDJeGyiYegwXhssEQ HERtl41/NWrHOl0sUzapiinTh/BYzhZ1Flt1Lw+FdJpz8c/pxotqM0pyRnlvpA== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1616421221; a=rsa-sha256; cv=fail; b=dkdmnS548ZapbikGJDB9ZaiZaVy8E/gxFWKBgZnsjaKfBxJaHvvbYyJRm2qLNWi11KS9yb xG+ArjoGR95yUDPa5DwNV/A07X055/So2EAPigMnjM/aDvdtPQimMtsoSGLusyv2XM0W25 TH9DTY6oOU/jc7Rx4W9xFX0QPgH/sSsL+pKecyztKBMwYN6jPngFsWLB1hHbGVayMUA4IB U4mMVVcgvrVEKVaQNbfdP/owHpgiAjlWghYJF6zm88bn7Cw9/xG9VMJCR0e51n8YMUJNbc PKFwv9vtR42TDt6X2wZPvJimYfuCOezPrcODcPtCEwxjO6Catyo7b5uq0CfCjQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=TY0ZvvUK; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.58 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=TY0ZvvUK; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CB900DA43 X-Spam-Score: 0.58 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2mRkr6V3/jI7 Hi, thank you taking the time to submit your first patch! I pushed the changes to the =E2=80=9Cmaster=E2=80=9D branch with these comm= its: ee4fc3b662 * gnu: Add r-signac. dd4670d40d * gnu: Add r-lsa. 0ff888108a * gnu: Add r-chromstar. 1f958631ef * gnu: Add r-chromstardata. Some of the changes I performed: - As you can see I split up the patch into one commit per affected package. - I added r-lsa, which r-signac references. - I changed all license values to use a =E2=80=9Clicense:=E2=80=9D prefix. = The importer does not do this. - I placed r-signac in (gnu packages bioinformatics), r-lsa in (gnu packages cran), r-chromstar in (gnu package bioconductor), and r-chromstardata in the same module but in the section for experiment data. - I modified the descriptions and synopses to remove the R-typical use of title case, and to use full sentences. - r-chromstar was built from git in a version more recent than the version corresponding to the current Bioconductor release, so I used the published release instead. - I reindented the code. Note that etc/indent-code.el can do this for you. The contribution process we follow and recommend is outlined in the manual section =E2=80=9C16.6 Submitting Patches=E2=80=9D, which contains a = few hints that will make future contributions a little smoother :) Also, feel free to Cc me for future submissions, so that I can apply them more quickly. Thanks again! --=20 Ricardo