unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#49079] [PATCH] gnu: Add ocaml-calendar.
@ 2021-06-17 20:54 Xinglu Chen
  2021-06-18 22:17 ` bug#49079: " Julien Lepiller
  0 siblings, 1 reply; 3+ messages in thread
From: Xinglu Chen @ 2021-06-17 20:54 UTC (permalink / raw)
  To: 49079

* gnu/packages/ocaml.scm (ocaml-calendar): New variable.
---
 gnu/packages/ocaml.scm | 47 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index dcfe8ce391..35c6d4e45e 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2020, 2021 pukkamustard <pukkamustard@posteo.net>
 ;;; Copyright © 2021 aecepoglu <aecepoglu@fastmail.fm>
 ;;; Copyright © 2021 Sharlatan Hellseher <sharlatanus@gmail.com>
+;;; Copyright © 2021 Xinglu Chen <public@yoctocell.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2045,6 +2046,52 @@ manipulate such data.")
 spans without being subject to operating system calendar time adjustments.")
     (license license:isc)))
 
+(define-public ocaml-calendar
+  ;; No tags.
+  ;; Commit from 2019-02-03.
+  (let ((commit "a447a88ae3c1e9873e32d2a95d3d3e7c5ed4a7da")
+        (revision "0"))
+    (package
+      (name "ocaml-calendar")
+      ;; Makefile.in says 2.04.
+      (version (git-version "2.04" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/ocaml-community/calendar")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "09d9gyqm3zkf3z2m9fx87clqihx6brf8rnzm4yq7c8kf1p572hmc"))))
+      (build-system gnu-build-system)
+      (arguments
+       '(#:test-target
+         "tests"
+         #:phases
+         (modify-phases %standard-phases
+           (add-before 'install 'set-environment-variables
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let ((out (assoc-ref outputs "out")))
+                 (setenv "OCAMLFIND_DESTDIR"
+                         (string-append out "/lib/ocaml/site-lib"))
+                 (setenv "OCAMLFIND_LDCONF" "ignore")
+                 (mkdir-p (string-append
+                           out "/lib/ocaml/site-lib/calendar"))))))))
+      (native-inputs
+       `(("autoconf" ,autoconf)
+         ("automake" ,automake)))
+      (propagated-inputs
+       `(("ocaml" ,ocaml)
+         ("ocamlfind" ,ocaml-findlib)))
+      (home-page "https://github.com/ocaml-community/calendar")
+      (synopsis "OCaml library for handling dates and times")
+      (description "This package provides types and operations over
+dates and times.")
+      ;; With linking exception.
+      (license license:lgpl2.1+))))
+
 (define-public ocaml-cmdliner
   (package
     (name "ocaml-cmdliner")

base-commit: d7fe0414fc18b83d7a1c284b4b411def6a115100
-- 
2.32.0






^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#49079: [PATCH] gnu: Add ocaml-calendar.
  2021-06-17 20:54 [bug#49079] [PATCH] gnu: Add ocaml-calendar Xinglu Chen
@ 2021-06-18 22:17 ` Julien Lepiller
  2021-06-19  8:32   ` [bug#49079] " Xinglu Chen
  0 siblings, 1 reply; 3+ messages in thread
From: Julien Lepiller @ 2021-06-18 22:17 UTC (permalink / raw)
  To: Xinglu Chen; +Cc: 49079-done

Le Thu, 17 Jun 2021 22:54:52 +0200,
Xinglu Chen <public@yoctocell.xyz> a écrit :

> * gnu/packages/ocaml.scm (ocaml-calendar): New variable.
> ---

Pushed as dee608a1bb09e691e32203f2493975d71318c296 to master, thank you!

Note that the package embedded time, so it was not deterministic. Since
it was simple to locate, I added a phase that replaces the date with a
constant string. I also moved "tests" on the same line as #:test-target.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#49079] [PATCH] gnu: Add ocaml-calendar.
  2021-06-18 22:17 ` bug#49079: " Julien Lepiller
@ 2021-06-19  8:32   ` Xinglu Chen
  0 siblings, 0 replies; 3+ messages in thread
From: Xinglu Chen @ 2021-06-19  8:32 UTC (permalink / raw)
  To: Julien Lepiller; +Cc: 49079-done

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

On Sat, Jun 19 2021, Julien Lepiller wrote:

> Le Thu, 17 Jun 2021 22:54:52 +0200,
> Xinglu Chen <public@yoctocell.xyz> a écrit :
>
>> * gnu/packages/ocaml.scm (ocaml-calendar): New variable.
>> ---
>
> Pushed as dee608a1bb09e691e32203f2493975d71318c296 to master, thank you!
>
> Note that the package embedded time, so it was not deterministic. Since
> it was simple to locate, I added a phase that replaces the date with a
> constant string. I also moved "tests" on the same line as #:test-target.

Thank you for catching this!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-19  8:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 20:54 [bug#49079] [PATCH] gnu: Add ocaml-calendar Xinglu Chen
2021-06-18 22:17 ` bug#49079: " Julien Lepiller
2021-06-19  8:32   ` [bug#49079] " Xinglu Chen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).