unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Thiago Jung Bauermann <bauermann@kolabnow.com>
Cc: Maxime Devos <maximedevos@telenet.be>, 50239@debbugs.gnu.org
Subject: [bug#50239] [PATCH core-updates-frozen] gnu: diffutils: Fix signal processing.
Date: Mon, 06 Sep 2021 13:55:52 +0200	[thread overview]
Message-ID: <877dft9auv.fsf@gnu.org> (raw)
In-Reply-To: <20210828164357.8868-1-bauermann@kolabnow.com> (Thiago Jung Bauermann's message of "Sat, 28 Aug 2021 13:43:57 -0300")

Hi,

Thiago Jung Bauermann <bauermann@kolabnow.com> skribis:

> This fixes the build of diffutils on powerpc64le-linux, which currently
> fails more often than not. The patch I’m adding here isn’t being
> shipped by Debian and hasn’t been seen by upstream yet. I just brought
> it to their attention here:
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34519#11

Thanks for working on this!

> I’m not familiar with the diffutils code base, but FWIW I analysed
> the patch and it looks very reasonable to me. To be honest I’m not
> sure if it completely fixes the race condition or just makes it much
> less likely to happen, but in any case I can’t hit the race condition
> anymore.
>
> In addition, since all it does is add a new call to the function which
> checks and processes any pending signal, I don’t think it can cause
> any harm.
>
> Finally, this patch is based on top of the one which updates diffutils
> to version 3.8:
>
> https://issues.guix.gnu.org/50233
>
> The fix works equally well in version 3.7 so if you think it’s not
> worth updating diffutils I can rebase this patch on top of current
> ‘core-updates-frozen’.

Normally we won’t update diffutils on ‘core-updates-frozen’.

Thus, could you adjust this patch so that (1) it applies on
‘core-updates-frozen’, and (2) it doesn’t change derivations on other
platforms (thus, the patch needs to be applied from a build phase)?
Bonus point if there’s an upstream patch to use, as Maxime suggested.

TIA,
Ludo’.




  parent reply	other threads:[~2021-09-06 11:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-28 16:43 [bug#50239] [PATCH core-updates-frozen] gnu: diffutils: Fix signal processing Thiago Jung Bauermann via Guix-patches via
2021-08-30 11:43 ` Maxime Devos
2021-08-30 13:39   ` Thiago Jung Bauermann via Guix-patches via
2021-09-06 11:55 ` Ludovic Courtès [this message]
2021-09-06 13:58   ` Thiago Jung Bauermann via Guix-patches via
2021-09-09 14:41   ` [bug#50239] [PATCH core-updates-frozen v2] " Thiago Jung Bauermann via Guix-patches via
2021-11-12  6:00     ` bug#50239: [PATCH core-updates-frozen] " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dft9auv.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=50239@debbugs.gnu.org \
    --cc=bauermann@kolabnow.com \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).