From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id Pr+9LhYCNmHILQAAgWs5BA (envelope-from ) for ; Mon, 06 Sep 2021 13:57:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id it0jKhYCNmHgGwAA1q6Kng (envelope-from ) for ; Mon, 06 Sep 2021 11:57:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 48DD513C81 for ; Mon, 6 Sep 2021 13:57:10 +0200 (CEST) Received: from localhost ([::1]:55078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNDFN-0005Gy-Ee for larch@yhetil.org; Mon, 06 Sep 2021 07:57:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNDFG-0005Gq-C5 for guix-patches@gnu.org; Mon, 06 Sep 2021 07:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNDFG-0002Nv-4q for guix-patches@gnu.org; Mon, 06 Sep 2021 07:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNDFG-00050e-4D for guix-patches@gnu.org; Mon, 06 Sep 2021 07:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50239] [PATCH core-updates-frozen] gnu: diffutils: Fix signal processing. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Sep 2021 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50239 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thiago Jung Bauermann Cc: Maxime Devos , 50239@debbugs.gnu.org Received: via spool by 50239-submit@debbugs.gnu.org id=B50239.163092937819176 (code B ref 50239); Mon, 06 Sep 2021 11:57:02 +0000 Received: (at 50239) by debbugs.gnu.org; 6 Sep 2021 11:56:18 +0000 Received: from localhost ([127.0.0.1]:52232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNDEX-0004zE-Mh for submit@debbugs.gnu.org; Mon, 06 Sep 2021 07:56:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNDEI-0004yW-LC for 50239@debbugs.gnu.org; Mon, 06 Sep 2021 07:56:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37128) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNDEC-0001Wx-Ex; Mon, 06 Sep 2021 07:55:56 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=47204 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNDEA-0001iT-OK; Mon, 06 Sep 2021 07:55:56 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210828164357.8868-1-bauermann@kolabnow.com> Date: Mon, 06 Sep 2021 13:55:52 +0200 In-Reply-To: <20210828164357.8868-1-bauermann@kolabnow.com> (Thiago Jung Bauermann's message of "Sat, 28 Aug 2021 13:43:57 -0300") Message-ID: <877dft9auv.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630929430; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=C4ItIt/IMSM0KvtuN4BsdxFba8GUnerw7qOUEYIPwcA=; b=ZyZncYKL/Zrj6d0JBwAa6vBPYQcrPp8x8sXypm6tYJRoF5ZuUHli++M4TuhlWiwlosiW6M rojBk+8Ry40qGtvygbPTUmyUDW6/asMUsE5Kd0e31UXJTBsvy5a4CG4TJ/yNyIAgaj3n1i /zgQ06t9kwyokHOfGT4tk/52vUeNa1N51rQf1rBAlv3xsHZ+uSPNgCWhAkQ3AXgjt6ij5N a0HMzTkeypaw7kUmgkE7KK615nS2XJ+7ozt2vZ2xqywLAE9pCo6sSQmHr3tfdKRUACMy9f N0HUO6WzGQly87Gp8frIXaGPyrdGzSlrz1OVLeUUi+rC4Q9tvO7PXopGZ1JVVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630929430; a=rsa-sha256; cv=none; b=BaP+avWtYMIppx661jAfzQdpUcN3OoMGrL4nTXmfoL6mBfAubCGWQhb+hzkI8gLCd98U1C 3edpJ2TpIEBDUCsoNt0oWdNgNH3btrJ/tXUFrvBx0davwX64f9wzijYHI89XLgungmZeBE wrfUinFPdnNuoTOGU4y4qeIiDdb2dF6C9s9Wb0/FuSKb7zJpxWD53/t9aUzdmE0tooetlu 8RAxEobpjN9ijyJLf7rjskorwkmrA2ICfRCBgf6md/eFScDKW8M74WkuzHniJLhk2ELQnq GtwvfEJSZiVPXz18RQ7or0mTV2kDt1PbhJbVzMGh1NisCpwZJ98LxU+nwav1AA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 48DD513C81 X-Spam-Score: -2.91 X-Migadu-Scanner: scn1.migadu.com X-TUID: cIUmT8u72gsa Hi, Thiago Jung Bauermann skribis: > This fixes the build of diffutils on powerpc64le-linux, which currently > fails more often than not. The patch I=E2=80=99m adding here isn=E2=80=99= t being > shipped by Debian and hasn=E2=80=99t been seen by upstream yet. I just br= ought > it to their attention here: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34519#11 Thanks for working on this! > I=E2=80=99m not familiar with the diffutils code base, but FWIW I analysed > the patch and it looks very reasonable to me. To be honest I=E2=80=99m not > sure if it completely fixes the race condition or just makes it much > less likely to happen, but in any case I can=E2=80=99t hit the race condi= tion > anymore. > > In addition, since all it does is add a new call to the function which > checks and processes any pending signal, I don=E2=80=99t think it can cau= se > any harm. > > Finally, this patch is based on top of the one which updates diffutils > to version 3.8: > > https://issues.guix.gnu.org/50233 > > The fix works equally well in version 3.7 so if you think it=E2=80=99s not > worth updating diffutils I can rebase this patch on top of current > =E2=80=98core-updates-frozen=E2=80=99. Normally we won=E2=80=99t update diffutils on =E2=80=98core-updates-frozen= =E2=80=99. Thus, could you adjust this patch so that (1) it applies on =E2=80=98core-updates-frozen=E2=80=99, and (2) it doesn=E2=80=99t change de= rivations on other platforms (thus, the patch needs to be applied from a build phase)? Bonus point if there=E2=80=99s an upstream patch to use, as Maxime suggeste= d. TIA, Ludo=E2=80=99.