unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: dev@jpoiret.xyz, 51972@debbugs.gnu.org
Subject: [bug#51972] [PATCH core-updates-frozen] gnu: elogind: Revert changes to polkit build time detection.
Date: Fri, 19 Nov 2021 14:52:31 +0000	[thread overview]
Message-ID: <877dd4nqog.fsf@jpoiret.xyz> (raw)
In-Reply-To: <87bl2gl1hn.fsf@gnu.org>

Ludovic Courtès <ludo@gnu.org> writes:

> Could you explain what user-visible bug that fixes?
>
> I suppose commit abc9a9b74549016bc749392d3cecf86386286145 by Timothy
> this morning did not put an end to our polkit problems, right?

Right!

elogind doesn't depend on polkit when building it, but uses it when
running to check permissions of users to interact with the login daemon:
shutting down, rebooting, or changing VTs.  However, elogind checks for
the VT changing permission (org.freedesktop.login1.chvt) when trying to
activate a session.  An upstream commit that found its way into his
release broke the runtime detection of polkit, and so it was impossible
for elogind to check for the needed permissions.  This meant that among
other things, wlroots-based compositors could not take control of a seat
and so would not start.

I think we're not entirely through for polkit/elogind and friends
though, as GDM isn't able to initiate shutdowns curretly if I'm not
mistaken, but that might just need some polkit rules tweaking.  I'll
look into it when I finish rebuilding elogind dependents locally (I was
using grafts to test this patch).  At least I'm able to run sway now!

Best,
Josselin Poiret




  reply	other threads:[~2021-11-19 14:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 11:09 [bug#51972] [PATCH core-updates-frozen] gnu: elogind: Revert changes to polkit build time detection Josselin Poiret via Guix-patches via
2021-11-19 13:27 ` Ludovic Courtès
2021-11-19 14:52   ` Josselin Poiret via Guix-patches via [this message]
2021-11-19 22:24     ` bug#51972: " Timothy Sample

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dd4nqog.fsf@jpoiret.xyz \
    --to=guix-patches@gnu.org \
    --cc=51972@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).