From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SFKKF1+7l2G6xAAAgWs5BA (envelope-from ) for ; Fri, 19 Nov 2021 15:57:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AKszEl+7l2EIKAAAbx9fmQ (envelope-from ) for ; Fri, 19 Nov 2021 14:57:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 05A6C20EE3 for ; Fri, 19 Nov 2021 15:57:35 +0100 (CET) Received: from localhost ([::1]:44502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo5KY-0002Yy-51 for larch@yhetil.org; Fri, 19 Nov 2021 09:57:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49892) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo5GA-0005hh-QZ for guix-patches@gnu.org; Fri, 19 Nov 2021 09:53:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mo5GA-0006R3-Ic for guix-patches@gnu.org; Fri, 19 Nov 2021 09:53:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mo5GA-00028M-Hq for guix-patches@gnu.org; Fri, 19 Nov 2021 09:53:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51972] [PATCH core-updates-frozen] gnu: elogind: Revert changes to polkit build time detection. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Nov 2021 14:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51972 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: dev@jpoiret.xyz, 51972@debbugs.gnu.org Received: via spool by 51972-submit@debbugs.gnu.org id=B51972.16373335568164 (code B ref 51972); Fri, 19 Nov 2021 14:53:02 +0000 Received: (at 51972) by debbugs.gnu.org; 19 Nov 2021 14:52:36 +0000 Received: from localhost ([127.0.0.1]:38527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo5Fk-00027c-JQ for submit@debbugs.gnu.org; Fri, 19 Nov 2021 09:52:36 -0500 Received: from jpoiret.xyz ([206.189.101.64]:33850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo5Fi-00027S-No for 51972@debbugs.gnu.org; Fri, 19 Nov 2021 09:52:35 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id B6457184F2D; Fri, 19 Nov 2021 14:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1637333553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bP3JADg0eLsMKdUki8wTCST1K9GfY4tkvXimVnQE/tQ=; b=LvBksHsodMWvTncqbmg0hXllifQI14UZSYt5WSfyBPyPGfNBo5OlBbbOUO5E7AAfmp1d11 XhuC7zylapJ9sUz48bTvoB00DvxW5MPZ+trVsOa+a7oSqvYJE7Ikprl0kLn7jXiLqAEtE6 JmiL1X2owYP3jgSrEVtL6YdbC/G5oKr6Q+fHe3tjcSzdgorA1QesnbaVW1XzHa1pkBRcIf S9Ik20PCNsl+/pOMdxrOxmSsl3ZdUwLHAQ9HZHRD870k1bYAZQA4JAC93wbKXBUTnH8xST IsQLyJk4zPYuwsOZNA9fKtBxJewwyesoFlPhroJBJkQc8Sihhnmaf3kKxdqZpg== In-Reply-To: <87bl2gl1hn.fsf@gnu.org> References: <20211119110949.4608-1-dev@jpoiret.xyz> <87bl2gl1hn.fsf@gnu.org> Date: Fri, 19 Nov 2021 14:52:31 +0000 Message-ID: <877dd4nqog.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637333855; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bP3JADg0eLsMKdUki8wTCST1K9GfY4tkvXimVnQE/tQ=; b=gQjE7gFXXc6CPuXHaBcUE/s1aXFXbO1bJmKK0SyZlMQRTjJviTz1ztFa2td0XrO1aFQgs9 vKol56tEO49eRImQ+SAsfdndbBj604D3IrJ7WNPbMzjCQeZBU2tKQ2Ir1Xoa5Xji+Dwcr2 fnBTxEYjTzGtmeAH0u0mWlQysPwJV/fMKw1tQETevSw/jI50KcUwhmtRlIjtA9gfc8J2bf 2VVTlAqrT7ngTrPBcfh5cLI4tu22Pw/mPcHumESSBI5NwajtsG3RDqSWUMFP61oH+9C2ID GYmcacF/rtxY/f7oBrwYwrjRCY8C4eT1QZOUn0nPwrXUFcu+auqBmWCCYrx3xA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637333855; a=rsa-sha256; cv=none; b=FSahfNO8l2D0l9zsOAodupVzdqRx6fsUm1wVkGI1fW1S7vOYEZA3LmazTucct4wMJ8t9ze 1Yac8PNMshWy6gALMTnMXLSHuRAoxc/VVSsbzxUbBpI6LUWcrLIicjMyDt1QLSkIFgGzUM ZiA5MjLlJ5MZLUc9fnPiqAzg0nLgrDk9PVefUzZ9rFqwfTN6/4qaLF6ImwmSq+bjDlmMfS 9MjPXnf8CCZFjdQDtvl558jmrp03925PHC60ED0Sspe6k4sW+5GzYy8+UvmjVSd5DD8nL5 7yy6gPTa5RrAMSN276RzdNtJSr2aUNoL6eStcfo7KBcyGOYTpb9PDJ+spjhOaQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=LvBksHso; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.37 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=LvBksHso; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 05A6C20EE3 X-Spam-Score: -3.37 X-Migadu-Scanner: scn1.migadu.com X-TUID: IrLfeiVAKMt9 Ludovic Court=C3=A8s writes: > Could you explain what user-visible bug that fixes? > > I suppose commit abc9a9b74549016bc749392d3cecf86386286145 by Timothy > this morning did not put an end to our polkit problems, right? Right! elogind doesn't depend on polkit when building it, but uses it when running to check permissions of users to interact with the login daemon: shutting down, rebooting, or changing VTs. However, elogind checks for the VT changing permission (org.freedesktop.login1.chvt) when trying to activate a session. An upstream commit that found its way into his release broke the runtime detection of polkit, and so it was impossible for elogind to check for the needed permissions. This meant that among other things, wlroots-based compositors could not take control of a seat and so would not start. I think we're not entirely through for polkit/elogind and friends though, as GDM isn't able to initiate shutdowns curretly if I'm not mistaken, but that might just need some polkit rules tweaking. I'll look into it when I finish rebuilding elogind dependents locally (I was using grafts to test this patch). At least I'm able to run sway now! Best, Josselin Poiret