unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Philip McGrath <philip@philipmcgrath.com>
Cc: 58621-done@debbugs.gnu.org
Subject: bug#58621: [PATCH 0/3] import/utils: spdx-string->license: Match case-insensitively and support '+' operator.
Date: Fri, 18 Nov 2022 14:45:26 +0100	[thread overview]
Message-ID: <877czscr61.fsf_-_@gnu.org> (raw)
In-Reply-To: <13f3bbfbd88f0e9c984fd61a5c936de08d814ce0.1666146461.git.philip@philipmcgrath.com> (Philip McGrath's message of "Wed, 19 Oct 2022 01:04:49 -0400")

Hi,

Applied all three patches.  I added trivial tests for
‘spdx-string->license’ and changed ‘substring’ to ‘string-drop-right’,
which I find clearer.

Philip McGrath <philip@philipmcgrath.com> skribis:

> +     (and (string-suffix? "+" str)
> +          ;; We try the form with the + to support deprecated identifiers for
> +          ;; GNU licenses (see above).  Here, we handle other uses of +.
> +          (spdx-string->license
> +           (substring str 0 (- (string-length str) 1)))))))

I guess we can remove the “+” forms from the alist now?

Thanks,
Ludo’.




  reply	other threads:[~2022-11-18 13:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19  4:55 [bug#58621] [PATCH 0/3] import/utils: spdx-string->license: Match case-insensitively and support '+' operator Philip McGrath
2022-10-19  5:04 ` [bug#58621] [PATCH 1/3] import/utils: spdx-string->license: Fix incorrect docstring Philip McGrath
2022-10-19  5:04 ` [bug#58621] [PATCH 2/3] import/utils: spdx-string->license: Match case-insensitively Philip McGrath
2022-10-19  5:04 ` [bug#58621] [PATCH 3/3] import/utils: spdx-string->license: Support '+' operator Philip McGrath
2022-11-18 13:45   ` Ludovic Courtès [this message]
2022-11-18 20:21     ` [bug#58621] [PATCH 0/3] import/utils: spdx-string->license: Match case-insensitively and support " Philip McGrath
2022-11-20 10:49       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877czscr61.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=58621-done@debbugs.gnu.org \
    --cc=philip@philipmcgrath.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).