From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oONwH7CMd2N1ngAAbAwnHQ (envelope-from ) for ; Fri, 18 Nov 2022 14:46:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wOw9H7CMd2PmKAEAauVa8A (envelope-from ) for ; Fri, 18 Nov 2022 14:46:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 23077382E7 for ; Fri, 18 Nov 2022 14:46:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow1gy-00015e-BA; Fri, 18 Nov 2022 08:46:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow1gx-00015E-7Q for guix-patches@gnu.org; Fri, 18 Nov 2022 08:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow1gw-0003bP-VE for guix-patches@gnu.org; Fri, 18 Nov 2022 08:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow1gw-00067I-Qt for guix-patches@gnu.org; Fri, 18 Nov 2022 08:46:02 -0500 Subject: bug#58621: [PATCH 0/3] import/utils: spdx-string->license: Match case-insensitively and support '+' operator. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 18 Nov 2022 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58621 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 58621-done@debbugs.gnu.org Mail-Followup-To: 58621@debbugs.gnu.org, ludo@gnu.org, philip@philipmcgrath.com Received: via spool by 58621-done@debbugs.gnu.org id=D58621.166877913823460 (code D ref 58621); Fri, 18 Nov 2022 13:46:02 +0000 Received: (at 58621-done) by debbugs.gnu.org; 18 Nov 2022 13:45:38 +0000 Received: from localhost ([127.0.0.1]:35811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow1gX-00066K-Pj for submit@debbugs.gnu.org; Fri, 18 Nov 2022 08:45:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow1gU-00065r-JQ for 58621-done@debbugs.gnu.org; Fri, 18 Nov 2022 08:45:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow1gP-0003Vu-AW; Fri, 18 Nov 2022 08:45:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=EccoOzUJfUmqbzVs0zL4yv7+UpyL83f240uSifW1UJM=; b=Jhr4Wm7tOFf3u040+HKj fyVS524CGX8S+4GT4aBU3hHOG6VmYvw2ryeP6YYH/iJ7RUAMXg5t/TXkM4GSAwxIWNxkO9JAf9FUI Ktn3kU1gBdLFTGvWnVCWzNOIA5U5lQEm9wVFzrUeLW4LfcbEqhm6r75HDtyYQsPgL18jZBW9PpgRz nNSqmT3e7dKrGbLYcKs7WA8R/Mjb9YT4CGkwpBjjZMj2qx8AnUl74Vor8CZdUnd030VbxgZ3IZ36F qAIdrPCZTBnmCggv6Qu9VMWbYVMXYjOSobbpcMXoS1jibN4Vh0YlvrQInohGZfLR7pC/xNwqUU0Bg l8yJGASor44Lyg==; Received: from [193.50.110.147] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow1gO-00046M-Qi; Fri, 18 Nov 2022 08:45:29 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <13f3bbfbd88f0e9c984fd61a5c936de08d814ce0.1666146461.git.philip@philipmcgrath.com> Date: Fri, 18 Nov 2022 14:45:26 +0100 In-Reply-To: <13f3bbfbd88f0e9c984fd61a5c936de08d814ce0.1666146461.git.philip@philipmcgrath.com> (Philip McGrath's message of "Wed, 19 Oct 2022 01:04:49 -0400") Message-ID: <877czscr61.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668779184; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EccoOzUJfUmqbzVs0zL4yv7+UpyL83f240uSifW1UJM=; b=b692wIWe8+Wygs44y2zcND41QwjwAe4eC0Qh+NPAv92Cb5EMYGZ/PpXBkGLUjm2mGWvDA9 vtWh4/CWQcpi2cwoEcrXssV1/7/UPzhvHvn4mlVbgrVLYKJz2h3AqA3NU0P57T2FtFnclG sOSztK3YWokIK74XXogDUMQayaNfT7ebmDPDmdET9lucFkdgDH+3f3Xa8lwMeQKaYCmfbH gUgME8v5pC97hXO+U90/RUxvafSnWl69heRu18bZu1jj5fDQmGlhpibc9V0oFKYs0SkJG9 xADt8Y/tBpTkvmpZKric+rdZb6tHsCz3Wb4G3llXjqPCSGF+SVNjJzPlMBivRg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668779184; a=rsa-sha256; cv=none; b=Gd93hkWmTrDBp3/TvjRW1Wyl/Rn0krrRiIJRHJJXgdl4O6mkhDq7HTJzWVTkPXoQrZqnvK 989ZxzyTOSgyxytZlEEtqkdOXZ9ubHkbBMl++hlprTPgujOkQ60JWqLWhutSv5Ck6hDaz5 jDZU7rcvxu2hBzDk49lNNCB54hhWvi8px2Uab1vUVCYN8R4Wr9xe9lyltmVY76GgG7T9Gu FLAeiitR4O7TY4/BzY+xa9Q1/DnB/lCEZDUEPu7Van4k+NZ9jqegz0YXCac0Z+p7hv8+gq WzRhAwb/RXPWeHlmpWlefk/XOCsjmh+wRwvsHNPXZQO1iDgyh/CkXDpi9EKT+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Jhr4Wm7t; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Jhr4Wm7t; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 23077382E7 X-Spam-Score: -1.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: SgHdyyeUPqfc Hi, Applied all three patches. I added trivial tests for =E2=80=98spdx-string->license=E2=80=99 and changed =E2=80=98substring=E2=80= =99 to =E2=80=98string-drop-right=E2=80=99, which I find clearer. Philip McGrath skribis: > + (and (string-suffix? "+" str) > + ;; We try the form with the + to support deprecated identifier= s for > + ;; GNU licenses (see above). Here, we handle other uses of +. > + (spdx-string->license > + (substring str 0 (- (string-length str) 1))))))) I guess we can remove the =E2=80=9C+=E2=80=9D forms from the alist now? Thanks, Ludo=E2=80=99.