From: Ricardo Wurmus <rekado@elephly.net>
To: Andy Tai <atai@atai.org>
Cc: 63897@debbugs.gnu.org, Andreas Enge <andreas@enge.fr>
Subject: [bug#63897] [PATCH v6] gnu: tensorflow-lite: Update to 2.12.1
Date: Tue, 05 Sep 2023 09:50:31 +0200 [thread overview]
Message-ID: <877cp59hlq.fsf@elephly.net> (raw)
In-Reply-To: <ZPYjrlZJ_HqFxqDk@jurong>
Hi,
The update looks good to me. My only concerns are cosmetic:
- the indentation throughout is rather wonky. Would be good to reformat
this with Emacs C-M-q or “guix style”.
- “TO DO” —> “TODO” (so we can find it easily)
- please use “;;” for line comments; a single semicolon is only used for
margin comments
- it would be good not to use “assoc-ref %build-inputs” and use G-exps
instead.
I could make all these changes before pushing it.
Actually, there is one question I have that is not of cosmetic nature:
What’s up with the commented gemmlowp in the inputs? We have
gemmlowp-src in the native-inputs.
If you could answer this question I can take care of the rest and apply
it. Thank you for your patience!
--
Ricardo
next prev parent reply other threads:[~2023-09-05 7:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 23:28 [bug#63897] [PATCH] gnu: tensorflow_lite: Update to 2.12.0 Andy Tai
2023-06-04 23:50 ` [bug#63897] [PATCH v2] " Andy Tai
2023-06-06 8:41 ` [bug#63897] [PATCH v3] gnu: tensorflow-lite: " Andy Tai
2023-06-16 6:15 ` [bug#63897] [PATCH v4] " Andy Tai
2023-07-28 8:44 ` [bug#63897] [PATCH v5] gnu: tensorflow-lite: Update to 2.12.1 Andy Tai
2023-08-07 15:27 ` Andreas Enge
2023-09-03 4:55 ` [bug#63897] [PATCH v6] " Andy Tai
[not found] ` <ZPYjrlZJ_HqFxqDk@jurong>
2023-09-05 7:50 ` Ricardo Wurmus [this message]
2023-09-05 12:45 ` Andy Tai
2023-09-05 14:55 ` Andy Tai
2023-09-08 8:54 ` bug#63897: [PATCH] gnu: tensorflow_lite: Update to 2.12.0 Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cp59hlq.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=63897@debbugs.gnu.org \
--cc=andreas@enge.fr \
--cc=atai@atai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).