From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2LjTMd3f9mQmZgEAG6o9tA:P1 (envelope-from ) for ; Tue, 05 Sep 2023 09:59:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2LjTMd3f9mQmZgEAG6o9tA (envelope-from ) for ; Tue, 05 Sep 2023 09:59:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7750439442 for ; Tue, 5 Sep 2023 09:59:25 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=ZCSvrxch; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693900765; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=g/tRhjqUhPO7hRaA/YKTlSagi47pMyzcBS/Ckt7Px4w=; b=j8RnZPQBGPCKsCe66/7ukKD113RbSDLvKxAdmy53phZ4s61KkwGbfnG8wHjEiHSBB5/roC mtOw5Hv50ESB1Z3fRBwL+BIFwLQEBWj2qN2q6tNGARmeB97g61wPMFG6akchxvnTe+M6Cj XHqC22nWYDIG8FhH+zFdjAqmi4gEk8/4KvXm6AC1r5AyH28vAY1RQ1JSGdgfRh9gStZtG/ JqG5FvYzE2hrbooNkR2T2sFG+5XSFHb6gCJ4RSvPdHda579sA3xCpZDL2LnGKHT8YEmjy9 aUBVB52fqm/ETBJaR201M/qF0o/kCggYLdYoAjAH011Y24EqRZ1jJUqByJe+YQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1693900765; a=rsa-sha256; cv=fail; b=s4t+xvyTv6k1urD32HUjNtJGOQKTwND5h+COY0ayaLdWLQp+cG+OcTsAgJm85pdXcBXVGx jZ7RF379+xHTQ3BhrEBwjWrkm8FJ/trK6DzjzFmJzaoO8Qs5EabYtaPqnDWDK4LABrnx48 G+IdgQRoGs8GI1BU1ftBfaBPlIAYWTICtO3DxvPBD6Vr+6yueTeGB+EZ++WpRRUvB+fHFa vmLrFJkqNV/V2iD7+82LxT72oiNmI1+mVllj/qIM3nDd7vgblWP1hZNiMKo9T1qV6lV4qi T1D7q6TBgZL454i2wlglcI4roG7cdIaG9DNS6qLUcKSPHzsWQeH2jLDhHFGimg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=ZCSvrxch; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdQxp-0006go-Pb; Tue, 05 Sep 2023 03:59:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdQxi-0006fH-Ex for guix-patches@gnu.org; Tue, 05 Sep 2023 03:59:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdQxi-0000wL-6c for guix-patches@gnu.org; Tue, 05 Sep 2023 03:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdQxi-00039u-F2 for guix-patches@gnu.org; Tue, 05 Sep 2023 03:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63897] [PATCH v6] gnu: tensorflow-lite: Update to 2.12.1 Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Sep 2023 07:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63897 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andy Tai Cc: 63897@debbugs.gnu.org, Andreas Enge Received: via spool by 63897-submit@debbugs.gnu.org id=B63897.169390071612074 (code B ref 63897); Tue, 05 Sep 2023 07:59:02 +0000 Received: (at 63897) by debbugs.gnu.org; 5 Sep 2023 07:58:36 +0000 Received: from localhost ([127.0.0.1]:53324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdQxI-00038g-AP for submit@debbugs.gnu.org; Tue, 05 Sep 2023 03:58:36 -0400 Received: from sender3-of-o57.zoho.com ([136.143.184.57]:21719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdQxG-00038X-SD for 63897@debbugs.gnu.org; Tue, 05 Sep 2023 03:58:35 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1693900711; cv=none; d=zohomail.com; s=zohoarc; b=b8GcHYlx5bQ+wrQRURiCpWe1pPG7MYXOZl0+6Won9JE7sc/3UMrmJzXRk9zj3SEQIMmuWMyiWEwiSHp47a0+vtLOJeeApvT3CgYFc5togCvEOr6mxQwoTDTGvKxQXxvao/1/1EtLzov78nVuPx7CLGTBgWHyVFoYDGUG7/PSz8c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693900711; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=g/tRhjqUhPO7hRaA/YKTlSagi47pMyzcBS/Ckt7Px4w=; b=MyvlXTI+EEfiP+sJW5BrMN1KEk5FiTfcrNw3bHOAEqydPFkVYk1fIbHfgrfPm/Z4KBTcIvcO3zYQ5pxtcr1YnjK6WUC4qMu3Lc5kdS6fzJLTx2BUAWEtWmkcLEq6jK6qatiy2ku577NXFrvhO+Nvphlncs8eL4KBc2341nr4P4g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1693900711; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=g/tRhjqUhPO7hRaA/YKTlSagi47pMyzcBS/Ckt7Px4w=; b=ZCSvrxchQuBu+iFqM45UBsCL6PQTp0PjsqwMz+UJrRWvy9nrPq6pkSn9lKGrpciY F22nDYdQyZiZKGsrRX/sw9pnIpanhUNu1gg4u6hcs6xitL2IpiWgg5bkSpYIrsF2cZ6 ABpm+VZG1UT7O4zAvvYl0opxZ6HVT1TP7GSTu+Vc= Received: from localhost (113-111-142-46.pool.kielnet.net [46.142.111.113]) by mx.zohomail.com with SMTPS id 1693900708844369.2850260002208; Tue, 5 Sep 2023 00:58:28 -0700 (PDT) References: <9c48f700175bf6dfc257faf34de9e8abfae4ca23.1693716893.git.atai@atai.org> User-agent: mu4e 1.10.5; emacs 28.2 From: Ricardo Wurmus Date: Tue, 05 Sep 2023 09:50:31 +0200 In-reply-to: Message-ID: <877cp59hlq.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -4.20 X-Migadu-Queue-Id: 7750439442 X-Migadu-Spam-Score: -4.20 X-TUID: XU0xHFcI3CYZ Hi, The update looks good to me. My only concerns are cosmetic: - the indentation throughout is rather wonky. Would be good to reformat this with Emacs C-M-q or =E2=80=9Cguix style=E2=80=9D. - =E2=80=9CTO DO=E2=80=9D =E2=80=94> =E2=80=9CTODO=E2=80=9D (so we can find= it easily) - please use =E2=80=9C;;=E2=80=9D for line comments; a single semicolon is = only used for margin comments - it would be good not to use =E2=80=9Cassoc-ref %build-inputs=E2=80=9D and= use G-exps instead. I could make all these changes before pushing it. Actually, there is one question I have that is not of cosmetic nature: What=E2=80=99s up with the commented gemmlowp in the inputs? We have gemmlowp-src in the native-inputs. If you could answer this question I can take care of the rest and apply it. Thank you for your patience! --=20 Ricardo