unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#70233] [PATCH] Update emacs-lsp-mode to 9.0.0
@ 2024-04-06  6:49 Apoorv via Guix-patches via
  2024-04-06 10:12 ` [bug#70233] [PATCH v2] " Dale Mellor
  2024-04-06 15:10 ` [bug#70233] [PATCH] " Nicolas Goaziou via Guix-patches via
  0 siblings, 2 replies; 3+ messages in thread
From: Apoorv via Guix-patches via @ 2024-04-06  6:49 UTC (permalink / raw)
  To: 70233


[-- Attachment #1.1: Type: text/plain, Size: 250 bytes --]

lsp-mode got a update recently https://github.com/emacs-lsp/lsp-mode/releases/tag/9.0.0, which fixes this issue  that I was facing. So I am sharing a patch for the update.

-- 
 Sent with Tuta; enjoy secure & ad-free emails: 
 https://tuta.com

[-- Attachment #1.2: Type: text/html, Size: 616 bytes --]

[-- Attachment #2: 0001-Update-emacs-lsp-mode-to-9.0.0.patch --]
[-- Type: text/x-patch, Size: 1396 bytes --]

From 58b41a21ec3c6e3a09e869183141c17ba83c69d5 Mon Sep 17 00:00:00 2001
From: apoorv569 <apoorvs569@gmail.com>
Date: Sat, 6 Apr 2024 11:56:52 +0530
Subject: [PATCH] Update emacs-lsp-mode to 9.0.0

---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 864889b51f..f5c169b60d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30677,11 +30677,11 @@ (define-public emacs-dockerfile-mode
     (license license:asl2.0)))
 
 (define-public emacs-lsp-mode
-  (let ((commit "26c4d3e54ad2956623e64132312fe864274d346f")
+  (let ((commit "0f85b3854de0b1f54fbbbdbd542fb2fe72d1dbe6")
         (revision "1"))
     (package
       (name "emacs-lsp-mode")
-      (version (git-version "8.0.1" revision commit))
+      (version (git-version "9.0.0" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -30690,7 +30690,7 @@ (define-public emacs-lsp-mode
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "0klnik69b5y6s2q00vyshxymlg7k4x9x6m7wpsf7z9w12qn27alx"))))
+          (base32 "1njf76b67n7pqihfyj6749ib8p885wfmjkxj2ilsvqhd2xkzk95q"))))
       (build-system emacs-build-system)
       (arguments
        `(#:emacs ,emacs                 ;need libxml support
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#70233] [PATCH v2] Update emacs-lsp-mode to 9.0.0
  2024-04-06  6:49 [bug#70233] [PATCH] Update emacs-lsp-mode to 9.0.0 Apoorv via Guix-patches via
@ 2024-04-06 10:12 ` Dale Mellor
  2024-04-06 15:10 ` [bug#70233] [PATCH] " Nicolas Goaziou via Guix-patches via
  1 sibling, 0 replies; 3+ messages in thread
From: Dale Mellor @ 2024-04-06 10:12 UTC (permalink / raw)
  To: 70233; +Cc: Dale Mellor, Apoorv

From: Apoorv <apoorvs@tuta.io>

lsp-mode got an update recently
https://github.com/emacs-lsp/lsp-mode/releases/tag/9.0.0, which fixes an issue
that I was facing.

  * gnu/packages/emacs-xyz.scm[emacs-lsp-mode]: update upstream data

Review:
  * minimal change to refer to new upstream version
    * license is correct (unchanged)
    * reason for change is unclear, but updating to a new major version seems
      like a good idea!
  * guix lint is clean
  * installed, tested with rust-analyzer LSP

Reviewed-by: Dale Mellor <guix-devel-0brg6b@rdmp.org>
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e460fccc5b..db2dd41e52 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30677,11 +30677,11 @@ (define-public emacs-dockerfile-mode
     (license license:asl2.0)))
 
 (define-public emacs-lsp-mode
-  (let ((commit "26c4d3e54ad2956623e64132312fe864274d346f")
+  (let ((commit "0f85b3854de0b1f54fbbbdbd542fb2fe72d1dbe6")
         (revision "1"))
     (package
       (name "emacs-lsp-mode")
-      (version (git-version "8.0.1" revision commit))
+      (version (git-version "9.0.0" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -30690,7 +30690,7 @@ (define-public emacs-lsp-mode
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "0klnik69b5y6s2q00vyshxymlg7k4x9x6m7wpsf7z9w12qn27alx"))))
+          (base32 "1njf76b67n7pqihfyj6749ib8p885wfmjkxj2ilsvqhd2xkzk95q"))))
       (build-system emacs-build-system)
       (arguments
        `(#:emacs ,emacs                 ;need libxml support
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#70233] [PATCH] Update emacs-lsp-mode to 9.0.0
  2024-04-06  6:49 [bug#70233] [PATCH] Update emacs-lsp-mode to 9.0.0 Apoorv via Guix-patches via
  2024-04-06 10:12 ` [bug#70233] [PATCH v2] " Dale Mellor
@ 2024-04-06 15:10 ` Nicolas Goaziou via Guix-patches via
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-04-06 15:10 UTC (permalink / raw)
  To: 70233; +Cc: 70233-done, Apoorv

Hello,

Apoorv via Guix-patches via <guix-patches@gnu.org> writes:

> lsp-mode got a update recently
> https://github.com/emacs-lsp/lsp-mode/releases/tag/9.0.0, which fixes
> this issue  that I was facing. So I am sharing a patch for the update.

Thank you.

I used the "9.0.0" tag instead of a random commit hash, and normalized
commit message.

Applied!

Regards,
-- 
Nicolas Goaziou






^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-06 15:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-06  6:49 [bug#70233] [PATCH] Update emacs-lsp-mode to 9.0.0 Apoorv via Guix-patches via
2024-04-06 10:12 ` [bug#70233] [PATCH v2] " Dale Mellor
2024-04-06 15:10 ` [bug#70233] [PATCH] " Nicolas Goaziou via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).